From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 882A1C38145 for ; Tue, 6 Sep 2022 18:23:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229688AbiIFSXp (ORCPT ); Tue, 6 Sep 2022 14:23:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40910 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229799AbiIFSXm (ORCPT ); Tue, 6 Sep 2022 14:23:42 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4F76499263 for ; Tue, 6 Sep 2022 11:23:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=1ejsbWc7jxzdVv9EfTlV6LG/ILo5vqEFK0R9Sl/pPsw=; b=RcFeeBEBSNmBmJhbE5bo1gSZ/S Q0PPGU/Y24JkA4LbeK/L6cNKW9pN+rJSZKAS/PLfwAxf70EubNOTY90DX//vg7TDOnbRcuEC1kqJ6 yyfyXhPPAeEEq+FEcfE4nY/EZcL8lcm5GviAzxj13p8uBlJleJo+geC8AMCgpLmRnmRy/UBRw75GZ WbQ9ldohcl0U82HjcvImBEgkHAZulUrCLUbI0o8ZhQ2qqYufjlPRz0X1HR3cAITvHUNPnYYl9VhTh euUoKXcggwKM34/V9DgpcyCiZOguaWuyI6Ult8FqgoT1LKR08JkecWnw1wJyvv1V6yCbS9zp1R9I1 xx1W8P1g==; Received: from mcgrof by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1oVdDz-00GKFq-Le; Tue, 06 Sep 2022 18:23:03 +0000 Date: Tue, 6 Sep 2022 11:23:03 -0700 From: Luis Chamberlain To: Wupeng Ma Cc: akpm@linux-foundation.org, david@redhat.com, npiggin@suse.de, ying.huang@intel.com, hannes@cmpxchg.org, corbet@lwn.net, mgorman@suse.de, keescook@chromium.org, yzaikin@google.com, songmuchun@bytedance.com, mike.kravetz@oracle.com, osalvador@suse.de, surenb@google.com, rppt@kernel.org, charante@codeaurora.org, jsavitz@redhat.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, kernel test robot Subject: Re: [PATCH -next v3 2/2] mm: sysctl: Introduce per zone watermark_scale_factor Message-ID: References: <20220905032858.1462927-1-mawupeng1@huawei.com> <20220905032858.1462927-3-mawupeng1@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220905032858.1462927-3-mawupeng1@huawei.com> Sender: Luis Chamberlain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 05, 2022 at 11:28:58AM +0800, Wupeng Ma wrote: > diff --git a/kernel/sysctl.c b/kernel/sysctl.c > index 205d605cacc5..d16d06c71e5a 100644 > --- a/kernel/sysctl.c > +++ b/kernel/sysctl.c > @@ -2251,8 +2251,6 @@ static struct ctl_table vm_table[] = { > .maxlen = sizeof(watermark_scale_factor), > .mode = 0644, > .proc_handler = watermark_scale_factor_sysctl_handler, > - .extra1 = SYSCTL_ONE, > - .extra2 = SYSCTL_THREE_THOUSAND, > }, > { > .procname = "percpu_pagelist_high_fraction", Please move the sysctl from kernel/sysctl.c to mm/page_alloc.c while at it, you can git log the kernel/sysctl.c for prior moves and for the motivations. No need to keep expanding on the existing table. Luis