From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 48F0DC07E9D for ; Sat, 24 Sep 2022 10:13:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233784AbiIXKNv (ORCPT ); Sat, 24 Sep 2022 06:13:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53352 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233850AbiIXKNm (ORCPT ); Sat, 24 Sep 2022 06:13:42 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BB80E12889E; Sat, 24 Sep 2022 03:13:39 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 4ECC1B80DC8; Sat, 24 Sep 2022 10:13:38 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 72082C433D6; Sat, 24 Sep 2022 10:13:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1664014417; bh=2RR7JCSle62Ctd7cdprNFNuNTmoMwLRSHoPcjFErasY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=0Tw9HH0agvwO440m5y/HJwPfr43xzzV/VsRm39t4dsn1npdKjHy/MWDuw98bFO7By GjNvO3dj6iZIKCfpff0NcgYBbtzrc/OrVikuPqjLdFZ1nHLbmg7Gc2kzRXsGwJH9m9 O6xsyQEpCNlaEC3jkmNwX42igf+xwaYVyoGMYcLw= Date: Sat, 24 Sep 2022 12:13:34 +0200 From: Greg Kroah-Hartman To: Michal =?iso-8859-1?Q?Such=E1nek?= Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, Heiko Carstens , Vasily Gorbik , Christian Borntraeger , Alexander Gordeev , Sven Schnelle , Philipp Rudo , Sasha Levin , Baoquan He , Alexander Egorenkov , "open list:S390" , Catalin Marinas , Will Deacon , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" , "H. Peter Anvin" , Eric Biederman , Mimi Zohar , "Naveen N. Rao" , Andrew Morton , "moderated list:ARM64 PORT (AARCH64 ARCHITECTURE)" , "open list:LINUX FOR POWERPC (32-BIT AND 64-BIT)" , "open list:KEXEC" , Coiby Xu , keyrings@vger.kernel.org, linux-security-module@vger.kernel.org, James Morse , AKASHI Takahiro Subject: Re: [PATCH 5.15 0/6] arm64: kexec_file: use more system keyrings to verify kernel image signature + dependencies Message-ID: References: <20220924094521.GY28810@kitsune.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220924094521.GY28810@kitsune.suse.cz> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Sep 24, 2022 at 11:45:21AM +0200, Michal Suchánek wrote: > On Sat, Sep 24, 2022 at 11:19:19AM +0200, Greg Kroah-Hartman wrote: > > On Fri, Sep 23, 2022 at 07:10:28PM +0200, Michal Suchanek wrote: > > > Hello, > > > > > > this is backport of commit 0d519cadf751 > > > ("arm64: kexec_file: use more system keyrings to verify kernel image signature") > > > to table 5.15 tree including the preparatory patches. > > > > This feels to me like a new feature for arm64, one that has never worked > > before and you are just making it feature-parity with x86, right? > > > > Or is this a regression fix somewhere? Why is this needed in 5.15.y and > > why can't people who need this new feature just use a newer kernel > > version (5.19?) > > It's half-broken implementation of the kexec kernel verification. At the time > it was implemented for arm64 we had the platform and secondary keyrings > and x86 was using them but on arm64 the initial implementation ignores > them. Ok, so it's something that never worked. Adding support to get it to work doesn't really fall into the stable kernel rules, right? Again, what's wrong with 5.19 for anyone who wants this? Who does want this? thanks, greg k-h