From: Yury Norov <yury.norov@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Rasmus Villemoes <linux@rasmusvillemoes.dk>,
Andrew Morton <akpm@linux-foundation.org>,
Stephen Rothwell <sfr@canb.auug.org.au>,
Peter Zijlstra <peterz@infradead.org>,
Thomas Gleixner <tglx@linutronix.de>,
"Paul E . McKenney" <paulmck@kernel.org>,
Vlastimil Babka <vbabka@suse.cz>,
Dmitry Vyukov <dvyukov@google.com>,
Valentin Schneider <vschneid@redhat.com>,
Sander Vanheule <sander@svanheule.net>,
Alexey Klimov <klimov.linux@gmail.com>,
David Laight <David.Laight@aculab.com>,
Eric Biggers <ebiggers@google.com>
Subject: Re: [PATCH v2 0/5] cpumask: cleanup nr_cpu_ids vs nr_cpumask_bits mess
Date: Thu, 15 Sep 2022 07:45:49 -0700 [thread overview]
Message-ID: <YyM6nVBE+AMaxvrO@yury-laptop> (raw)
In-Reply-To: <20220905230820.3295223-1-yury.norov@gmail.com>
On Mon, Sep 05, 2022 at 04:08:15PM -0700, Yury Norov wrote:
> cpumask subsystem uses nr_cpu_ids and nr_cpumask_bits interchangeably
> despite that the variables have different meaning and purpose. It makes
> some cpumask functions broken.
>
> This series cleans that mess and adds new config FORCE_NR_CPUS that
> allows to optimize cpumask subsystem if the number of CPUs is known
> at compile-time.
>
> After some testing I found build broken when SMP is on and NR_CPUS == 1.
> This is addressed in a new patch #1, and in the following patch #2 that
> now declares set_nr_cpu_ids in cpumask.h (was in smp.h).
>
> v1: https://lore.kernel.org/lkml/20220829165748.1008477-1-yury.norov@gmail.com/T/#mecbd787f8d1bff1454a4ec2fe46ad6dc168df695
> v2:
> - don't declare nr_cpu_ids if NR_CPUS == 1;
> - move set_nr_cpu_ids() from smp.h to cpumask.h to avoid errors in some
> inclusion paths;
> - drop 'default n' in FORCE_NR_CPUS option description;
> - rebase on top of v6.0-rc4.
Any more comments? If not, I'd like to move it into bitmap-for-next.
prev parent reply other threads:[~2022-09-15 14:45 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-05 23:08 [PATCH v2 0/5] cpumask: cleanup nr_cpu_ids vs nr_cpumask_bits mess Yury Norov
2022-09-05 23:08 ` [PATCH v2 1/5] smp: don't declare nr_cpu_ids if NR_CPUS == 1 Yury Norov
2022-09-06 8:53 ` Peter Zijlstra
2022-09-06 14:06 ` Yury Norov
2022-09-06 14:36 ` Peter Zijlstra
2022-09-06 15:01 ` Andy Shevchenko
2022-09-06 17:53 ` Peter Zijlstra
2022-09-06 15:07 ` Yury Norov
2022-09-07 8:02 ` David Laight
2022-09-05 23:08 ` [PATCH v2 2/5] smp: add set_nr_cpu_ids() Yury Norov
2022-09-05 23:08 ` [PATCH v2 3/5] lib/cpumask: delete misleading comment Yury Norov
2022-09-05 23:08 ` [PATCH v2 4/5] lib/cpumask: deprecate nr_cpumask_bits Yury Norov
2022-09-05 23:08 ` [PATCH v2 5/5] lib/cpumask: add FORCE_NR_CPUS config option Yury Norov
2022-10-18 8:21 ` Geert Uytterhoeven
2022-10-18 13:15 ` Geert Uytterhoeven
2022-10-18 13:41 ` Andreas Schwab
2022-10-18 13:50 ` Geert Uytterhoeven
2022-10-18 14:35 ` Yury Norov
2022-10-18 14:44 ` Andy Shevchenko
2022-10-18 14:59 ` Yury Norov
2022-10-18 15:15 ` Geert Uytterhoeven
2022-10-18 16:16 ` Yury Norov
2022-10-19 6:58 ` Geert Uytterhoeven
2022-09-06 8:55 ` [PATCH v2 0/5] cpumask: cleanup nr_cpu_ids vs nr_cpumask_bits mess Peter Zijlstra
2022-09-06 12:06 ` Valentin Schneider
2022-09-06 14:38 ` Peter Zijlstra
2022-09-06 15:45 ` Valentin Schneider
2022-09-06 16:26 ` Yury Norov
2022-09-06 14:48 ` Yury Norov
2022-09-06 14:35 ` Yury Norov
2022-09-15 14:45 ` Yury Norov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YyM6nVBE+AMaxvrO@yury-laptop \
--to=yury.norov@gmail.com \
--cc=David.Laight@aculab.com \
--cc=akpm@linux-foundation.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=dvyukov@google.com \
--cc=ebiggers@google.com \
--cc=klimov.linux@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=paulmck@kernel.org \
--cc=peterz@infradead.org \
--cc=sander@svanheule.net \
--cc=sfr@canb.auug.org.au \
--cc=tglx@linutronix.de \
--cc=vbabka@suse.cz \
--cc=vschneid@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).