From: Herbert Xu <herbert@gondor.apana.org.au>
To: 'Guanjun' <guanjun@linux.alibaba.com>
Cc: elliott@hpe.com, zelin.deng@linux.alibaba.com,
xuchun.shang@linux.alibaba.com, artie.ding@linux.alibaba.com,
linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH RESEND v1 1/9] crypto/ycc: Add YCC (Yitian Cryptography Complex) accelerator driver
Date: Fri, 16 Sep 2022 17:35:41 +0800 [thread overview]
Message-ID: <YyRDbT0fQQwsVpKL@gondor.apana.org.au> (raw)
In-Reply-To: <1662435353-114812-2-git-send-email-guanjun@linux.alibaba.com>
On Tue, Sep 06, 2022 at 11:35:45AM +0800, 'Guanjun' wrote:
.
> +static const struct file_operations ycc_fops = {
> + .open = ycc_cdev_open,
> + .release = ycc_cdev_release,
> + .unlocked_ioctl = ycc_cdev_ioctl,
> +};
What is this device for? It doesn't seem to do anything so why
not jsut drop it?
Thanks,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2022-09-16 9:35 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-06 3:35 [PATCH RESEND v1 0/9] Drivers for Alibaba YCC (Yitian Cryptography Complex) cryptographic accelerator 'Guanjun'
2022-09-06 3:35 ` [PATCH RESEND v1 1/9] crypto/ycc: Add YCC (Yitian Cryptography Complex) accelerator driver 'Guanjun'
2022-09-16 9:35 ` Herbert Xu [this message]
2022-09-19 2:44 ` guanjun
2022-09-23 1:53 ` guanjun
2022-09-06 3:35 ` [PATCH RESEND v1 2/9] crypto/ycc: Add ycc ring configuration 'Guanjun'
2022-09-06 3:35 ` [PATCH RESEND v1 3/9] crypto/ycc: Add irq support for ycc kernel rings 'Guanjun'
2022-09-06 3:35 ` [PATCH RESEND v1 4/9] crypto/ycc: Add device error handling support for ycc hw errors 'Guanjun'
2022-09-06 3:35 ` [PATCH RESEND v1 5/9] crypto/ycc: Add skcipher algorithm support 'Guanjun'
2022-09-06 3:35 ` [PATCH RESEND v1 6/9] crypto/ycc: Add aead " 'Guanjun'
2022-09-06 3:35 ` [PATCH RESEND v1 7/9] crypto/ycc: Add rsa " 'Guanjun'
2022-09-06 3:35 ` [PATCH RESEND v1 8/9] crypto/ycc: Add sm2 " 'Guanjun'
2022-09-06 3:35 ` [PATCH RESEND v1 9/9] MAINTAINERS: Add Yitian Cryptography Complex (YCC) driver maintainer entry 'Guanjun'
2022-09-16 7:08 ` [PATCH RESEND v1 0/9] Drivers for Alibaba YCC (Yitian Cryptography Complex) cryptographic accelerator guanjun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YyRDbT0fQQwsVpKL@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=artie.ding@linux.alibaba.com \
--cc=elliott@hpe.com \
--cc=guanjun@linux.alibaba.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=xuchun.shang@linux.alibaba.com \
--cc=zelin.deng@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).