linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
To: Bastian Rieck <bastian@rieck.me>
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
	grzegorz.alibozek@gmail.com, andrew.co@free.fr,
	meven29@gmail.com, pchernik@gmail.com, jorge.cep.mart@gmail.com,
	danielmorgan@disroot.org, bernie@codewiz.org,
	saipavanchitta1998@gmail.com, rubin@starset.net,
	maniette@gmail.com, nate@kde.org
Subject: Re: [RFC PATCH 0/2] usb: typec: ucsi: Check connection on resume
Date: Fri, 16 Sep 2022 13:46:47 +0300	[thread overview]
Message-ID: <YyRUF5cFGpe2xf+m@kuha.fi.intel.com> (raw)
In-Reply-To: <YxrbtWDR7XI4s+Q+@kuha.fi.intel.com>

Hi Bastian,

On Fri, Sep 09, 2022 at 09:22:50AM +0300, Heikki Krogerus wrote:
> On Thu, Sep 08, 2022 at 07:01:34AM +0200, Bastian Rieck wrote:
> > Dear Heikki,
> > 
> > > I'm sending these as an RFC first because I'm not done testing.
> > > 
> > > I made a small modification to my original proposal (in the bug
> > > report). Now also connection during suspend should be covered.
> > > 
> > > I would appreciate if you guys could test these again. If
> > > everything works, and the bug is fixed, let me know, and I'll add
> > > your Tested-by tags to the patches.
> > >
> > 
> > Thanks so much for these changes—that's awesome! I have just finished 
> > testing this against 5.19.7 (Arch Linux) with a Lenovo X1 (Gen 9).
> > 
> > I am very happy to see that, as far as I can tell, the issue 
> > disappeared completely!
> > 
> > However, I am receiving additional warnings via `journalctl` that I 
> > did not receive before; I have attached this trace as an additional 
> > log file. Nothing in there seems critical and I can confirm that the 
> > system continues to operate normally. I merely wanted to provide you 
> > with this additional information in case it is of relevance.
> > 
> > Please let me know if there's anything else I can do here; I really 
> > appreciate the time you spent on this!
> 
> Thank you for the report. That warning certainly needs to be sorted
> out before I send the final versions. I'll try to reproduce that.

I'm not getting anywhere with this one. Could you provide me with the
trace output from both module and ucsi events?

To enable those events - assuming debugfs is mounted to
/sys/kernel/debug:

        % echo 1 > /sys/kernel/debug/tracing/events/ucsi/enable
        % echo 1 > /sys/kernel/debug/tracing/events/module/enable

Run the suspend resume cycle, and then dump the trace output to a
file:

        % cat /sys/kernel/debug/tracing/trace > ucsi_trace

thanks,

-- 
heikki

  reply	other threads:[~2022-09-16 10:59 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-07 11:56 [RFC PATCH 0/2] usb: typec: ucsi: Check connection on resume Heikki Krogerus
2022-09-07 11:56 ` [RFC PATCH 1/2] usb: typec: ucsi: Check the " Heikki Krogerus
2022-09-07 11:56 ` [RFC PATCH 2/2] usb: typec: ucsi: acpi: Add PM hooks Heikki Krogerus
2022-09-07 21:33 ` [RFC PATCH 0/2] usb: typec: ucsi: Check connection on resume Grzegorz Alibożek
2022-09-08  5:01 ` Bastian Rieck
2022-09-09  6:22   ` Heikki Krogerus
2022-09-16 10:46     ` Heikki Krogerus [this message]
2022-10-07 10:00       ` Bastian Rieck
2022-10-07 10:04         ` Heikki Krogerus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YyRUF5cFGpe2xf+m@kuha.fi.intel.com \
    --to=heikki.krogerus@linux.intel.com \
    --cc=andrew.co@free.fr \
    --cc=bastian@rieck.me \
    --cc=bernie@codewiz.org \
    --cc=danielmorgan@disroot.org \
    --cc=grzegorz.alibozek@gmail.com \
    --cc=jorge.cep.mart@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=maniette@gmail.com \
    --cc=meven29@gmail.com \
    --cc=nate@kde.org \
    --cc=pchernik@gmail.com \
    --cc=rubin@starset.net \
    --cc=saipavanchitta1998@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).