From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6243BECAAD3 for ; Mon, 19 Sep 2022 17:12:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229693AbiISRMa (ORCPT ); Mon, 19 Sep 2022 13:12:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38062 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230351AbiISRMA (ORCPT ); Mon, 19 Sep 2022 13:12:00 -0400 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 838A343E69 for ; Mon, 19 Sep 2022 10:10:08 -0700 (PDT) Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 37A80499; Mon, 19 Sep 2022 19:09:30 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1663607370; bh=+JOu5w44ME48gxryK0sjEV1XSCxm/SeQ98U0M2e5jNs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=lsrkMT2nP3NJyn8T/JKAXqiWHNtDqMLUo/XcbPx8YMaKk6vWOekP3NKPZrHLTcA2D tSZefS5iVHYeFCEMIOgCsbk9Mf8Dd82mb7LefJhsPSO28CkxapanFDAKB0ff6CIpqc aYGlThFpQlB4ooA7pFxnAJNptYdb5xzrwEsfBQL4= Date: Mon, 19 Sep 2022 20:09:16 +0300 From: Laurent Pinchart To: Nathan Huckleberry Cc: Dan Carpenter , llvm@lists.linux.dev, Hyun Kwon , David Airlie , Daniel Vetter , Michal Simek , Nathan Chancellor , Nick Desaulniers , Tom Rix , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drm: xlnx: Fix return type of zynqmp_dp_connector_mode_valid Message-ID: References: <20220913205600.155172-1-nhuck@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20220913205600.155172-1-nhuck@google.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Nathan, Thank you for the patch. On Tue, Sep 13, 2022 at 01:56:00PM -0700, Nathan Huckleberry wrote: > The mode_valid field in drm_connector_helper_funcs is expected to be of > type > enum drm_mode_status (* mode_valid) (struct drm_connector *connector, > struct drm_display_mode *mode); > > The mismatched return type breaks forward edge kCFI since the underlying > function definition does not match the function hook definition. > > The return type of zynqmp_dp_connector_mode_valid should be changed from > int to enum drm_mode_status. > > Reported-by: Dan Carpenter > Link: https://github.com/ClangBuiltLinux/linux/issues/1703 > Cc: llvm@lists.linux.dev > Signed-off-by: Nathan Huckleberry I'm not sure what forward edge kCFI is, but the fix looks good, so Reviewed-by: Laurent Pinchart > --- > drivers/gpu/drm/xlnx/zynqmp_dp.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/xlnx/zynqmp_dp.c b/drivers/gpu/drm/xlnx/zynqmp_dp.c > index d14612b34796..f571b08d23d3 100644 > --- a/drivers/gpu/drm/xlnx/zynqmp_dp.c > +++ b/drivers/gpu/drm/xlnx/zynqmp_dp.c > @@ -1352,8 +1352,9 @@ zynqmp_dp_connector_best_encoder(struct drm_connector *connector) > return &dp->encoder; > } > > -static int zynqmp_dp_connector_mode_valid(struct drm_connector *connector, > - struct drm_display_mode *mode) > +static enum drm_mode_status > +zynqmp_dp_connector_mode_valid(struct drm_connector *connector, > + struct drm_display_mode *mode) > { > struct zynqmp_dp *dp = connector_to_dp(connector); > u8 max_lanes = dp->link_config.max_lanes; -- Regards, Laurent Pinchart