From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Hyeonggon Yoo <42.hyeyoo@gmail.com>
Cc: Maurizio Lombardi <mlombard@redhat.com>,
vbabka@suse.cz, linux-mm@kvack.org, rientjes@google.com,
penberg@kernel.org, iamjoonsoo.kim@lge.com,
akpm@linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V3] mm: slub: fix flush_cpu_slab()/__free_slab() invocations in task context.
Date: Tue, 20 Sep 2022 09:56:59 +0200 [thread overview]
Message-ID: <YylyS7rKigh85sGa@linutronix.de> (raw)
In-Reply-To: <Yylv4TRbrhwCrCnR@hyeyoo>
On 2022-09-20 16:46:41 [+0900], Hyeonggon Yoo wrote:
> > @@ -2730,7 +2735,7 @@ static void flush_all_cpus_locked(struct kmem_cache *s)
> > INIT_WORK(&sfw->work, flush_cpu_slab);
> > sfw->skip = false;
> > sfw->s = s;
> > - schedule_work_on(cpu, &sfw->work);
> > + queue_work_on(cpu, flushwq, &sfw->work);
>
> Hi. what happens here if flushwq failed?
>
> I think avoiding BUG_ON() makes sense,
> but shouldn't we have fallback method?
You get an output to act on and fix. The point is that it shouldn't have
happen in the first place. With the bug_on() that early, chances are
that you never see anything but a blank screen. So with the warn_on you
get probably to see the warn_on before you get here.
Sebastian
next prev parent reply other threads:[~2022-09-20 7:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-19 16:39 [PATCH V3] mm: slub: fix flush_cpu_slab()/__free_slab() invocations in task context Maurizio Lombardi
2022-09-19 17:30 ` Vlastimil Babka
2022-09-20 7:46 ` Hyeonggon Yoo
2022-09-20 7:56 ` Sebastian Andrzej Siewior [this message]
2022-09-20 9:27 ` Hyeonggon Yoo
2022-09-20 9:31 ` Hyeonggon Yoo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YylyS7rKigh85sGa@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=42.hyeyoo@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=iamjoonsoo.kim@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mlombard@redhat.com \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).