From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 331C8ECAAD8 for ; Tue, 20 Sep 2022 12:35:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229741AbiITMfy (ORCPT ); Tue, 20 Sep 2022 08:35:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53776 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231297AbiITMfi (ORCPT ); Tue, 20 Sep 2022 08:35:38 -0400 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 921DE75483; Tue, 20 Sep 2022 05:35:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1663677333; x=1695213333; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=CQ0JS/VqnHFEwfrs/FBkCjfMdg77UcNq/QWSA/6J0aI=; b=Zd6Px3MsAj9rypgNd1vOJb+2LDtWCmrzf8XAuBn1aZdpNQlTCmFMQXpu OUR8kIJHO+2PbLjCiTb4a53dtD8QT+um+mvzGrGdyLObaRZWmppMhNQEu hRu6yBxjVw4YsnWN1ILV1l2949pJBuLB9F0sKz+PQCG2PIhrlq9WKCOPa EH10sTwDVOXgoqC7BrhqHOE2DZtkXrzgqeUAsITS5NazZewHW0hAcAmwB xyUf45RhVUPOtx5u/XTwBPTxCwhzzO00cMRydYX95WI7Ui0loVklDIyBE ILxBH3HMjJ0vD9Ix35VpFO3QHbl1n9Pyqz64M17GVpMy5PJI3IzpLctW+ g==; X-IronPort-AV: E=McAfee;i="6500,9779,10476"; a="298405309" X-IronPort-AV: E=Sophos;i="5.93,330,1654585200"; d="scan'208";a="298405309" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Sep 2022 05:35:32 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,330,1654585200"; d="scan'208";a="652077555" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga001.jf.intel.com with ESMTP; 20 Sep 2022 05:35:27 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1oacTF-004zS1-1F; Tue, 20 Sep 2022 15:35:25 +0300 Date: Tue, 20 Sep 2022 15:35:25 +0300 From: Andy Shevchenko To: Raul E Rangel Cc: linux-acpi@vger.kernel.org, linux-input@vger.kernel.org, timvp@google.com, hdegoede@redhat.com, rafael@kernel.org, mario.limonciello@amd.com, jingle.wu@emc.com.tw, mika.westerberg@linux.intel.com, dmitry.torokhov@gmail.com, linus.walleij@linaro.org, Dan Williams , Greg Kroah-Hartman , Jonathan Cameron , Len Brown , Terry Bowman , linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 06/13] ACPI: resources: Add wake_capable parameter to acpi_dev_irq_flags Message-ID: References: <20220919155916.1044219-1-rrangel@chromium.org> <20220919095504.v4.6.I8092e417a8152475d13d8d638eb4c5d8ea12ac7b@changeid> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220919095504.v4.6.I8092e417a8152475d13d8d638eb4c5d8ea12ac7b@changeid> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 19, 2022 at 09:59:08AM -0600, Raul E Rangel wrote: > ACPI IRQ/Interrupt resources contain a bit that describes if the > interrupt should wake the system. This change exposes that bit via > a new IORESOURCE_IRQ_WAKECAPABLE flag. Drivers should check this flag > before arming an IRQ to wake the system. (A nit-pick, but because of other patch comment) ... > - acpi_dev_get_irqresource(res, ext_irq->interrupts[index], > - ext_irq->triggering, ext_irq->polarity, > - ext_irq->shareable, false); > + acpi_dev_get_irqresource(res, > + ext_irq->interrupts[index], > + ext_irq->triggering, > + ext_irq->polarity, > + ext_irq->shareable, > + ext_irq->wake_capable, > + false); I understand this is done by a script, but it's unrelated indentation changes, please just change what is related, like: - ext_irq->shareable, false); + ext_irq->shareable, ext_irq->wake_capable, + false); -- With Best Regards, Andy Shevchenko