From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F0A4DC433FE for ; Fri, 7 Oct 2022 09:19:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229643AbiJGJT3 (ORCPT ); Fri, 7 Oct 2022 05:19:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43246 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229459AbiJGJTZ (ORCPT ); Fri, 7 Oct 2022 05:19:25 -0400 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EB7236C972; Fri, 7 Oct 2022 02:19:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1665134364; x=1696670364; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=hoHyGOlZw7mT9PchNcyohGTzSrqH9AYZczrdE0VAU4M=; b=kyCvqBubOBZezdH4TXrbtP66CK3UlyUQMU9C7cPYB3JOtRsdCM8vWUvb oILIO7/RWD0qYRN4H792aarVY8yq7XVBGxNmdQgCUOE8PIYvkXcJ0IcXO XTafkxrVhl4nrw6KrxEy0d4gMDqqyPGd5Zx9JmtDuojcliTB/QhLKpNPc FJ8t4TjaxfgAmZ0o0L1CGGzcWubBo9s96B7go8eLTiBUcFcxoUsiUdliQ Dxzkolt3zaGPSq2rKE4r9h6waaXg831bN6KrnmjI/21yqwdL6v8zTBc9B A7nNHU6DjvqFwAbgQmlLTAI4ldbsPVqOazJWaZeGhOI9jpBFmlaCSdIHi Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10492"; a="303672950" X-IronPort-AV: E=Sophos;i="5.95,166,1661842800"; d="scan'208";a="303672950" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Oct 2022 02:19:24 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10492"; a="620197894" X-IronPort-AV: E=Sophos;i="5.95,166,1661842800"; d="scan'208";a="620197894" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga007.jf.intel.com with ESMTP; 07 Oct 2022 02:19:20 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1ogjVm-003Xxs-1k; Fri, 07 Oct 2022 12:19:18 +0300 Date: Fri, 7 Oct 2022 12:19:18 +0300 From: Andy Shevchenko To: ChiaEn Wu Cc: pavel@ucw.cz, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, matthias.bgg@gmail.com, jic23@kernel.org, lars@metafoo.de, chiaen_wu@richtek.com, alice_chen@richtek.com, cy_huang@richtek.com, linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, szunichen@gmail.com Subject: Re: [PATCH v13 5/5] leds: flash: mt6370: Add MediaTek MT6370 flashlight support Message-ID: References: <1bcd19dbd09650ddac7b96b0fe2932698be2731e.1664991040.git.chiaen_wu@richtek.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 07, 2022 at 09:28:17AM +0800, ChiaEn Wu wrote: > On Wed, Oct 5, 2022 at 8:15 PM Andy Shevchenko > wrote: ... > > > +config LEDS_MT6370_FLASH > > > + tristate "Flash LED Support for MediaTek MT6370 PMIC" > > > > > + depends on LEDS_CLASS && OF > > > > Why do you have OF dependency? > > > > Hi Andy, > The original idea is to use the "fwnode_property_*" related function. > But this side may only consider just "Build Pass" (?) Yes, you increase a compile test coverage by dropping that dependency. > I will remove "OF" in the v14 patch. -- With Best Regards, Andy Shevchenko