From: Lee Jones <lee.jones@linaro.org>
To: Mark Brown <broonie@kernel.org>
Cc: Chunyan Zhang <zhang.lyra@gmail.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org, Baolin Wang <baolin.wang7@gmail.com>,
Orson Zhai <orsonzhai@gmail.com>,
Chunyan Zhang <chunyan.zhang@unisoc.com>,
LKML <linux-kernel@vger.kernel.org>, Lee Jones <lee@kernel.org>
Subject: Re: [PATCH v2 2/2] dt-bindings: regulator: Add bindings for Unisoc's SC2730 regulator
Date: Mon, 26 Sep 2022 07:59:08 +0100 [thread overview]
Message-ID: <YzFNvByGG7ADWfmd@google.com> (raw)
In-Reply-To: <YyxKSjMPlGPfegpJ@sirena.org.uk>
On Thu, 22 Sep 2022, Mark Brown wrote:
> On Thu, Sep 22, 2022 at 11:19:08AM +0100, Lee Jones wrote:
> > On Thu, 22 Sep 2022, Chunyan Zhang wrote:
>
> > > I understand your point. But like I described previously [1], if we
> > > still use the current solution (i.e. use devm_of_platform_populate()
> > > to register MFD subdevices), a compatible string is required. I'm open
> > > to switching to other solutions, do you have some suggestions?
> >
> > Many IPs encompassing multiple functions are described that way in
> > DT. I don't have the details for *this* device to hand, so my
> > comments here aren't specific to this use-case, but describing each
> > function individually does describe the H/W accurately, which is all
> > DT calls for.
>
> If people want to describe the individual regulators that'd be
> less of an issue, it's mainly when you're nesting what's
> effectively another MFD within a parent MFD that it's just noise
> that's being added to the DT.
As I say, I haven't studied this use-case.
These comments were designed to be more generic.
What do you mean by nested MFDs?
> > Can you imagine describing an SoC, which can be considered as a huge
> > MFD, with only a single node?
>
> Honestly we should be arranging things so they're more like that,
> at least using overlays for the internals of the SoC so you don't
> have to rebuild the whole DT for updates to the SoC internals.
Right, there would be one device root node. However each function;
clock providers, regulator controllers, PWMs, GPIOs, networking
(various), reset, watchdog, etc would have their own nodes. Rather
than attempting to describe everything in the parent's node.
--
DEPRECATED: Please use lee@kernel.org
next prev parent reply other threads:[~2022-09-26 6:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-08 3:19 [PATCH v2 0/2] Add Unisoc's SC2730 regulator support Chunyan Zhang
2021-10-08 3:19 ` [PATCH v2 1/2] regulator: Add Unisoc's SC2730 regulator driver Chunyan Zhang
2021-10-08 3:19 ` [PATCH v2 2/2] dt-bindings: regulator: Add bindings for Unisoc's SC2730 regulator Chunyan Zhang
2021-11-12 13:46 ` Mark Brown
2022-09-22 8:25 ` Chunyan Zhang
2022-09-22 10:19 ` Lee Jones
2022-09-22 11:43 ` Mark Brown
2022-09-26 6:59 ` Lee Jones [this message]
2022-09-28 17:27 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YzFNvByGG7ADWfmd@google.com \
--to=lee.jones@linaro.org \
--cc=baolin.wang7@gmail.com \
--cc=broonie@kernel.org \
--cc=chunyan.zhang@unisoc.com \
--cc=devicetree@vger.kernel.org \
--cc=lee@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=orsonzhai@gmail.com \
--cc=robh+dt@kernel.org \
--cc=zhang.lyra@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).