From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Miguel Ojeda <ojeda@kernel.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-fsdevel@vger.kernel.org, patches@lists.linux.dev,
Jarkko Sakkinen <jarkko@kernel.org>,
Boqun Feng <boqun.feng@gmail.com>
Subject: Re: [PATCH v10 03/27] kallsyms: add static relationship between `KSYM_NAME_LEN{,_BUFFER}`
Date: Tue, 27 Sep 2022 16:54:47 +0200 [thread overview]
Message-ID: <YzMOt2wSugmHzQD1@kroah.com> (raw)
In-Reply-To: <20220927131518.30000-4-ojeda@kernel.org>
On Tue, Sep 27, 2022 at 03:14:34PM +0200, Miguel Ojeda wrote:
> This adds a static assert to ensure `KSYM_NAME_LEN_BUFFER`
> gets updated when `KSYM_NAME_LEN` changes.
>
> The relationship used is one that keeps the new size (512+1)
> close to the original buffer size (500).
>
> Co-developed-by: Boqun Feng <boqun.feng@gmail.com>
> Signed-off-by: Boqun Feng <boqun.feng@gmail.com>
> Signed-off-by: Miguel Ojeda <ojeda@kernel.org>
> ---
> scripts/kallsyms.c | 14 ++++++++++++--
> 1 file changed, 12 insertions(+), 2 deletions(-)
>
> diff --git a/scripts/kallsyms.c b/scripts/kallsyms.c
> index 25e2fe5fbcd4..411ff5058b51 100644
> --- a/scripts/kallsyms.c
> +++ b/scripts/kallsyms.c
> @@ -32,8 +32,18 @@
>
> #define KSYM_NAME_LEN 128
>
> -/* A substantially bigger size than the current maximum. */
> -#define KSYM_NAME_LEN_BUFFER 499
> +/*
> + * A substantially bigger size than the current maximum.
> + *
> + * It cannot be defined as an expression because it gets stringified
> + * for the fscanf() format string. Therefore, a _Static_assert() is
> + * used instead to maintain the relationship with KSYM_NAME_LEN.
> + */
> +#define KSYM_NAME_LEN_BUFFER 512
> +_Static_assert(
> + KSYM_NAME_LEN_BUFFER == KSYM_NAME_LEN * 4,
> + "Please keep KSYM_NAME_LEN_BUFFER in sync with KSYM_NAME_LEN"
> +);
Messy, but I can't think of any other way right now either :(
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
next prev parent reply other threads:[~2022-09-27 14:56 UTC|newest]
Thread overview: 109+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-27 13:14 [PATCH v10 00/27] Rust support Miguel Ojeda
2022-09-27 13:14 ` [PATCH v10 01/27] kallsyms: use `ARRAY_SIZE` instead of hardcoded size Miguel Ojeda
2022-09-27 14:05 ` Geert Stappers
2022-09-27 14:51 ` Greg Kroah-Hartman
2022-09-28 14:58 ` Wei Liu
2022-09-27 13:14 ` [PATCH v10 02/27] kallsyms: avoid hardcoding buffer size Miguel Ojeda
2022-09-27 14:52 ` Greg Kroah-Hartman
2022-09-28 14:59 ` Wei Liu
2022-09-27 13:14 ` [PATCH v10 03/27] kallsyms: add static relationship between `KSYM_NAME_LEN{,_BUFFER}` Miguel Ojeda
2022-09-27 14:54 ` Greg Kroah-Hartman [this message]
2022-09-27 13:14 ` [PATCH v10 04/27] kallsyms: support "big" kernel symbols Miguel Ojeda
2022-09-27 14:55 ` Greg Kroah-Hartman
2022-10-29 17:41 ` Guenter Roeck
2022-10-29 18:23 ` Guenter Roeck
2022-09-27 13:14 ` [PATCH v10 05/27] kallsyms: increase maximum kernel symbol length to 512 Miguel Ojeda
2022-09-27 14:56 ` Greg Kroah-Hartman
2022-09-27 13:14 ` [PATCH v10 06/27] rust: add C helpers Miguel Ojeda
2022-09-27 14:59 ` Greg Kroah-Hartman
2022-09-27 13:14 ` [PATCH v10 07/27] rust: import upstream `alloc` crate Miguel Ojeda
2022-09-27 13:14 ` [PATCH v10 08/27] rust: adapt `alloc` crate to the kernel Miguel Ojeda
2022-09-27 13:51 ` Konstantin Shelekhin
2022-09-27 14:06 ` Miguel Ojeda
2022-09-27 15:13 ` Konstantin Shelekhin
2022-09-27 16:01 ` Miguel Ojeda
2022-09-27 15:35 ` Greg Kroah-Hartman
2022-09-28 15:10 ` Wei Liu
2022-09-28 15:25 ` Miguel Ojeda
2022-09-28 15:27 ` Wei Liu
2022-09-27 13:14 ` [PATCH v10 09/27] rust: add `compiler_builtins` crate Miguel Ojeda
2022-09-28 13:25 ` Wei Liu
2022-09-27 13:14 ` [PATCH v10 10/27] rust: add `macros` crate Miguel Ojeda
2022-09-27 13:48 ` Konstantin Shelekhin
2022-09-27 13:59 ` Geert Stappers
2022-09-27 14:01 ` Miguel Ojeda
2022-09-28 15:29 ` Wei Liu
2022-09-28 16:36 ` Miguel Ojeda
2022-09-27 13:14 ` [PATCH v10 11/27] rust: add `bindings` crate Miguel Ojeda
2022-09-27 15:23 ` Greg Kroah-Hartman
2022-09-27 13:14 ` [PATCH v10 12/27] rust: add `kernel` crate Miguel Ojeda
2022-09-27 15:22 ` Greg Kroah-Hartman
2022-09-27 15:36 ` Alex Gaynor
2022-09-27 15:43 ` Miguel Ojeda
2022-09-27 13:14 ` [PATCH v10 13/27] rust: export generated symbols Miguel Ojeda
2022-09-27 15:32 ` Greg Kroah-Hartman
2022-09-27 13:14 ` [PATCH v10 14/27] vsprintf: add new `%pA` format specifier Miguel Ojeda
2022-09-27 15:00 ` Greg Kroah-Hartman
2022-09-28 10:09 ` Sergey Senozhatsky
2022-09-27 13:14 ` [PATCH v10 15/27] scripts: checkpatch: diagnose uses of `%pA` in the C side as errors Miguel Ojeda
2022-09-27 15:03 ` Greg Kroah-Hartman
2022-09-27 13:14 ` [PATCH v10 16/27] scripts: checkpatch: enable language-independent checks for Rust Miguel Ojeda
2022-09-27 15:02 ` Greg Kroah-Hartman
2022-09-27 13:14 ` [PATCH v10 17/27] scripts: decode_stacktrace: demangle Rust symbols Miguel Ojeda
2022-09-27 15:02 ` Greg Kroah-Hartman
2022-09-27 13:14 ` [PATCH v10 18/27] scripts: add `generate_rust_analyzer.py` Miguel Ojeda
2022-09-27 13:14 ` [PATCH v10 19/27] scripts: add `generate_rust_target.rs` Miguel Ojeda
2022-09-27 13:14 ` [PATCH v10 20/27] scripts: add `rust_is_available.sh` Miguel Ojeda
2022-09-28 14:49 ` Wei Liu
2022-09-27 13:14 ` [PATCH v10 21/27] scripts: add `is_rust_module.sh` Miguel Ojeda
2022-09-27 15:26 ` Greg Kroah-Hartman
2022-09-27 13:14 ` [PATCH v10 22/27] rust: add `.rustfmt.toml` Miguel Ojeda
2022-09-28 13:30 ` Wei Liu
2022-09-27 13:14 ` [PATCH v10 23/27] Kbuild: add Rust support Miguel Ojeda
2022-09-27 15:30 ` Greg Kroah-Hartman
2022-09-28 14:56 ` Wei Liu
2022-09-27 13:14 ` [PATCH v10 24/27] docs: add Rust documentation Miguel Ojeda
2022-09-27 13:14 ` [PATCH v10 25/27] x86: enable initial Rust support Miguel Ojeda
2022-09-27 15:31 ` Greg Kroah-Hartman
2022-09-28 14:32 ` Wei Liu
2022-09-28 16:39 ` Miguel Ojeda
2022-10-07 17:17 ` Peter Zijlstra
2022-10-10 23:15 ` Sami Tolvanen
2022-10-11 8:04 ` Peter Zijlstra
2022-10-14 17:23 ` Miguel Ojeda
2022-10-14 17:25 ` Boqun Feng
2022-10-14 18:05 ` Miguel Ojeda
2022-10-14 18:34 ` Sami Tolvanen
2022-10-14 20:39 ` Miguel Ojeda
2023-10-09 16:00 ` Matthew Maurer
2023-10-09 16:31 ` Miguel Ojeda
2023-10-09 17:37 ` Greg Kroah-Hartman
2023-10-12 10:47 ` Peter Zijlstra
2023-10-12 17:50 ` Sami Tolvanen
2023-10-12 18:31 ` Kees Cook
2023-10-12 22:26 ` Ramon de C Valle
[not found] ` <CAOcBZOTed1a1yOimdUN9yuuysZ1h6VXa57+5fLAE99SZxCwBMQ@mail.gmail.com>
2023-10-13 7:50 ` Peter Zijlstra
2023-10-13 12:17 ` Ramon de C Valle
2023-10-13 18:54 ` Linus Torvalds
2023-10-13 19:00 ` H. Peter Anvin
2023-10-13 19:22 ` Linus Torvalds
2023-10-14 20:25 ` comex
2023-10-14 20:50 ` H. Peter Anvin
2022-09-27 13:14 ` [PATCH v10 26/27] samples: add first Rust examples Miguel Ojeda
2022-09-27 15:25 ` Greg Kroah-Hartman
2022-09-28 14:23 ` Wei Liu
2022-09-27 13:14 ` [PATCH v10 27/27] MAINTAINERS: Rust Miguel Ojeda
2022-09-27 14:11 ` Geert Stappers
2022-09-27 15:19 ` Kees Cook
2022-09-27 15:34 ` Greg Kroah-Hartman
2022-09-27 15:53 ` Miguel Ojeda
2022-09-27 16:39 ` Greg Kroah-Hartman
2022-09-27 18:14 ` Kees Cook
2022-09-28 0:11 ` Kees Cook
2022-09-28 11:57 ` Wedson Almeida Filho
2022-09-28 12:22 ` Miguel Ojeda
2022-09-27 16:00 ` Wedson Almeida Filho
2022-09-27 16:38 ` Greg Kroah-Hartman
2022-09-28 15:06 ` [PATCH v10 00/27] Rust support Wei Liu
2022-09-28 15:34 ` Miguel Ojeda
2022-09-28 15:40 ` Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YzMOt2wSugmHzQD1@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=boqun.feng@gmail.com \
--cc=jarkko@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ojeda@kernel.org \
--cc=patches@lists.linux.dev \
--cc=rust-for-linux@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).