From: Yu Zhao <yuzhao@google.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: "Andi Kleen" <ak@linux.intel.com>,
"Aneesh Kumar" <aneesh.kumar@linux.ibm.com>,
"Catalin Marinas" <catalin.marinas@arm.com>,
"Dave Hansen" <dave.hansen@linux.intel.com>,
"Hillf Danton" <hdanton@sina.com>, "Jens Axboe" <axboe@kernel.dk>,
"Johannes Weiner" <hannes@cmpxchg.org>,
"Jonathan Corbet" <corbet@lwn.net>,
"Linus Torvalds" <torvalds@linux-foundation.org>,
"Matthew Wilcox" <willy@infradead.org>,
"Mel Gorman" <mgorman@suse.de>,
"Michael Larabel" <Michael@michaellarabel.com>,
"Michal Hocko" <mhocko@kernel.org>,
"Mike Rapoport" <rppt@kernel.org>,
"Peter Zijlstra" <peterz@infradead.org>,
"Tejun Heo" <tj@kernel.org>, "Vlastimil Babka" <vbabka@suse.cz>,
"Will Deacon" <will@kernel.org>,
linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org,
page-reclaim@google.com, "Brian Geffon" <bgeffon@google.com>,
"Jan Alexander Steffens" <heftig@archlinux.org>,
"Oleksandr Natalenko" <oleksandr@natalenko.name>,
"Steven Barrett" <steven@liquorix.net>,
"Suleiman Souhlal" <suleiman@google.com>,
"Daniel Byrne" <djbyrne@mtu.edu>,
"Donald Carr" <d@chaos-reins.com>,
"Holger Hoffstätte" <holger@applied-asynchrony.com>,
"Konstantin Kharlamov" <Hi-Angel@yandex.ru>,
"Shuang Zhai" <szhai2@cs.rochester.edu>,
"Sofia Trinh" <sofia.trinh@edi.works>,
"Vaibhav Jain" <vaibhav@linux.ibm.com>
Subject: Re: [PATCH mm-unstable v15 08/14] mm: multi-gen LRU: support page table walks
Date: Wed, 28 Sep 2022 13:36:58 -0600 [thread overview]
Message-ID: <YzSiWq9UEER5LKup@google.com> (raw)
In-Reply-To: <20220918080010.2920238-9-yuzhao@google.com>
Hi Andrew,
Can you please take another fixlet? Thanks.
Don't sync disk for each aging cycle.
wakeup_flusher_threads() was added under the assumption that if a
system runs out of clean cold pages, it might want to write back dirty
pages more aggressively so that they can become clean and be dropped.
However, doing so can breach the rate limit a system wants to impose
on writeback, resulting in early SSD wearout.
Reported-by: Axel Rasmussen <axelrasmussen@google.com>
Signed-off-by: Yu Zhao <yuzhao@google.com>
---
mm/vmscan.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/mm/vmscan.c b/mm/vmscan.c
index 5b565470286b..0317d4cf4884 100644
--- a/mm/vmscan.c
+++ b/mm/vmscan.c
@@ -4413,8 +4413,6 @@ static bool try_to_inc_max_seq(struct lruvec *lruvec, unsigned long max_seq,
if (wq_has_sleeper(&lruvec->mm_state.wait))
wake_up_all(&lruvec->mm_state.wait);
- wakeup_flusher_threads(WB_REASON_VMSCAN);
-
return true;
}
--
2.37.3.998.g577e59143f-goog
next prev parent reply other threads:[~2022-09-28 19:37 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-18 7:59 [PATCH mm-unstable v15 00/14] Multi-Gen LRU Framework Yu Zhao
2022-09-18 7:59 ` [PATCH mm-unstable v15 01/14] mm: x86, arm64: add arch_has_hw_pte_young() Yu Zhao
2022-09-18 7:59 ` [PATCH mm-unstable v15 02/14] mm: x86: add CONFIG_ARCH_HAS_NONLEAF_PMD_YOUNG Yu Zhao
2022-09-18 8:00 ` [PATCH mm-unstable v15 03/14] mm/vmscan.c: refactor shrink_node() Yu Zhao
2022-09-18 8:00 ` [PATCH mm-unstable v15 04/14] Revert "include/linux/mm_inline.h: fold __update_lru_size() into its sole caller" Yu Zhao
2022-09-18 8:00 ` [PATCH mm-unstable v15 05/14] mm: multi-gen LRU: groundwork Yu Zhao
2022-09-18 8:00 ` [PATCH mm-unstable v15 06/14] mm: multi-gen LRU: minimal implementation Yu Zhao
2022-09-18 8:00 ` [PATCH mm-unstable v15 07/14] mm: multi-gen LRU: exploit locality in rmap Yu Zhao
2022-09-18 8:00 ` [PATCH mm-unstable v15 08/14] mm: multi-gen LRU: support page table walks Yu Zhao
2022-09-18 8:17 ` Yu Zhao
2022-09-28 19:36 ` Yu Zhao [this message]
2022-09-18 8:00 ` [PATCH mm-unstable v15 09/14] mm: multi-gen LRU: optimize multiple memcgs Yu Zhao
2022-09-28 18:46 ` Yu Zhao
2022-09-18 8:00 ` [PATCH mm-unstable v15 10/14] mm: multi-gen LRU: kill switch Yu Zhao
2022-09-18 8:00 ` [PATCH mm-unstable v15 11/14] mm: multi-gen LRU: thrashing prevention Yu Zhao
2022-09-18 8:00 ` [PATCH mm-unstable v15 12/14] mm: multi-gen LRU: debugfs interface Yu Zhao
2022-09-18 8:00 ` [PATCH mm-unstable v15 13/14] mm: multi-gen LRU: admin guide Yu Zhao
2022-09-18 8:26 ` Mike Rapoport
2022-09-18 8:00 ` [PATCH mm-unstable v15 14/14] mm: multi-gen LRU: design doc Yu Zhao
2022-09-19 2:08 ` [PATCH mm-unstable v15 00/14] Multi-Gen LRU Framework Bagas Sanjaya
2022-09-19 5:19 ` Andrew Morton
2022-09-19 7:37 ` Bagas Sanjaya
2022-09-19 7:46 ` Yu Zhao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YzSiWq9UEER5LKup@google.com \
--to=yuzhao@google.com \
--cc=Hi-Angel@yandex.ru \
--cc=Michael@michaellarabel.com \
--cc=ak@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=aneesh.kumar@linux.ibm.com \
--cc=axboe@kernel.dk \
--cc=bgeffon@google.com \
--cc=catalin.marinas@arm.com \
--cc=corbet@lwn.net \
--cc=d@chaos-reins.com \
--cc=dave.hansen@linux.intel.com \
--cc=djbyrne@mtu.edu \
--cc=hannes@cmpxchg.org \
--cc=hdanton@sina.com \
--cc=heftig@archlinux.org \
--cc=holger@applied-asynchrony.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=mhocko@kernel.org \
--cc=oleksandr@natalenko.name \
--cc=page-reclaim@google.com \
--cc=peterz@infradead.org \
--cc=rppt@kernel.org \
--cc=sofia.trinh@edi.works \
--cc=steven@liquorix.net \
--cc=suleiman@google.com \
--cc=szhai2@cs.rochester.edu \
--cc=tj@kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=vaibhav@linux.ibm.com \
--cc=vbabka@suse.cz \
--cc=will@kernel.org \
--cc=willy@infradead.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).