From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 40B55C433F5 for ; Fri, 30 Sep 2022 11:55:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229628AbiI3Lzd (ORCPT ); Fri, 30 Sep 2022 07:55:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42500 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229547AbiI3Lz3 (ORCPT ); Fri, 30 Sep 2022 07:55:29 -0400 Received: from mail.skyhub.de (mail.skyhub.de [5.9.137.197]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 48327F536F for ; Fri, 30 Sep 2022 04:55:27 -0700 (PDT) Received: from zn.tnic (p200300ea9733e70a329c23fffea6a903.dip0.t-ipconnect.de [IPv6:2003:ea:9733:e70a:329c:23ff:fea6:a903]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 8EAC51EC04DA; Fri, 30 Sep 2022 13:55:21 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1664538921; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=gkGioLVwMetICdzznJX5cuKeLXApeRahk/YbtSiNyOU=; b=aA9q7N+ze4YFGknkpfR9jdXxBnhAVBgLCb23/0jyqrX4Kv2W199DybFAnMSyRcyvZHrvvc iot1HFSDMFiYy9cire3ECf+VUH+/aLETNsDlelNvoo00IpP3IlN+hVYO67aaAbRmog1xm0 x2D1aAtd3QHeyXZIVJHvAZbQ7tXox+c= Date: Fri, 30 Sep 2022 13:55:16 +0200 From: Borislav Petkov To: Juergen Gross Cc: xen-devel@lists.xenproject.org, x86@kernel.org, linux-kernel@vger.kernel.org, Thomas Gleixner , Ingo Molnar , Dave Hansen , "H. Peter Anvin" Subject: Re: [PATCH v3 08/10] x86/mtrr: let cache_aps_delayed_init replace mtrr_aps_delayed_init Message-ID: References: <73d8fabd-8b93-2e65-da4b-ea509818e666@suse.com> <24088a15-50a1-f818-8c3e-6010925bffbf@suse.com> <6d37c273-423c-fdce-c140-e5b90d723b9e@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 29, 2022 at 10:26:59AM +0200, Juergen Gross wrote: > So right now I'm inclined to be better on the safe side by not adding any > cpu hotplug hook, but to use just the same "delayed AP init" flag as today, > just renaming it. This would leave the delayed MTRR/PAT init in place for > resume and kexec cases, but deferring the MTRR/PAT cleanup due to this > potential issue seems not appropriate, as the cleanup isn't changing the > behavior here. Ok, what's wrong with adding a special hotplug level just for that thing and running it very early? Practically pretty much where it was in time, in identify_secondary_cpu()? Having a special one is warranted, as you explain, I'd say. Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette