From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Elliot Berman <quic_eberman@quicinc.com>
Cc: Bjorn Andersson <quic_bjorande@quicinc.com>,
Murali Nalajala <quic_mnalajal@quicinc.com>,
Trilok Soni <quic_tsoni@quicinc.com>,
Srivatsa Vaddagiri <quic_svaddagi@quicinc.com>,
Carl van Schaik <quic_cvanscha@quicinc.com>,
Andy Gross <agross@kernel.org>,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
Jassi Brar <jassisinghbrar@gmail.com>,
linux-arm-kernel@lists.infradead.org,
Mark Rutland <mark.rutland@arm.com>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Sudeep Holla <sudeep.holla@arm.com>,
Marc Zyngier <maz@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Jonathan Corbet <corbet@lwn.net>, Will Deacon <will@kernel.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Arnd Bergmann <arnd@arndb.de>,
devicetree@vger.kernel.org, linux-doc@vger.kernel.org,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 13/14] gunyah: rsc_mgr: Add auxiliary devices for console
Date: Fri, 30 Sep 2022 14:19:11 +0200 [thread overview]
Message-ID: <Yzbev2mZodsZhFY3@kroah.com> (raw)
In-Reply-To: <20220928195633.2348848-14-quic_eberman@quicinc.com>
On Wed, Sep 28, 2022 at 12:56:32PM -0700, Elliot Berman wrote:
> Gunyah resource manager exposes a concrete functionalities which
> complicate a single resource manager driver.
I am sorry, but I do not understand this sentance. What is so
complicated about individual devices being created? Where are they
created? What bus?
Use auxiliary bus
> to help split high level functions for the resource manager and keep the
> primary resource manager driver focused on the RPC with RM itself.
> Delegate Resource Manager's console functionality to the auxiliary bus.
>
> Signed-off-by: Elliot Berman <quic_eberman@quicinc.com>
> ---
> drivers/virt/gunyah/Kconfig | 1 +
> drivers/virt/gunyah/rsc_mgr.c | 21 +++++++++++++++++++++
> 2 files changed, 22 insertions(+)
>
> diff --git a/drivers/virt/gunyah/Kconfig b/drivers/virt/gunyah/Kconfig
> index 78deed3c4562..610c8586005b 100644
> --- a/drivers/virt/gunyah/Kconfig
> +++ b/drivers/virt/gunyah/Kconfig
> @@ -17,6 +17,7 @@ config GUNYAH_RESORUCE_MANAGER
> tristate "Gunyah Resource Manager"
> select MAILBOX
> select GUNYAH_MESSAGE_QUEUES
> + select AUXILIARY_BUS
> default y
> help
> The resource manager (RM) is a privileged application VM supporting
> diff --git a/drivers/virt/gunyah/rsc_mgr.c b/drivers/virt/gunyah/rsc_mgr.c
> index 7f7e89a6436b..435fe0149915 100644
> --- a/drivers/virt/gunyah/rsc_mgr.c
> +++ b/drivers/virt/gunyah/rsc_mgr.c
> @@ -16,6 +16,7 @@
> #include <linux/notifier.h>
> #include <linux/workqueue.h>
> #include <linux/completion.h>
> +#include <linux/auxiliary_bus.h>
> #include <linux/gunyah_rsc_mgr.h>
> #include <linux/platform_device.h>
>
> @@ -98,6 +99,8 @@ struct gh_rsc_mgr {
> struct mutex send_lock;
>
> struct work_struct recv_work;
> +
> + struct auxiliary_device console_adev;
> };
>
> static struct gh_rsc_mgr *__rsc_mgr;
> @@ -573,13 +576,31 @@ static int gh_rm_drv_probe(struct platform_device *pdev)
>
> __rsc_mgr = rsc_mgr;
>
> + rsc_mgr->console_adev.dev.parent = &pdev->dev;
> + rsc_mgr->console_adev.name = "console";
> + ret = auxiliary_device_init(&rsc_mgr->console_adev);
> + if (ret)
> + goto err_msgq;
> + ret = auxiliary_device_add(&rsc_mgr->console_adev);
> + if (ret)
> + goto err_console_adev_uninit;
> +
> return 0;
> +
> +err_console_adev_uninit:
> + auxiliary_device_uninit(&rsc_mgr->console_adev);
> +err_msgq:
> + gunyah_msgq_remove(&rsc_mgr->msgq);
> + return ret;
> }
Why can't you just have individual platform devices for the individual
devices your hypervisor exposes?
You control the platform devices, why force them to be shared like this?
thanks,
greg k-h
next prev parent reply other threads:[~2022-09-30 12:19 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-28 19:56 [PATCH v4 00/14] Drivers for gunyah hypervisor Elliot Berman
2022-09-28 19:56 ` [PATCH v4 01/14] docs: gunyah: Introduce Gunyah Hypervisor Elliot Berman
2022-09-29 3:43 ` Bagas Sanjaya
2022-09-29 4:02 ` Elliot Berman
2022-09-28 19:56 ` [PATCH v4 02/14] dt-bindings: Add binding for gunyah hypervisor Elliot Berman
2022-09-28 19:56 ` [PATCH v4 03/14] gunyah: Common types and error codes for Gunyah hypercalls Elliot Berman
2022-09-28 19:56 ` [PATCH v4 04/14] arm64: smccc: Include alternative-macros.h Elliot Berman
2022-09-28 19:56 ` [PATCH v4 05/14] virt: gunyah: Add hypercalls to identify Gunyah Elliot Berman
2022-09-28 19:56 ` [PATCH v4 06/14] virt: gunyah: Add sysfs nodes Elliot Berman
2022-09-30 12:09 ` Greg Kroah-Hartman
2022-10-04 23:50 ` Elliot Berman
2022-10-05 6:23 ` Greg Kroah-Hartman
2022-09-28 19:56 ` [PATCH v4 07/14] mailbox: Allow direct registration to a channel Elliot Berman
2022-09-28 19:56 ` [PATCH v4 08/14] virt: gunyah: msgq: Add hypercalls to send and receive messages Elliot Berman
2022-09-28 19:56 ` [PATCH v4 09/14] mailbox: Add Gunyah message queue mailbox Elliot Berman
2022-09-29 16:59 ` Bjorn Andersson
2022-09-29 17:37 ` Jassi Brar
2022-09-28 19:56 ` [PATCH v4 10/14] gunyah: sysfs: Add node to describe supported features Elliot Berman
2022-09-29 7:36 ` Joe Perches
2022-09-29 20:47 ` Elliot Berman
2022-10-02 23:30 ` Jeff Johnson
2022-10-02 23:58 ` Joe Perches
2022-09-30 12:06 ` Greg Kroah-Hartman
2022-10-04 23:53 ` Elliot Berman
2022-09-28 19:56 ` [PATCH v4 11/14] gunyah: rsc_mgr: Add resource manager RPC core Elliot Berman
2022-09-28 19:56 ` [PATCH v4 12/14] gunyah: rsc_mgr: Add RPC for console services Elliot Berman
2022-09-30 12:22 ` Greg Kroah-Hartman
2022-10-03 1:46 ` new checkpatch flexible array test ? (was Re: [PATCH v4 12/14] gunyah: rsc_mgr: Add RPC for console services) Joe Perches
2022-10-03 5:29 ` Greg Kroah-Hartman
2022-10-03 5:38 ` Joe Perches
2022-10-31 18:23 ` Gustavo A. R. Silva
2022-09-28 19:56 ` [PATCH v4 13/14] gunyah: rsc_mgr: Add auxiliary devices for console Elliot Berman
2022-09-30 12:19 ` Greg Kroah-Hartman [this message]
2022-10-04 23:49 ` Elliot Berman
2022-10-05 6:21 ` Greg Kroah-Hartman
2022-10-05 21:47 ` Elliot Berman
2022-10-06 6:28 ` Greg Kroah-Hartman
2022-09-28 19:56 ` [PATCH v4 14/14] tty: gunyah: Add tty console driver for RM Console Services Elliot Berman
2022-09-30 12:17 ` Greg Kroah-Hartman
2022-10-07 5:59 ` Elliot Berman
2022-10-07 7:40 ` Greg Kroah-Hartman
2022-10-09 20:59 ` Elliot Berman
2022-10-10 20:23 ` Greg Kroah-Hartman
2022-10-10 20:58 ` Elliot Berman
2022-10-11 6:22 ` Greg Kroah-Hartman
2022-10-11 22:04 ` Elliot Berman
2022-10-12 6:53 ` Greg Kroah-Hartman
2022-10-08 7:41 ` Zhou Furong
2022-10-08 9:52 ` Greg Kroah-Hartman
2022-10-03 7:01 ` Jiri Slaby
2022-10-10 18:06 ` Elliot Berman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yzbev2mZodsZhFY3@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=agross@kernel.org \
--cc=arnd@arndb.de \
--cc=catalin.marinas@arm.com \
--cc=corbet@lwn.net \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=jassisinghbrar@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=mark.rutland@arm.com \
--cc=maz@kernel.org \
--cc=quic_bjorande@quicinc.com \
--cc=quic_cvanscha@quicinc.com \
--cc=quic_eberman@quicinc.com \
--cc=quic_mnalajal@quicinc.com \
--cc=quic_svaddagi@quicinc.com \
--cc=quic_tsoni@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=sudeep.holla@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).