From: Luis Chamberlain <mcgrof@kernel.org>
To: Christophe Leroy <christophe.leroy@csgroup.eu>
Cc: Rasmus Villemoes <linux@rasmusvillemoes.dk>,
"linux-modules@vger.kernel.org" <linux-modules@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] module: remove redundant module_sysfs_initialized variable
Date: Tue, 4 Oct 2022 09:31:21 -0700 [thread overview]
Message-ID: <Yzxf2VlLaknhRdic@bombadil.infradead.org> (raw)
In-Reply-To: <4f4a62a2-4395-420f-0a20-e84c06b8c3ed@csgroup.eu>
On Tue, Oct 04, 2022 at 04:35:43AM +0000, Christophe Leroy wrote:
>
>
> Le 04/10/2022 à 01:40, Luis Chamberlain a écrit :
> > On Thu, Sep 29, 2022 at 02:10:39PM +0200, Rasmus Villemoes wrote:
> >> The variable module_sysfs_initialized is used for checking whether
> >> module_kset has been initialized. Checking module_kset itself works
> >> just fine for that.
> >>
> >> Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
> >
> > Looks pretty sane to me, thanks! I'll queue this up for 6.2
> > as we didn't get a chance to spin test this for 6.1 on linux-next.
> >
>
> Maybe you can mention that this is a leftover from commit 7405c1e15edf
> ("kset: convert /sys/module to use kset_create")
Sure, did that.
Luis
prev parent reply other threads:[~2022-10-04 16:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-29 12:10 [PATCH] module: remove redundant module_sysfs_initialized variable Rasmus Villemoes
2022-09-30 11:20 ` Miroslav Benes
2022-10-03 23:40 ` Luis Chamberlain
2022-10-04 4:35 ` Christophe Leroy
2022-10-04 16:31 ` Luis Chamberlain [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yzxf2VlLaknhRdic@bombadil.infradead.org \
--to=mcgrof@kernel.org \
--cc=christophe.leroy@csgroup.eu \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-modules@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).