From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70FF5C6FA99 for ; Sun, 12 Mar 2023 06:52:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229562AbjCLGw0 (ORCPT ); Sun, 12 Mar 2023 01:52:26 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34228 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229437AbjCLGwZ (ORCPT ); Sun, 12 Mar 2023 01:52:25 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3D48053D93; Sat, 11 Mar 2023 22:52:24 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id CA49560A3B; Sun, 12 Mar 2023 06:52:23 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D4737C4339B; Sun, 12 Mar 2023 06:52:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1678603943; bh=k1TxaSwAKQxw+AsnSrIWcYO5UwHIt/wD7Uhbv8/IEBQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=X9PGZbINCnq78MvyRU+lzUqOggKKd95Xwxsu6J0k/XffQLe4KloXsZ5WYD/cttZjS T4ED7ahjSFnM6dKzUJ63KtELMs5ptoTdnuLMzlwR7RANhFlyyyxXcm/eMCsl7PGM6u sF6xm1qUueUCVoH+agbEghvjW1uRxvANFEg4Zt4w= Date: Sun, 12 Mar 2023 07:52:20 +0100 From: Greg Kroah-Hartman To: Yaroslav Furman Cc: Alan Stern , linux-usb@vger.kernel.org, usb-storage@lists.one-eyed-alien.net, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] uas: Add US_FL_NO_REPORT_OPCODES for JMicron JMS583Gen 2 Message-ID: References: <7f670cac-aa36-4bb9-a2b1-4451e4e85fab@rowland.harvard.edu> <20230311171226.20353-1-yaro330@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230311171226.20353-1-yaro330@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Mar 11, 2023 at 07:12:26PM +0200, Yaroslav Furman wrote: > Just like other JMicron JMS5xx enclosures, it chokes on report-opcodes, > let's avoid them. > > Signed-off-by: Yaroslav Furman > --- > drivers/usb/storage/unusual_uas.h | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/drivers/usb/storage/unusual_uas.h b/drivers/usb/storage/unusual_uas.h > index c7b763d6d102..1f8c9b16a0fb 100644 > --- a/drivers/usb/storage/unusual_uas.h > +++ b/drivers/usb/storage/unusual_uas.h > @@ -111,6 +111,13 @@ UNUSUAL_DEV(0x152d, 0x0578, 0x0000, 0x9999, > USB_SC_DEVICE, USB_PR_DEVICE, NULL, > US_FL_BROKEN_FUA), > > +/* Reported by: Yaroslav Furman */ > +UNUSUAL_DEV(0x152d, 0x0583, 0x0000, 0x9999, > + "JMicron", > + "JMS583Gen 2", > + USB_SC_DEVICE, USB_PR_DEVICE, NULL, > + US_FL_NO_REPORT_OPCODES), > + > /* Reported-by: Thinh Nguyen */ > UNUSUAL_DEV(0x154b, 0xf00b, 0x0000, 0x9999, > "PNY", > -- > 2.39.2 > Hi, This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response. He used to manually respond to these common problems, but in order to save his sanity (he kept writing the same thing over and over, yet to different people), I was created. Hopefully you will not take offence and will fix the problem in your patch and resubmit it so that it can be accepted into the Linux kernel tree. You are receiving this message because of the following common error(s) as indicated below: - This looks like a new version of a previously submitted patch, but you did not list below the --- line any changes from the previous version. Please read the section entitled "The canonical patch format" in the kernel file, Documentation/process/submitting-patches.rst for what needs to be done here to properly describe this. If you wish to discuss this problem further, or you have questions about how to resolve this issue, please feel free to respond to this email and Greg will reply once he has dug out from the pending patches received from other developers. thanks, greg k-h's patch email bot