From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F2C87C61DA4 for ; Sat, 11 Mar 2023 17:31:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229821AbjCKRbq (ORCPT ); Sat, 11 Mar 2023 12:31:46 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55036 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229958AbjCKRbl (ORCPT ); Sat, 11 Mar 2023 12:31:41 -0500 Received: from mail-wm1-x329.google.com (mail-wm1-x329.google.com [IPv6:2a00:1450:4864:20::329]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 867C4637FC for ; Sat, 11 Mar 2023 09:31:38 -0800 (PST) Received: by mail-wm1-x329.google.com with SMTP id k37so5389982wms.0 for ; Sat, 11 Mar 2023 09:31:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1678555896; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=eZIJBRNDRL8HZvT697SFUbM2Eibrf8gkSu7pHfkfmkE=; b=B7DKn1liTn6wJaaCvi/8wFSDUGKfv+hzlvsKEHKGodQa8NRAohVRRe0cWaafeqAjzv xyUPMCBCpOKPdFndoKneWamVeY7UxTtHs4m4uKkzMagBf/NjzW0HpXf9TIBv95QAMRkM d2hMRGo5Co0Pjv2rUll7h010nb0EyuUPxohM5G2sPxhrjaOdp07+aTNVE8CYqquLmU6f jzthzbcPhhlWIycQ3/uKOG5C0Qlyzs4Ut/24+9vu2uDJDC7DBocfOsb5xcz9+1F834Ea ghZ1Oae18NNTXLxJdHFzp7XgrphSbKuWT9TcgmxXxd+X67/po2TxjxfJhFejW90JAwaJ v0Jw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678555896; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=eZIJBRNDRL8HZvT697SFUbM2Eibrf8gkSu7pHfkfmkE=; b=OryqvTWbcogu2P4Zl/5eKD0MLATyLZ56L3ITwBD2STQ7Z+lifousTfn7LLKe6xBaWD 2xZ2cTdIdZRYb2Iwcd3kpy5ANvYapFMZktG46OY0iSynXLLB7bs6pFZ4a9ejbFJCyVJi vPKZP4nlDLEnzRdtdmMO0Lp2v9pUoJUZY2Bp074I9maIcr7a6Q0gNYGuSrxne7oeI5uQ 4hZ5NPe6aBE4u9jyPUkDxiHiZNGHf1MqJR6/Ds7SxK4P4Q6kEeTGHPwVpRjmj09W9NKC gvtuBnfPZaKMyKfW5/VuyS6XT8uQRwGULY8aK5AIDBQNA5DcBmFyCi7zq9EseH0f8qsA t//w== X-Gm-Message-State: AO0yUKU0tuV1zWihDRemBCZ2Tt3eDAUxlULWL7hw1krnLzkQMSIBxz9b kbgW2xPGYg5DHPcelH/Hhkj8zooRQSMzrS/e X-Google-Smtp-Source: AK7set8AEI4G00E78uxadPBqecqF59b6nejd6JlyaM6SA9R+1ru2UD7dyei97ETUVkpvdYKDarT3xg== X-Received: by 2002:a05:600c:538b:b0:3eb:2b88:5af2 with SMTP id hg11-20020a05600c538b00b003eb2b885af2mr6180515wmb.20.1678555896582; Sat, 11 Mar 2023 09:31:36 -0800 (PST) Received: from khadija-virtual-machine ([39.41.45.115]) by smtp.gmail.com with ESMTPSA id 4-20020a05600c024400b003e91b9a92c9sm3386837wmj.24.2023.03.11.09.31.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 11 Mar 2023 09:31:36 -0800 (PST) Date: Sat, 11 Mar 2023 22:31:33 +0500 From: Khadija Kamran To: Greg Kroah-Hartman Cc: outreachy@lists.linux.dev, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3] staging: axis-fifo: remove tabs to align arguments Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Mar 11, 2023 at 01:26:38PM +0100, Greg Kroah-Hartman wrote: > On Sat, Mar 11, 2023 at 04:58:01PM +0500, Khadija Kamran wrote: > > In file drivers/staging/axis-fifo/axis-fifo.c, in line 386 and 529, the > > last argument is indented as if it were an argument of the second > > argument. Remove tabs to align the arguments. > > > > Signed-off-by: Khadija Kamran > > --- > > Changes in v3: > > - Do not align the line 530 since it is not part of the last argument. > > > > drivers/staging/axis-fifo/axis-fifo.c | 12 ++++++------ > > 1 file changed, 6 insertions(+), 6 deletions(-) > > > > diff --git a/drivers/staging/axis-fifo/axis-fifo.c b/drivers/staging/axis-fifo/axis-fifo.c > > index dfd2b357f484..b119cec25a60 100644 > > --- a/drivers/staging/axis-fifo/axis-fifo.c > > +++ b/drivers/staging/axis-fifo/axis-fifo.c > > @@ -384,9 +384,9 @@ static ssize_t axis_fifo_read(struct file *f, char __user *buf, > > mutex_lock(&fifo->read_lock); > > ret = wait_event_interruptible_timeout(fifo->read_queue, > > ioread32(fifo->base_addr + XLLF_RDFO_OFFSET), > > - (read_timeout >= 0) ? > > - msecs_to_jiffies(read_timeout) : > > - MAX_SCHEDULE_TIMEOUT); > > + (read_timeout >= 0) ? > > + msecs_to_jiffies(read_timeout) : > > + MAX_SCHEDULE_TIMEOUT); > > People have been trying to "polish" this mess for a long time, and I > think it's better to step back and see what is really needed here. > > There is a module parameter, read_timeout, that can only be set at > loading time. As it can only be modified once, why are we doing an if > statement each and every time it is read from? > > Instead, in the module probe function, how about doing something like: > if (read_timeout >= 0) > read_timeout = msecs_to_jiffies(read_timeout); > else > read_timeout = MAX_SCHEDULE_TIMEOUT; > Hi Greg! Thank you for the reply. Before sending the patch I just wanted to confirm if I have understood this right. Should I write the above mentioned code before the wait_event_interruptible_timeout() call, and pass read_timeout as the last argument to wait_event_interruptible()? And same for write_timeout. > and then only ever use "read_timeout" here in the > wait_event_interruptiable() call? That should simplify this much more > overall, and hopefully allow us to just get rid of the module parameter > eventually as that's not how drivers should be working at all anymore. > > Same goes for write_timeout. > > Overall the code should be much simpler and easier to understand, which > is the end goal here. > > Can you try doing that instead? > > thanks, > > greg k-h