From: Sakari Ailus <sakari.ailus@iki.fi>
To: Francesco Dolcini <francesco@dolcini.it>
Cc: Marcel Ziswiler <marcel@ziswiler.com>,
linux-media@vger.kernel.org,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Philipp Zabel <p.zabel@pengutronix.de>,
kernel@pengutronix.de,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Francesco Dolcini <francesco.dolcini@toradex.com>,
Jacopo Mondi <jacopo.mondi@ideasonboard.com>,
Aishwarya Kothari <aishwarya.kothari@toradex.com>,
Marcel Ziswiler <marcel.ziswiler@toradex.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Steve Longerbeam <slongerbeam@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] media: i2c: ov5640: Implement get_mbus_config
Date: Tue, 14 Mar 2023 14:45:53 +0200 [thread overview]
Message-ID: <ZBBsgW75Gc2FmuQ0@valkosipuli.retiisi.eu> (raw)
In-Reply-To: <ZBBpUAhis8L5Dtuz@francesco-nb.int.toradex.com>
Hi Francesco,
On Tue, Mar 14, 2023 at 01:32:16PM +0100, Francesco Dolcini wrote:
> Hello Sakari,
>
> On Tue, Mar 14, 2023 at 02:13:46PM +0200, Sakari Ailus wrote:
> > On Mon, Mar 06, 2023 at 07:36:49AM +0100, Marcel Ziswiler wrote:
> > > From: Aishwarya Kothari <aishwarya.kothari@toradex.com>
> > >
> > > Implement the introduced get_mbus_config operation to report the
> > > config of the MIPI CSI-2, BT.656 and Parallel interface.
> > >
> > > Signed-off-by: Aishwarya Kothari <aishwarya.kothari@toradex.com>
> > > Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>
> > >
> > > ---
> > >
> > > Changes in v2:
> > > - Take care of MIPI CSI-2, BT.656 and Parallel interface as
> > > pointed out by Jacopo. Thanks!
> > >
> > > drivers/media/i2c/ov5640.c | 19 +++++++++++++++++++
> > > 1 file changed, 19 insertions(+)
> > >
> > > diff --git a/drivers/media/i2c/ov5640.c b/drivers/media/i2c/ov5640.c
> > > index 1536649b9e90..43373416fcba 100644
> > > --- a/drivers/media/i2c/ov5640.c
> > > +++ b/drivers/media/i2c/ov5640.c
> > > @@ -3774,6 +3774,24 @@ static int ov5640_init_cfg(struct v4l2_subdev *sd,
> > > return 0;
> > > }
> > >
> > > +static int ov5640_get_mbus_config(struct v4l2_subdev *sd,
> > > + unsigned int pad,
> > > + struct v4l2_mbus_config *cfg)
> > > +{
> > > + struct ov5640_dev *sensor = to_ov5640_dev(sd);
> > > +
> > > + cfg->type = sensor->ep.bus_type;
> > > + if (ov5640_is_csi2(sensor)) {
> > > + cfg->bus.mipi_csi2.num_data_lanes =
> > > + sensor->ep.bus.mipi_csi2.num_data_lanes;
> > > + cfg->bus.mipi_csi2.flags = sensor->ep.bus.mipi_csi2.flags;
> > > + } else {
> > > + cfg->bus.parallel.flags = sensor->ep.bus.parallel.flags;
> > > + }
> > > +
> > > + return 0;
> > > +}
> > > +
> > > static const struct v4l2_subdev_core_ops ov5640_core_ops = {
> > > .log_status = v4l2_ctrl_subdev_log_status,
> > > .subscribe_event = v4l2_ctrl_subdev_subscribe_event,
> > > @@ -3794,6 +3812,7 @@ static const struct v4l2_subdev_pad_ops ov5640_pad_ops = {
> > > .get_selection = ov5640_get_selection,
> > > .enum_frame_size = ov5640_enum_frame_size,
> > > .enum_frame_interval = ov5640_enum_frame_interval,
> > > + .get_mbus_config = ov5640_get_mbus_config,
> >
> > What's the reasoning for this patch?
>
> Without this it's not possible to use it on i.MX6,
> drivers/staging/media/imx/imx6-mipi-csi2.c requires it, some more
> details from Jacopo here [0].
>
> Everything used to work fine up to v5.18, after that kernel version
> various changes broke it [1][2] (I assume you are pretty much aware of
> the history here, you commented on a few emails).
>
> [0] https://lore.kernel.org/all/20230128100611.7ulsfqqqgscg54gy@uno.localdomain/
> [1] https://lore.kernel.org/all/081cc2d3-1f3a-6c14-6dc7-53f976be7b2b@gmail.com/
> [2] https://lore.kernel.org/all/cacfe146-101b-35b3-5f66-1a1cabfd342f@gmail.com/
>
> > Drivers that don't have e.g. dynamic lane configuration shouldn't need to
> > implement get_mbus_config.
Not even for staging drivers. The driver should be fixed to get that
information from the endpoint instead.
I don't object having a helper in the framework to do this though. There
are many receiver drivers that need this to work with those devices that
have variable number of lanes.
--
Regards,
Sakari Ailus
next prev parent reply other threads:[~2023-03-14 12:52 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-06 6:36 [PATCH v2] media: i2c: ov5640: Implement get_mbus_config Marcel Ziswiler
2023-03-14 12:13 ` Sakari Ailus
2023-03-14 12:32 ` Francesco Dolcini
2023-03-14 12:45 ` Sakari Ailus [this message]
2023-03-14 12:59 ` Francesco Dolcini
2023-03-20 8:48 ` Jacopo Mondi
2023-03-20 9:00 ` Sakari Ailus
2023-03-20 9:26 ` Laurent Pinchart
2023-03-20 9:37 ` Sakari Ailus
2023-03-20 9:55 ` Laurent Pinchart
2023-03-20 10:15 ` Sakari Ailus
2023-03-20 13:32 ` Philipp Zabel
2023-03-20 14:00 ` Laurent Pinchart
2023-03-20 18:31 ` Dave Stevenson
2023-03-20 21:53 ` Laurent Pinchart
2023-03-20 21:53 ` Sakari Ailus
2023-03-20 11:26 ` Philipp Zabel
2023-03-20 12:47 ` Jacopo Mondi
2023-03-20 13:28 ` Philipp Zabel
2023-03-20 11:13 ` Francesco Dolcini
2023-03-22 13:53 ` Aishwarya Kothari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZBBsgW75Gc2FmuQ0@valkosipuli.retiisi.eu \
--to=sakari.ailus@iki.fi \
--cc=aishwarya.kothari@toradex.com \
--cc=francesco.dolcini@toradex.com \
--cc=francesco@dolcini.it \
--cc=jacopo.mondi@ideasonboard.com \
--cc=kernel@pengutronix.de \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=marcel.ziswiler@toradex.com \
--cc=marcel@ziswiler.com \
--cc=mchehab@kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=sakari.ailus@linux.intel.com \
--cc=slongerbeam@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).