From: Matthew Wilcox <willy@infradead.org>
To: Hannes Reinecke <hare@suse.de>
Cc: Pankaj Raghav <p.raghav@samsung.com>,
hubcap@omnibond.com, senozhatsky@chromium.org,
martin@omnibond.com, minchan@kernel.org, viro@zeniv.linux.org.uk,
brauner@kernel.org, axboe@kernel.dk, akpm@linux-foundation.org,
linux-kernel@vger.kernel.org, linux-block@vger.kernel.org,
linux-fsdevel@vger.kernel.org, linux-mm@kvack.org,
gost.dev@samsung.com, mcgrof@kernel.org,
devel@lists.orangefs.org
Subject: Re: [RFC PATCH 2/3] mpage: use bio_for_each_folio_all in mpage_end_io()
Date: Wed, 15 Mar 2023 16:08:46 +0000 [thread overview]
Message-ID: <ZBHtjrk52/TTPU/F@casper.infradead.org> (raw)
In-Reply-To: <64a5e85e-4018-ed7d-29d4-db12af290899@suse.de>
On Wed, Mar 15, 2023 at 03:52:15PM +0100, Hannes Reinecke wrote:
> On 3/15/23 13:32, Pankaj Raghav wrote:
> > Use bio_for_each_folio_all to iterate through folios in a bio so that
> > the folios can be directly passed to the folio_endio() function.
> > + bio_for_each_folio_all(fi, bio)
> > + folio_endio(fi.folio, bio_op(bio),
> > + blk_status_to_errno(bio->bi_status));
> > bio_put(bio);
> > }
>
> Ah. Here it is.
>
> I would suggest merge these two patches.
The right way to have handled this patch series was:
1. Introduce a new folio_endio() [but see Christoph's mail on why we
shouldn't do that]
2-n convert callers to use folios directly
n+1 remove page_endio() entirely.
Note that patch n+1 might not be part of this patch series; sometimes
it takes a while to convert all callers to use folios.
I very much dislike the way this was done by pushing the page_folio()
call into each of the callers because it makes the entire series hard to
review.
next prev parent reply other threads:[~2023-03-15 16:10 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20230315123234eucas1p179bf8c0583a71d91bef7e909d7ec6504@eucas1p1.samsung.com>
2023-03-15 12:32 ` [RFC PATCH 0/3] convert page_endio to folio_endio Pankaj Raghav
[not found] ` <CGME20230315123234eucas1p2503d83ad0180cecde02e924d7b143535@eucas1p2.samsung.com>
2023-03-15 12:32 ` [RFC PATCH 1/3] filemap: " Pankaj Raghav
2023-03-15 14:46 ` Luis Chamberlain
2023-03-15 14:51 ` Hannes Reinecke
2023-03-15 14:56 ` Christoph Hellwig
2023-03-16 10:04 ` Pankaj Raghav
2023-03-16 15:24 ` Christoph Hellwig
2023-03-17 15:31 ` Matthew Wilcox
2023-03-17 16:14 ` Pankaj Raghav
2023-03-21 13:51 ` Pankaj Raghav
[not found] ` <CGME20230315123235eucas1p1bd62cb2aab435727880769f2e57624fd@eucas1p1.samsung.com>
2023-03-15 12:32 ` [RFC PATCH 2/3] mpage: use bio_for_each_folio_all in mpage_end_io() Pankaj Raghav
2023-03-15 14:47 ` Luis Chamberlain
2023-03-15 14:52 ` Hannes Reinecke
2023-03-15 16:08 ` Matthew Wilcox [this message]
2023-03-16 10:07 ` Pankaj Raghav
[not found] ` <CGME20230315123236eucas1p1116e1b8537191310bd03dd267b9f8eb8@eucas1p1.samsung.com>
2023-03-15 12:32 ` [RFC PATCH 3/3] orangefs: use folio in orangefs_readahead() Pankaj Raghav
2023-03-15 14:48 ` Luis Chamberlain
2023-03-15 16:05 ` Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZBHtjrk52/TTPU/F@casper.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=brauner@kernel.org \
--cc=devel@lists.orangefs.org \
--cc=gost.dev@samsung.com \
--cc=hare@suse.de \
--cc=hubcap@omnibond.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=martin@omnibond.com \
--cc=mcgrof@kernel.org \
--cc=minchan@kernel.org \
--cc=p.raghav@samsung.com \
--cc=senozhatsky@chromium.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).