From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Matti Vaittinen <mazziesaccount@gmail.com>
Cc: Mehdi Djait <mehdi.djait.k@gmail.com>,
jic23@kernel.org, krzysztof.kozlowski+dt@linaro.org,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH 2/3] iio: accel: kionix-kx022a: Add chip_info structure
Date: Mon, 20 Mar 2023 14:02:42 +0200 [thread overview]
Message-ID: <ZBhLYvp9JdX3FGhI@smile.fi.intel.com> (raw)
In-Reply-To: <4c28925d-c07c-61b7-8863-9c00e6846687@gmail.com>
On Mon, Mar 20, 2023 at 11:35:06AM +0200, Matti Vaittinen wrote:
> On 3/17/23 01:48, Mehdi Djait wrote:
> > Refactor the kx022a driver implementation to make it more
> > generic and extensible.
> > Add the chip_info structure will to the driver's private
> > data to hold all the device specific infos.
> > Move the enum, struct and constants definitions to the header
> > file.
...
> Something like:
>
> enum {
> KIONIX_IC_KX022A,
> KIONIX_IC_KX132_xxx, /* xxx denotes accurate model suffix */
> };
>
> static const struct of_device_id kx022a_of_match[] = {
> { .compatible = "kionix,kx022a", .data = KIONIX_IC_KX022A },
> ...
>
> chip_id = device_get_match_data(&i2c->dev);
No, please avoid putting plain integers as pointers of driver_data.
The problem you introduced with your suggestion is impossibility
to distinguish 0 and NULL, beyond other not good things (like missing
castings which are ugly).
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-03-20 12:03 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-16 23:48 [PATCH 0/3] iio: accel: Add support for Kionix/ROHM KX132 accelerometer Mehdi Djait
2023-03-16 23:48 ` [PATCH 1/3] dt-bindings: iio: Add " Mehdi Djait
2023-03-19 15:54 ` Jonathan Cameron
2023-03-21 13:22 ` Mehdi Djait
2023-03-16 23:48 ` [PATCH 2/3] iio: accel: kionix-kx022a: Add chip_info structure Mehdi Djait
2023-03-17 1:01 ` kernel test robot
2023-03-17 4:57 ` kernel test robot
2023-03-17 12:06 ` Andy Shevchenko
2023-03-18 16:12 ` Mehdi Djait
2023-03-19 16:20 ` Jonathan Cameron
2023-03-20 7:17 ` Matti Vaittinen
2023-03-20 12:24 ` Jonathan Cameron
2023-03-21 15:39 ` Mehdi Djait
2023-03-20 9:35 ` Matti Vaittinen
2023-03-20 12:02 ` Andy Shevchenko [this message]
2023-03-20 12:34 ` Jonathan Cameron
2023-03-20 12:52 ` Matti Vaittinen
2023-03-21 15:56 ` Mehdi Djait
2023-03-22 6:37 ` Matti Vaittinen
2023-03-21 1:05 ` kernel test robot
2023-03-16 23:48 ` [PATCH 3/3] iio: accel: Add support for Kionix/ROHM KX132 accelerometer Mehdi Djait
2023-03-19 16:22 ` Jonathan Cameron
2023-03-21 16:34 ` Mehdi Djait
2023-03-25 18:12 ` Jonathan Cameron
2023-03-20 9:57 ` Matti Vaittinen
2023-03-17 12:07 ` [PATCH 0/3] " Andy Shevchenko
2023-03-18 15:55 ` Mehdi Djait
2023-03-19 7:43 ` Matti Vaittinen
2023-03-21 13:16 ` Mehdi Djait
2023-03-22 7:47 ` Matti Vaittinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZBhLYvp9JdX3FGhI@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mazziesaccount@gmail.com \
--cc=mehdi.djait.k@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).