From: Johan Hovold <johan@kernel.org>
To: Rob Clark <robdclark@gmail.com>,
Abhinav Kumar <quic_abhinavk@quicinc.com>,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Cc: Sean Paul <sean@poorly.run>, David Airlie <airlied@gmail.com>,
Daniel Vetter <daniel@ffwll.ch>,
Bjorn Andersson <andersson@kernel.org>,
linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org,
freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/4] drm/msm/adreno: fix runtime PM imbalance at unbind
Date: Tue, 21 Mar 2023 13:56:44 +0100 [thread overview]
Message-ID: <ZBmpjF6DKMGDiOhT@hovoldconsulting.com> (raw)
In-Reply-To: <20230303164807.13124-1-johan+linaro@kernel.org>
On Fri, Mar 03, 2023 at 05:48:03PM +0100, Johan Hovold wrote:
> As reported by Bjorn, we can end up with an unbalanced runtime PM
> disable count if unbind() is called before the DRM device is opened
> (e.g. if component bind fails due to the panel driver not having been
> loaded yet).
>
> As runtime PM must currently stay disabled until the firmware has been
> loaded, fix this by making the runtime PM disable call at unbind()
> conditional.
>
> The rest of the series fixes further imbalances in the load_gpu() error
> paths and removes a bogus pm_runtime_set_active() call. Included is also
> a related indentation cleanup.
I noticed that Rob picked up the first patch below from v1 of this
series. Any comments to the remaining three?
Johan
> Changes in v2
> - fix the runtime PM imbalance in the gpu load error paths (new)
>
> - drop the patch removing the pm_runtime_disable() from
> adreno_gpu_cleanup() as this function can currently still be called
> with runtime PM enabled if suspending the scheduler in
> adreno_system_suspend() at unbind fails
>
>
> Johan Hovold (4):
> drm/msm/adreno: fix runtime PM imbalance at unbind
> drm/msm/adreno: fix runtime PM imbalance at gpu load
> drm/msm/adreno: drop bogus pm_runtime_set_active()
> drm/msm/adreno: clean up component ops indentation
>
> drivers/gpu/drm/msm/adreno/adreno_device.c | 26 +++++++++++++---------
> 1 file changed, 16 insertions(+), 10 deletions(-)
prev parent reply other threads:[~2023-03-21 12:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-03 16:48 [PATCH v2 0/4] drm/msm/adreno: fix runtime PM imbalance at unbind Johan Hovold
2023-03-03 16:48 ` [PATCH v2 1/4] " Johan Hovold
2023-03-03 16:48 ` [PATCH v2 2/4] drm/msm/adreno: fix runtime PM imbalance at gpu load Johan Hovold
2023-03-03 16:48 ` [PATCH v2 3/4] drm/msm/adreno: drop bogus pm_runtime_set_active() Johan Hovold
2023-03-03 16:48 ` [PATCH v2 4/4] drm/msm/adreno: clean up component ops indentation Johan Hovold
2023-03-21 12:56 ` Johan Hovold [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZBmpjF6DKMGDiOhT@hovoldconsulting.com \
--to=johan@kernel.org \
--cc=airlied@gmail.com \
--cc=andersson@kernel.org \
--cc=daniel@ffwll.ch \
--cc=dmitry.baryshkov@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_abhinavk@quicinc.com \
--cc=robdclark@gmail.com \
--cc=sean@poorly.run \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).