From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85C31C76195 for ; Tue, 21 Mar 2023 13:13:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230341AbjCUNNT (ORCPT ); Tue, 21 Mar 2023 09:13:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51620 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229783AbjCUNNQ (ORCPT ); Tue, 21 Mar 2023 09:13:16 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 576EAA5E2; Tue, 21 Mar 2023 06:13:15 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 948D5B81670; Tue, 21 Mar 2023 13:13:13 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2D874C433EF; Tue, 21 Mar 2023 13:13:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1679404392; bh=Ie0I6DspmqUGmFzLY8M9p06FQQUjb9WBd6Z2Y5RxFMw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=WCELKUAO4DmRhWUevMaHTsfdWUOjmOwX6QDGRTGx8cr2tDflzYANu1EphfFEiuacN 73IJBFv8dFoFgJspV1c2kimtV/h9RslHEeXTHNU71iV2EBgXhherzoHszVgFNDN0Y+ SQEdUjvv4ttww2/mSl2jf4bmNKcGUD/3FSuCmYCoXHhZK3ojjR3yc8cHxkZ2MdqGDw 6zp/6BorvlCFtxWIlglrzjZLZjn8khx+muMaJjNKTzhW6I/CZ5/1CJX4uQLO80aQO2 T6Wec1E+zo0rJmtBFFf3unDCUrY/YYGRwClwRdqzpnsbNM7/shgpSK1BcTieLe2ZLh 4e8zFbiwUOlmw== Received: from johan by xi.lan with local (Exim 4.94.2) (envelope-from ) id 1pebox-000683-A5; Tue, 21 Mar 2023 14:14:36 +0100 Date: Tue, 21 Mar 2023 14:14:35 +0100 From: Johan Hovold To: Martin Blumenstingl , Neil Armstrong Cc: Johan Hovold , David Airlie , Daniel Vetter , Kevin Hilman , Jerome Brunet , dri-devel@lists.freedesktop.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH] drm/meson: fix missing component unbind on bind errors Message-ID: References: <20230306103533.4915-1-johan+linaro@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 09, 2023 at 10:41:18PM +0100, Martin Blumenstingl wrote: > On Mon, Mar 6, 2023 at 11:35 AM Johan Hovold wrote: > [...] > > @@ -325,23 +325,23 @@ static int meson_drv_bind_master(struct device *dev, bool has_components) > > > > ret = meson_encoder_hdmi_init(priv); > I'm wondering if component_bind_all() can be moved further down. > Right now it's between meson_encoder_cvbs_init() and > meson_encoder_hdmi_init(). So it seems that encoders don't rely on > component registration. Perhaps it can, but that would be a separate change (unless there is something inherently wrong with the current initialisation order). > Unfortunately I am also not familiar with this and I'm hoping that > Neil can comment on this. Any comments on this one, Neil? Johan