From: Luis Chamberlain <mcgrof@kernel.org>
To: Matthew Wilcox <willy@infradead.org>
Cc: Yangtao Li <frank.li@vivo.com>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Christian Brauner <brauner@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Kees Cook <keescook@chromium.org>,
Iurii Zaikin <yzaikin@google.com>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org
Subject: Re: [PATCH] fs/drop_caches: move drop_caches sysctls into its own file
Date: Tue, 21 Mar 2023 11:10:25 -0700 [thread overview]
Message-ID: <ZBnzEY2PLbUtMKqX@bombadil.infradead.org> (raw)
In-Reply-To: <ZBnnFtKVgAFQ4yeo@casper.infradead.org>
On Tue, Mar 21, 2023 at 05:19:18PM +0000, Matthew Wilcox wrote:
> On Tue, Mar 21, 2023 at 09:56:03AM -0700, Luis Chamberlain wrote:
> > On Tue, Mar 21, 2023 at 04:42:32PM +0000, Matthew Wilcox wrote:
> > > On Tue, Mar 21, 2023 at 09:09:07PM +0800, Yangtao Li wrote:
> > > > +static struct ctl_table drop_caches_table[] = {
> > > > + {
> > > > + .procname = "drop_caches",
> > > > + .data = &sysctl_drop_caches,
> > > > + .maxlen = sizeof(int),
> > > > + .mode = 0200,
> > > > + .proc_handler = drop_caches_sysctl_handler,
> > > > + .extra1 = SYSCTL_ONE,
> > > > + .extra2 = SYSCTL_FOUR,
> > > > + },
> > > > + {}
> > > > +};
> > >
> > > Could we avoid doing this until we no longer need an entire zero entry
> > > after the last one?
> >
> > That may be 2-3 kernel release from now. The way to use ARRAY_SIZE()
> > really is to deprecate the crap APIs that allow messy directory sysctl
> > structures.
>
> I'm OK with waiting another year to commence this cleanup. We've lived
> with the giant tables for decades already. Better to get the new API
> right than split the tables now, then have to touch all the places
> again.
We can do that sure.
Luis
next prev parent reply other threads:[~2023-03-21 18:10 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-21 13:09 [PATCH] fs/drop_caches: move drop_caches sysctls into its own file Yangtao Li
2023-03-21 14:28 ` Christian Brauner
2023-03-21 16:39 ` Luis Chamberlain
2023-03-21 17:19 ` Christian Brauner
2023-03-21 16:42 ` Matthew Wilcox
2023-03-21 16:56 ` Luis Chamberlain
2023-03-21 17:19 ` Matthew Wilcox
2023-03-21 18:10 ` Luis Chamberlain [this message]
2023-03-21 14:37 Alexey Dobriyan
2023-03-21 16:42 ` Luis Chamberlain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZBnzEY2PLbUtMKqX@bombadil.infradead.org \
--to=mcgrof@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=brauner@kernel.org \
--cc=frank.li@vivo.com \
--cc=keescook@chromium.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=viro@zeniv.linux.org.uk \
--cc=willy@infradead.org \
--cc=yzaikin@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).