From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42DC0C6FD1C for ; Thu, 23 Mar 2023 12:06:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231272AbjCWMG2 (ORCPT ); Thu, 23 Mar 2023 08:06:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46174 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231761AbjCWMGH (ORCPT ); Thu, 23 Mar 2023 08:06:07 -0400 Received: from jabberwock.ucw.cz (jabberwock.ucw.cz [46.255.230.98]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 950D310E0; Thu, 23 Mar 2023 05:04:55 -0700 (PDT) Received: by jabberwock.ucw.cz (Postfix, from userid 1017) id 4576E1C0E49; Thu, 23 Mar 2023 13:04:54 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ucw.cz; s=gen1; t=1679573094; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=a/KoMv72J5IIz0NM8GNmcSDXPLFS3Vkv0wZ+gg3A9vc=; b=D3RWeS7ZzdCwgmaip0tK7qF1pk+0eq9crqm8wlRLN0VwU4ch5LoLGN9GkYiUKbHStOHQG5 ip72ixYlxxhVXDeZWurv7JvDnzYRhY38H53HaSB392q1stZiSOrW5vqP4OKqBXNebHqlHi jS7wZujiZ36L/6mjm/7tRHZFq4pMD+4= Date: Thu, 23 Mar 2023 13:04:53 +0100 From: Pavel Machek To: Christian Marangi Cc: Andrew Lunn , Florian Fainelli , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Heiner Kallweit , Russell King , Gregory Clement , Sebastian Hesselbarth , Andy Gross , Bjorn Andersson , Konrad Dybcio , Lee Jones , John Crispin , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-leds@vger.kernel.org Subject: Re: [net-next PATCH v5 15/15] arm: mvebu: dt: Add PHY LED support for 370-rd WAN port Message-ID: References: <20230319191814.22067-1-ansuelsmth@gmail.com> <20230319191814.22067-16-ansuelsmth@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="PW0UYIpUfo2k2zdg" Content-Disposition: inline In-Reply-To: <20230319191814.22067-16-ansuelsmth@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --PW0UYIpUfo2k2zdg Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi! > From: Andrew Lunn >=20 > The WAN port of the 370-RD has a Marvell PHY, with one LED on > the front panel. List this LED in the device tree. >=20 > Signed-off-by: Andrew Lunn > Signed-off-by: Christian Marangi > @@ -135,6 +136,19 @@ &mdio { > pinctrl-names =3D "default"; > phy0: ethernet-phy@0 { > reg =3D <0>; > + leds { > + #address-cells =3D <1>; > + #size-cells =3D <0>; > + > + led@0 { > + reg =3D <0>; > + label =3D "WAN"; > + color =3D ; > + function =3D LED_FUNCTION_LAN; > + function-enumerator =3D <1>; > + linux,default-trigger =3D "netdev"; > + }; > + }; > }; > =20 How will this end up looking in sysfs? Should documentation be added to Documentation/leds/leds-blinkm.rst ? BR, Pavel --=20 People of Russia, stop Putin before his war on Ukraine escalates. --PW0UYIpUfo2k2zdg Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABECAB0WIQRPfPO7r0eAhk010v0w5/Bqldv68gUCZBxAZQAKCRAw5/Bqldv6 8pImAJ980SFJLWibENGuBRgkO7NwT1wjugCguwbshHgsV+9S/7u61KaJxx8XEEA= =1SzX -----END PGP SIGNATURE----- --PW0UYIpUfo2k2zdg--