From: Frederic Weisbecker <frederic@kernel.org>
To: Anna-Maria Behnsen <anna-maria@linutronix.de>
Cc: linux-kernel@vger.kernel.org,
Peter Zijlstra <peterz@infradead.org>,
John Stultz <jstultz@google.com>,
Thomas Gleixner <tglx@linutronix.de>,
Eric Dumazet <edumazet@google.com>,
"Rafael J . Wysocki" <rafael.j.wysocki@intel.com>,
Arjan van de Ven <arjan@infradead.org>,
"Paul E . McKenney" <paulmck@kernel.org>,
Frederic Weisbecker <fweisbec@gmail.com>,
Rik van Riel <riel@surriel.com>
Subject: Re: [PATCH v5 16/18] timer: Implement the hierarchical pull model
Date: Tue, 4 Apr 2023 16:32:20 +0200 [thread overview]
Message-ID: <ZCw09IfpV9py2+Zk@lothringen> (raw)
In-Reply-To: <d55fbe28-23f9-e3a9-92bc-1a726224ed69@linutronix.de>
On Tue, Apr 04, 2023 at 04:05:27PM +0200, Anna-Maria Behnsen wrote:
> On Tue, 21 Mar 2023, Frederic Weisbecker wrote:
>
> > On Wed, Mar 01, 2023 at 03:17:42PM +0100, Anna-Maria Behnsen wrote:
> > > +static u64 tmigr_handle_remote_cpu(unsigned int cpu, u64 now,
> > > + unsigned long jif)
> > > +{
> > > + struct timer_events tevt;
> > > + struct tmigr_walk data;
> > > + struct tmigr_cpu *tmc;
> > > + u64 next = KTIME_MAX;
> > > + unsigned long flags;
> > > +
> > > + tmc = per_cpu_ptr(&tmigr_cpu, cpu);
> > > +
> > > + raw_spin_lock_irqsave(&tmc->lock, flags);
> > > + /*
> > > + * Remote CPU is offline or no longer idle or other cpu handles cpu
> > > + * timers already or next event was already expired - return!
> > > + */
> > > + if (!tmc->online || tmc->remote || tmc->cpuevt.ignore ||
> > > + now < tmc->cpuevt.nextevt.expires) {
> > > + raw_spin_unlock_irqrestore(&tmc->lock, flags);
> > > + return next;
> > > + }
> > > +
> > > + tmc->remote = 1;
> > > +
> > > + /* Drop the lock to allow the remote CPU to exit idle */
> > > + raw_spin_unlock_irqrestore(&tmc->lock, flags);
> > > +
> > > + if (cpu != smp_processor_id())
> > > + timer_expire_remote(cpu);
> > > +
> > > + /* next event of cpu */
> > > + fetch_next_timer_interrupt_remote(jif, now, &tevt, cpu);
> >
> > If the target CPU gets an idle interrupt right after the above call and enqueues
> > a new timer (which becomes the new earliest), tmigr_cpu_deactivate() ->
> > tmigr_new_timer() is going to ignore it due to tmc->remote = 1, right?
>
> It's worse. The newly enqueued timer is updated in the timer migration
> hierarchy when CPU goes back idle and afterwards it will be overwritten by
> the group walk propagating the old first timer in
> tmigr_handle_remote_cpu()...
Hmm then that would require the remote CPU to exit dynticks and then
re-enter dynticks, right? Yes, sounds possible too.
>
> I will change the code after remote timer expiry:
>
> 1. take the remote timer bases locks
> 2. take the tmc->lock
> 3. get the next timer interrupt remote
> 4. drop the remote timer bases locks
> 5. propagate new timer changes
> 6. drop the tmc->lock
Right that sounds good!
Thanks.
>
> Thanks,
>
> Anna-Maria
next prev parent reply other threads:[~2023-04-04 14:32 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-01 14:17 [PATCH v5 00/18] timer: Move from a push remote at enqueue to a pull at expiry model Anna-Maria Behnsen
2023-03-01 14:17 ` [PATCH v5 01/18] tick-sched: Warn when next tick seems to be in the past Anna-Maria Behnsen
2023-03-01 14:17 ` [PATCH v5 02/18] timer: Add comment to get_next_timer_interrupt() description Anna-Maria Behnsen
2023-04-11 9:36 ` Frederic Weisbecker
2023-04-11 16:10 ` Anna-Maria Behnsen
2023-04-12 11:29 ` Frederic Weisbecker
2023-03-01 14:17 ` [PATCH v5 03/18] timer: Move store of next event into __next_timer_interrupt() Anna-Maria Behnsen
2023-03-21 12:48 ` Peter Zijlstra
2023-04-12 11:32 ` Frederic Weisbecker
2023-03-01 14:17 ` [PATCH v5 04/18] timer: Split next timer interrupt logic Anna-Maria Behnsen
2023-03-01 14:17 ` [PATCH v5 05/18] timer: Rework idle logic Anna-Maria Behnsen
2023-03-01 14:17 ` [PATCH v5 06/18] add_timer_on(): Make sure callers have TIMER_PINNED flag Anna-Maria Behnsen
2023-03-01 14:17 ` [PATCH v5 07/18] timers: Ease code in run_local_timers() Anna-Maria Behnsen
2023-04-12 14:32 ` Frederic Weisbecker
2023-03-01 14:17 ` [PATCH v5 08/18] timers: Create helper function to forward timer base clk Anna-Maria Behnsen
2023-04-12 14:40 ` Frederic Weisbecker
2023-03-01 14:17 ` [PATCH v5 09/18] timer: Keep the pinned timers separate from the others Anna-Maria Behnsen
2023-03-01 14:17 ` [PATCH v5 10/18] timer: Retrieve next expiry of pinned/non-pinned timers seperately Anna-Maria Behnsen
2023-03-01 14:17 ` [PATCH v5 11/18] timer: Split out "get next timer interrupt" functionality Anna-Maria Behnsen
2023-03-09 16:30 ` Frederic Weisbecker
2023-03-09 17:45 ` Frederic Weisbecker
2023-03-21 14:30 ` Peter Zijlstra
2023-04-12 20:34 ` Frederic Weisbecker
2023-03-01 14:17 ` [PATCH v5 12/18] timer: Add get next timer interrupt functionality for remote CPUs Anna-Maria Behnsen
2023-03-01 14:17 ` [PATCH v5 13/18] timer: Restructure internal locking Anna-Maria Behnsen
2023-03-01 14:17 ` [PATCH v5 14/18] timer: Check if timers base is handled already Anna-Maria Behnsen
2023-03-21 14:43 ` Peter Zijlstra
2023-03-01 14:17 ` [PATCH v5 15/18] tick/sched: Split out jiffies update helper function Anna-Maria Behnsen
2023-03-01 14:17 ` [PATCH v5 16/18] timer: Implement the hierarchical pull model Anna-Maria Behnsen
2023-03-14 13:24 ` Frederic Weisbecker
2023-03-14 14:49 ` Anna-Maria Behnsen
2023-03-14 16:01 ` Frederic Weisbecker
2023-03-21 11:17 ` Frederic Weisbecker
2023-04-04 14:05 ` Anna-Maria Behnsen
2023-04-04 14:32 ` Frederic Weisbecker [this message]
2023-03-21 13:25 ` Frederic Weisbecker
2023-04-06 9:12 ` Anna-Maria Behnsen
2023-03-21 15:29 ` Peter Zijlstra
2023-03-21 15:34 ` Peter Zijlstra
2023-03-21 15:40 ` Peter Zijlstra
2023-03-23 9:22 ` Peter Zijlstra
2023-03-23 9:34 ` Peter Zijlstra
2023-03-23 9:47 ` Peter Zijlstra
2023-03-23 12:47 ` Peter Zijlstra
2023-03-23 14:24 ` Peter Zijlstra
2023-04-04 14:56 ` Anna-Maria Behnsen
2023-03-01 14:17 ` [PATCH v5 17/18] timer_migration: Add tracepoints Anna-Maria Behnsen
2023-03-01 14:17 ` [PATCH v5 18/18] timer: Always queue timers on the local CPU Anna-Maria Behnsen
2023-03-21 12:46 ` [PATCH v5 00/18] timer: Move from a push remote at enqueue to a pull at expiry model Peter Zijlstra
2023-04-04 13:35 ` Anna-Maria Behnsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZCw09IfpV9py2+Zk@lothringen \
--to=frederic@kernel.org \
--cc=anna-maria@linutronix.de \
--cc=arjan@infradead.org \
--cc=edumazet@google.com \
--cc=fweisbec@gmail.com \
--cc=jstultz@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=paulmck@kernel.org \
--cc=peterz@infradead.org \
--cc=rafael.j.wysocki@intel.com \
--cc=riel@surriel.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).