From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E20DCC7EE22 for ; Tue, 9 May 2023 19:58:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230060AbjEIT5Y (ORCPT ); Tue, 9 May 2023 15:57:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39562 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229555AbjEIT5V (ORCPT ); Tue, 9 May 2023 15:57:21 -0400 Received: from out-2.mta0.migadu.com (out-2.mta0.migadu.com [IPv6:2001:41d0:1004:224b::2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 179C13C0B for ; Tue, 9 May 2023 12:57:19 -0700 (PDT) Date: Tue, 9 May 2023 15:57:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1683662238; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=vA3sbbV/QHVDEjFWeRW1Pm0ZfEpL5zDeaHwLB6+B5mM=; b=LIjUnmNxS8zN+vYMhDT777VrmOACO6jwMvt5gO+8h44LS8gTFFx/ZseLESAkOf3iWbefUm 5h5F1IFqHB+hPJr/ZJwiTYG5znYVAvWkwxkodArfJldk7wj43vOFNhstko3JOQ0thONvyA InTGcdRW5rNd1CoPZXKYU/LtJb9c/7w= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Kent Overstreet To: Peter Zijlstra Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-bcachefs@vger.kernel.org, Ingo Molnar , Will Deacon , Waiman Long , Boqun Feng Subject: Re: [PATCH 03/32] locking/lockdep: lockdep_set_no_check_recursion() Message-ID: References: <20230509165657.1735798-1-kent.overstreet@linux.dev> <20230509165657.1735798-4-kent.overstreet@linux.dev> <20230509193147.GC2148518@hirez.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230509193147.GC2148518@hirez.programming.kicks-ass.net> X-Migadu-Flow: FLOW_OUT Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 09, 2023 at 09:31:47PM +0200, Peter Zijlstra wrote: > On Tue, May 09, 2023 at 12:56:28PM -0400, Kent Overstreet wrote: > > This adds a method to tell lockdep not to check lock ordering within a > > lock class - but to still check lock ordering w.r.t. other lock types. > > > > This is for bcachefs, where for btree node locks we have our own > > deadlock avoidance strategy w.r.t. other btree node locks (cycle > > detection), but we still want lockdep to check lock ordering w.r.t. > > other lock types. > > > > ISTR you had a much nicer version of this where you gave a custom order > function -- what happend to that? Probably in the other branch that I was meaning to re-mail you separately, clearly I hadn't pulled the latest versions back into here... expect that shortly :)