From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64B6EC7EE32 for ; Wed, 24 May 2023 09:50:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231675AbjEXJuV (ORCPT ); Wed, 24 May 2023 05:50:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33398 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230353AbjEXJuS (ORCPT ); Wed, 24 May 2023 05:50:18 -0400 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C0F779E; Wed, 24 May 2023 02:50:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1684921816; x=1716457816; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=AHaPKxRJsJfEmgKrbdk7X9VP2w6I/wDac/mkRqDZPHc=; b=TXG0osg+lJ/THftiF1qdFiQkN1f7kjjLd/S7ywmephPPvvGWzCRC3jSP S5iJ4rfG7oftnAWdO59b7hWY3jutxWKzGUw7julpzGl2Z1/V1xEMrOdoS F3h01YJgO8Vp6A2I8AMMOAE9paRmLld2Hml08OBC9sC8ZsmhpvkdOv/uh mRa75CSndg1WGXTnqi0niiA96eP5zn89JJyiUWEzLOTWLGINZmfgOMvDm mICdHjNvgeR1ufB7PzQN10rwW1hzyrmaXmOOVGlPz6fFfKgGTonCm7DvE VlKj+hJdN5jQlglXxtA6Msp4PgsFIHvfxvkq3HITdzD0+9LYbuiEXBHU6 A==; X-IronPort-AV: E=McAfee;i="6600,9927,10719"; a="333140065" X-IronPort-AV: E=Sophos;i="6.00,188,1681196400"; d="scan'208";a="333140065" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 May 2023 02:50:16 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10719"; a="848676445" X-IronPort-AV: E=Sophos;i="6.00,188,1681196400"; d="scan'208";a="848676445" Received: from kuha.fi.intel.com ([10.237.72.185]) by fmsmga001.fm.intel.com with SMTP; 24 May 2023 02:50:11 -0700 Received: by kuha.fi.intel.com (sSMTP sendmail emulation); Wed, 24 May 2023 12:50:10 +0300 Date: Wed, 24 May 2023 12:50:10 +0300 From: Heikki Krogerus To: Bjorn Andersson Cc: Bjorn Andersson , Prashant Malani , Doug Anderson , Laurent Pinchart , Rob Clark , Sean Paul , David Airlie , Daniel Vetter , linux-arm-msm , LKML , Abhinav Kumar , Stephen Boyd , Kuogee Hsieh , dri-devel , Vara Reddy , freedreno , Enric Balletbo i Serra , Benson Leung Subject: Re: [RFC] drm/msm/dp: Allow attaching a drm_panel Message-ID: References: <20230522215348.uoyboow26n2o3tel@ripper> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230522215348.uoyboow26n2o3tel@ripper> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 22, 2023 at 02:53:48PM -0700, Bjorn Andersson wrote: > On Mon, May 22, 2023 at 03:51:01PM -0500, Bjorn Andersson wrote: > > On Fri, Oct 08, 2021 at 03:38:21PM +0300, Heikki Krogerus wrote: > > > Hi, > > > > > > On Thu, Oct 07, 2021 at 09:15:12AM -0700, Bjorn Andersson wrote: > > > > The one thing that I still don't understand though is, if the typec_mux > > > > is used by the typec controller to inform _the_ mux about the function > > > > to be used, what's up with the complexity in typec_mux_match()? This is > > > > what lead me to believe that typec_mux was enabling/disabling individual > > > > altmodes, rather just flipping the physical switch at the bottom. > > > > > > Ah, typec_mux_match() is a mess. I'm sorry about that. I think most of > > > the code in that function is not used by anybody. If I remember > > > correctly, all that complexity is attempting to solve some > > > hypothetical corner case(s). Probable a case where we have multiple > > > muxes per port to deal with. > > > > > > I think it would probable be best to clean the function to the bare > > > minimum by keeping only the parts that are actually used today > > > (attached). > > > > > > > Sorry for not replying to this in a timely manner Heikki. I've been > > ignoring this issue for a long time now, just adding "svid" to our dts > > files. But, this obviously shows up in DT validation - and I'd prefer > > not defining these properties as valid. > > > > The attached patch works as expected. > > > > Sorry, I must have failed at applying the patch - it doesn't work... > > > Could you please spin this as a proper patch, so we can get it merged? > > > > Regards, > > Bjorn > > > > > thanks, > > > > > > -- > > > heikki > > > > > diff --git a/drivers/usb/typec/mux.c b/drivers/usb/typec/mux.c > > > index c8340de0ed495..44f168c9bd9bf 100644 > > > --- a/drivers/usb/typec/mux.c > > > +++ b/drivers/usb/typec/mux.c > > > @@ -193,56 +193,15 @@ static int mux_fwnode_match(struct device *dev, const void *fwnode) > > > static void *typec_mux_match(struct fwnode_handle *fwnode, const char *id, > > > void *data) > > > { > > > - const struct typec_altmode_desc *desc = data; > > > struct device *dev; > > > - bool match; > > > - int nval; > > > - u16 *val; > > > - int ret; > > > - int i; > > > > > > /* > > > - * Check has the identifier already been "consumed". If it > > > - * has, no need to do any extra connection identification. > > > + * The connection identifier will be needed with device graph (OF graph). > > > + * Device graph is not supported by this code yet, so bailing out. > > > */ > > > - match = !id; > > > - if (match) > > > - goto find_mux; > > > - > > > - /* Accessory Mode muxes */ > > > - if (!desc) { > > > - match = fwnode_property_present(fwnode, "accessory"); > > > - if (match) > > > - goto find_mux; > > > - return NULL; > > > - } > > > - > > > - /* Alternate Mode muxes */ > > > - nval = fwnode_property_count_u16(fwnode, "svid"); > > > - if (nval <= 0) > > > - return NULL; > > > - > > > - val = kcalloc(nval, sizeof(*val), GFP_KERNEL); > > > - if (!val) > > > - return ERR_PTR(-ENOMEM); > > > - > > > - ret = fwnode_property_read_u16_array(fwnode, "svid", val, nval); > > > - if (ret < 0) { > > > - kfree(val); > > > - return ERR_PTR(ret); > > > - } > > > - > > > - for (i = 0; i < nval; i++) { > > > - match = val[i] == desc->svid; > > > - if (match) { > > > - kfree(val); > > > - goto find_mux; > > > - } > > > - } > > > - kfree(val); > > > - return NULL; > > > + if (id) > > We pass id as "mode-switch", so this will never be NULL. But we also only > want to consider endpoints with "mode-switch", otherwise we'll fail if > any of the referred endpoints is not implementing a typec_mux... > > So this needs the same snippet we find in typec_switch_match(): > > /* > * Device graph (OF graph) does not give any means to identify the > * device type or the device class of the remote port parent that @fwnode > * represents, so in order to identify the type or the class of @fwnode > * an additional device property is needed. With typec switches the > * property is named "orientation-switch" (@id). The value of the device > * property is ignored. > */ > if (id && !fwnode_property_present(fwnode, id)) > return NULL; > > With that, this works as expected! Okay. I'll change that and send the patch out. thanks, -- heikki