From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70BFFC77B73 for ; Wed, 24 May 2023 12:40:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233860AbjEXMkH (ORCPT ); Wed, 24 May 2023 08:40:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57950 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230031AbjEXMkD (ORCPT ); Wed, 24 May 2023 08:40:03 -0400 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0BEB999; Wed, 24 May 2023 05:40:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=p9jtkTU6w6N+Se7bpb6cKhTNXMlbx5R+g3G68tHH3fI=; b=q4afkSF547n2x/Eh++o0qH9q57 sC5Yj9bj8i7TPP3UxAdGHPjSjX+/eZEF8ZbkTv7n9WGqpU2ody/RS9qYRcqx6hbldOK0oMagXazma YxwR0hR/iF4MiXkuXe56qGi4+3J8uuQflrP0Jqy+iKiyRDBVJAUstx0qghXkfMiQDZHvgJ5KkG6eg Il+hOaIDZczLFhP2uGNCV3+u7oC9xtlv8+h0GQXVdznIEbCe4zzYryCcPdN3+R58bhfdIMG2ZNv9f sRYLfzGEYNVXtHGQQNPAxDZqEZ1SVS/wzeJNmcHpr/DtXyrOb5ICJ2EGAmeXbIt8V100ZNrpe6sJ6 Ck1XIEBA==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:59500) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1q1nmU-0002It-Gy; Wed, 24 May 2023 13:39:54 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1q1nmT-0001dY-K4; Wed, 24 May 2023 13:39:53 +0100 Date: Wed, 24 May 2023 13:39:53 +0100 From: "Russell King (Oracle)" To: Oleksij Rempel Cc: "David S. Miller" , Andrew Lunn , Eric Dumazet , Florian Fainelli , Jakub Kicinski , Paolo Abeni , Vladimir Oltean , Woojung Huh , Arun Ramadoss , kernel@pengutronix.de, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, UNGLinuxDriver@microchip.com Subject: Re: [PATCH net-next v1 1/5] net: dsa: microchip: improving error handling for 8-bit register RMW operations Message-ID: References: <20230524123220.2481565-1-o.rempel@pengutronix.de> <20230524123220.2481565-2-o.rempel@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230524123220.2481565-2-o.rempel@pengutronix.de> Sender: Russell King (Oracle) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 24, 2023 at 02:32:16PM +0200, Oleksij Rempel wrote: > This patch refines the error handling mechanism for 8-bit register > read-modify-write operations. In case of a failure, it now logs an error > message detailing the problematic offset. This enhancement aids in > debugging by providing more precise information when these operations > encounter issues. > > Furthermore, the ksz_prmw8() function has been updated to return error > values rather than void, enabling calling functions to appropriately > respond to errors. What happens when there is an error that affects the current and future accesses? Does this PHY driver then begin to flood the kernel log? -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!