From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9FEBDC77B73 for ; Wed, 24 May 2023 13:19:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232626AbjEXNTI (ORCPT ); Wed, 24 May 2023 09:19:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51738 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229632AbjEXNTG (ORCPT ); Wed, 24 May 2023 09:19:06 -0400 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C82649B; Wed, 24 May 2023 06:19:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=LN1VY0drdJalomyEpkD7+FhVOeln3OrXx82cPKL/2rU=; b=t3YL7yHK8KVYi2L4cBWsJ4J4ST 9wW/jJhDHimEmeAJeQoD/IlijHMm86jqdx+dPLlZNOWpQkE7odV+iIJMijP2vTJ0THDrIvZsxk9pq wT0aMxzjJY+4a95l3JirT5Mxo/af1B/ClkeiemevHsEMopFYWFdOTB1MvAniXO9Xv6AAH+C1QrmKU f8cTQfJaLUmliKvzBinpIK422UQ27i73eKXj5usn15PzEkxxK1X8Ex4fnyOEnCDmN5M29T+lWtNBM 5TEfe6YBG111wrXbAFvdIcd2hWmxJQ4UJx77qxNEiLuoLO6pVkzQJ2O4NfnVkGPEsCleuuA8jxjwi vjWuWmXA==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:51056) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1q1oOC-0002PQ-Rb; Wed, 24 May 2023 14:18:52 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1q1oO9-0001f6-HN; Wed, 24 May 2023 14:18:49 +0100 Date: Wed, 24 May 2023 14:18:49 +0100 From: "Russell King (Oracle)" To: Alexis =?iso-8859-1?Q?Lothor=E9?= Cc: Andrew Lunn , Florian Fainelli , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Richard Cochran , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, devicetree@vger.kernel.org, Thomas Petazzoni , paul.arola@telus.com, scott.roberts@telus.com, Marek =?iso-8859-1?Q?Beh=FAn?= Subject: Re: [PATCH net-next v3 2/7] net: dsa: mv88e6xxx: pass directly chip structure to mv88e6xxx_phy_is_internal Message-ID: References: <20230524130127.268201-1-alexis.lothore@bootlin.com> <20230524130127.268201-3-alexis.lothore@bootlin.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230524130127.268201-3-alexis.lothore@bootlin.com> Sender: Russell King (Oracle) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 24, 2023 at 03:01:22PM +0200, Alexis Lothoré wrote: > Since this function is a simple helper, we do not need to pass a full > dsa_switch structure, we can directly pass the mv88e6xxx_chip structure. > Doing so will allow to share this function with any other function > not manipulating dsa_switch structure but needing info about number of > internal phys > > Reviewed-by: Russell King (Oracle) > Reviewed-by: Florian Fainelli > > --- > Changes since v2: > - add reviewed-by tags > > Signed-off-by: Alexis Lothoré > --- It never ceases to amaze me the way human beings can find creative ways to mess things up, no matter how well things are documented. The above commit message (and the others that I've looked at) are all broken because of this creativity. In effect, because of the really weird format you've come up with here, your patches are in effect *not* signed off by you. The patch format is in Documentation/process/submitting-patches.rst under the section marked "The canonical patch format". Please review. Please wait a while (a few days) to see if anyone responds to _this_ posting with any other comments. Thanks. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!