From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 262CDC7EE24 for ; Mon, 15 May 2023 05:39:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238005AbjEOFjH (ORCPT ); Mon, 15 May 2023 01:39:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52538 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237858AbjEOFjD (ORCPT ); Mon, 15 May 2023 01:39:03 -0400 Received: from out-6.mta0.migadu.com (out-6.mta0.migadu.com [IPv6:2001:41d0:1004:224b::6]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 22533172B for ; Sun, 14 May 2023 22:38:57 -0700 (PDT) Date: Mon, 15 May 2023 01:38:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1684129134; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=SCdYxj+pGcMPPKC1xM0I2i1NfIoAtNhlotF4Zp9sgCo=; b=msAz3XvMQn/GS49szMGvEbrMi/5KGzPfhFDEnHuYY2XVWmZ/00FppHByOUR6s/CZ/onXqB cGT9PJe6jQ+RZTN+MOrOyDRwFRVnrGF2UrApcq8xxxIBZ+0moox1SVh7/p11EzvAQw2xD5 WKIygkKe+kwqZYQwQZ3D/ovnjnES2CA= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Kent Overstreet To: Eric Biggers Cc: Lorenzo Stoakes , Christoph Hellwig , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-bcachefs@vger.kernel.org, Kent Overstreet , Andrew Morton , Uladzislau Rezki , linux-mm@kvack.org Subject: Re: [PATCH 07/32] mm: Bring back vmalloc_exec Message-ID: References: <20230509165657.1735798-1-kent.overstreet@linux.dev> <20230509165657.1735798-8-kent.overstreet@linux.dev> <20230510064849.GC1851@quark.localdomain> <20230513015752.GC3033@quark.localdomain> <20230514184325.GB9528@sol.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230514184325.GB9528@sol.localdomain> X-Migadu-Flow: FLOW_OUT Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, May 14, 2023 at 11:43:25AM -0700, Eric Biggers wrote: > I think it would also help if the generated assembly had the handling of the > fields interleaved. To achieve that, it might be necessary to interleave the C > code. No, that has negligable effect on performance - as expected, for an out of order processor. < 1% improvement. It doesn't look like this approach is going to work here. Sadly.