From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 54344C77B75 for ; Tue, 23 May 2023 14:38:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237330AbjEWOiX (ORCPT ); Tue, 23 May 2023 10:38:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36916 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237322AbjEWOiT (ORCPT ); Tue, 23 May 2023 10:38:19 -0400 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E6A8F121; Tue, 23 May 2023 07:38:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=NLFTS+w5hN7WpRmvWgLF3ouUkJg9vy2d77yR3EYCI6E=; b=vQoDp++IV6aKY7+NungSxOllYP 0VTb4wQNDcsShENSioFKWXCiphToj+oP50h3oGWELjS0Ag/qUVDhX9wRy7/+8zBZGmKCHDn9hWur9 z988b4Dcsr3vEEASm3F+Cb4TQNm6DrwJ5MfahReo6uptxBpWX41cThDRmpXjsX8fSrZtymq+jYjpk 5fHmMxw52M6xdRTKsOwAR2bX5ZQCcGiA5TYm4f1I2fnoTi5Ee9+k/zRzsI+ejq8fm+okRWgajVyq6 9oJwSWgxF0fHKtwOtXO3PeztPI0gum4Xd8Rk2Q7F4n6gFNgVWPY/R4NnxZ4eUV+Vn4jgk6MNfVC91 X8w+4Kag==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:45946) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1q1T9P-0000Yd-QN; Tue, 23 May 2023 15:38:11 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1q1T9O-0000eQ-O2; Tue, 23 May 2023 15:38:10 +0100 Date: Tue, 23 May 2023 15:38:10 +0100 From: "Russell King (Oracle)" To: Lukasz Majewski Cc: Andrew Lunn , Vladimir Oltean , Eric Dumazet , Florian Fainelli , "David S. Miller" , Jakub Kicinski , Paolo Abeni , Alexander Duyck , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v7 1/3] dsa: marvell: Define .set_max_frame_size() function for mv88e6250 SoC family Message-ID: References: <20230523142912.2086985-1-lukma@denx.de> <20230523142912.2086985-2-lukma@denx.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230523142912.2086985-2-lukma@denx.de> Sender: Russell King (Oracle) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 23, 2023 at 04:29:10PM +0200, Lukasz Majewski wrote: > Switches from mv88e6250 family (the marketing name - "Link Street", > including mv88e6020 and mv88e6071) need the possibility to setup the > maximal frame size, as they support frames up to 2048 bytes. > > Signed-off-by: Lukasz Majewski Adding this function doesn't allow the "possibility" for a larger frame size. Adding it changes the value returned from mv88e6xxx_get_max_mtu() to be a larger frame size, so all switches that make use of mv88e6250_ops will be expected to support this larger frame size. Do we know whether that is true? There were patches floating about a while ago that specified the maximum size in struct mv88e6xxx_info, but it seems those died a death. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!