From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Henning Schild <henning.schild@siemens.com>
Cc: Pavel Machek <pavel@ucw.cz>, Lee Jones <lee@kernel.org>,
Hans de Goede <hdegoede@redhat.com>,
Mark Gross <markgross@kernel.org>,
linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org,
platform-driver-x86@vger.kernel.org
Subject: Re: [PATCH v4 1/4] leds: simatic-ipc-leds-gpio: add terminating entries to gpio tables
Date: Sat, 27 May 2023 11:54:08 +0300 [thread overview]
Message-ID: <ZHHFMPEYNz9jBBRd@smile.fi.intel.com> (raw)
In-Reply-To: <20230524124628.32295-2-henning.schild@siemens.com>
On Wed, May 24, 2023 at 02:46:25PM +0200, Henning Schild wrote:
> The entries do not seem to be stricly needed when the number of entries
> is given via the number of LEDs. But adding them is a safeguard should
> anyone ever iterate over the tables to their end, it also gets us in
> line with other drivers that register "leds-gpio" tables.
Reported-by?
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Signed-off-by: Henning Schild <henning.schild@siemens.com>
> ---
> drivers/leds/simple/simatic-ipc-leds-gpio.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/leds/simple/simatic-ipc-leds-gpio.c b/drivers/leds/simple/simatic-ipc-leds-gpio.c
> index e8d329b5a68c..1a1cfdad6218 100644
> --- a/drivers/leds/simple/simatic-ipc-leds-gpio.c
> +++ b/drivers/leds/simple/simatic-ipc-leds-gpio.c
> @@ -28,6 +28,7 @@ static struct gpiod_lookup_table simatic_ipc_led_gpio_table_127e = {
> GPIO_LOOKUP_IDX("apollolake-pinctrl.0", 51, NULL, 5, GPIO_ACTIVE_LOW),
> GPIO_LOOKUP_IDX("apollolake-pinctrl.0", 56, NULL, 6, GPIO_ACTIVE_LOW),
> GPIO_LOOKUP_IDX("apollolake-pinctrl.0", 59, NULL, 7, GPIO_ACTIVE_HIGH),
> + {} /* Terminating entry */
> },
> };
>
> @@ -42,6 +43,7 @@ static struct gpiod_lookup_table simatic_ipc_led_gpio_table_227g = {
> GPIO_LOOKUP_IDX("gpio-f7188x-2", 5, NULL, 5, GPIO_ACTIVE_LOW),
> GPIO_LOOKUP_IDX("gpio-f7188x-3", 6, NULL, 6, GPIO_ACTIVE_HIGH),
> GPIO_LOOKUP_IDX("gpio-f7188x-3", 7, NULL, 7, GPIO_ACTIVE_HIGH),
> + {} /* Terminating entry */
> }
> };
>
> --
> 2.39.3
>
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-05-27 8:54 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-24 12:46 [PATCH v4 0/4] leds: simatic-ipc-leds-gpio: split up Henning Schild
2023-05-24 12:46 ` [PATCH v4 1/4] leds: simatic-ipc-leds-gpio: add terminating entries to gpio tables Henning Schild
2023-05-27 8:54 ` Andy Shevchenko [this message]
2023-05-30 15:11 ` Henning Schild
2023-06-01 16:47 ` Andy Shevchenko
2023-06-08 17:30 ` Lee Jones
2023-06-09 14:25 ` Andy Shevchenko
2023-06-12 11:27 ` Lee Jones
2023-06-12 11:29 ` Lee Jones
2023-06-08 17:25 ` Lee Jones
2023-05-24 12:46 ` [PATCH v4 2/4] leds: simatic-ipc-leds-gpio: move two extra gpio pins into another table Henning Schild
2023-06-08 17:26 ` Lee Jones
2023-05-24 12:46 ` [PATCH v4 3/4] leds: simatic-ipc-leds-gpio: split up into multiple drivers Henning Schild
2023-06-08 17:27 ` Lee Jones
2023-05-24 12:46 ` [PATCH v4 4/4] leds: simatic-ipc-leds-gpio: introduce more Kconfig switches Henning Schild
2023-06-08 17:28 ` Lee Jones
2023-05-25 10:11 ` [PATCH v4 0/4] leds: simatic-ipc-leds-gpio: split up Hans de Goede
2023-05-27 8:58 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZHHFMPEYNz9jBBRd@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=hdegoede@redhat.com \
--cc=henning.schild@siemens.com \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=markgross@kernel.org \
--cc=pavel@ucw.cz \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).