From: Herbert Xu <herbert@gondor.apana.org.au>
To: Eric Biggers <ebiggers@kernel.org>
Cc: meenakshi.aggarwal@nxp.com, horia.geanta@nxp.com,
V.sethi@nxp.com, pankaj.gupta@nxp.com, gaurav.jain@nxp.com,
davem@davemloft.net, linux-crypto@vger.kernel.org,
linux-kernel@vger.kernel.org, iuliana.prodan@nxp.com
Subject: Re: [PATCH 0/5] Remove CRYPTO_ALG_ALLOCATES_MEMORY flag
Date: Thu, 1 Jun 2023 18:33:48 +0800 [thread overview]
Message-ID: <ZHh0DF4meU2ze+g7@gondor.apana.org.au> (raw)
In-Reply-To: <20230523165503.GA864814@google.com>
On Tue, May 23, 2023 at 04:55:03PM +0000, Eric Biggers wrote:
>
> This isn't mentioned in the documentation for CRYPTO_ALG_ALLOCATES_MEMORY. So
> it's not part of the contract of CRYPTO_ALG_ALLOCATES_MEMORY currently.
>
> Please don't make this change without updating the documentation.
>
> If you'd like to make this change, please update the documentation for
> CRYPTO_ALG_ALLOCATES_MEMORY to mention this additional exception.
Agreed. We talked about this at the time of the original patch-set,
but never made any changes in this direction.
Apparently the users are still the same so it should be possible
but it has to be done in the right order as Eric suggested.
Of course if the drivers don't actually need this then all the
better and let's not even bother with adding such a restriction.
Thanks,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2023-06-01 10:38 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-23 15:34 [PATCH 0/5] Remove CRYPTO_ALG_ALLOCATES_MEMORY flag meenakshi.aggarwal
2023-05-23 15:34 ` [PATCH 1/5] crypto:caam - avoid allocating memory at crypto request runtime for skcipher meenakshi.aggarwal
2023-05-23 15:34 ` [PATCH 2/5] crypto:caam - avoid allocating memory at crypto request runtime for aead meenakshi.aggarwal
2023-05-23 15:34 ` [PATCH 3/5] crypto: caam - avoid allocating memory at crypto request runtime for hash meenakshi.aggarwal
2023-05-23 15:34 ` [PATCH 4/5] crypto: caam/qi - avoid allocating memory at crypto request runtime meenakshi.aggarwal
2023-05-23 15:34 ` [PATCH 5/5] crypto: caam/qi2 " meenakshi.aggarwal
2023-05-23 16:55 ` [PATCH 0/5] Remove CRYPTO_ALG_ALLOCATES_MEMORY flag Eric Biggers
2023-05-26 6:10 ` Meenakshi Aggarwal
2023-06-01 10:33 ` Herbert Xu [this message]
2023-06-01 11:23 ` Giovanni Cabiddu
2023-06-09 9:24 ` Herbert Xu
2023-06-10 8:41 ` Giovanni Cabiddu
2023-06-14 6:21 ` Meenakshi Aggarwal
2023-06-14 9:48 ` Herbert Xu
2023-07-04 9:19 ` Meenakshi Aggarwal
2023-07-05 17:51 ` Giovanni Cabiddu
2023-07-06 5:05 ` Meenakshi Aggarwal
2023-06-08 11:45 ` Pankaj Gupta
2023-06-09 10:38 ` [PATCH v2 " meenakshi.aggarwal
2023-06-09 10:38 ` [PATCH v2 1/5] crypto:caam - avoid allocating memory at crypto request runtime for skcipher meenakshi.aggarwal
2023-06-10 2:18 ` Eric Biggers
2023-06-12 8:22 ` Meenakshi Aggarwal
2023-06-09 10:38 ` [PATCH v2 2/5] crypto:caam - avoid allocating memory at crypto request runtime for aead meenakshi.aggarwal
2023-06-09 10:38 ` [PATCH v2 3/5] crypto: caam - avoid allocating memory at crypto request runtime for hash meenakshi.aggarwal
2023-06-09 10:38 ` [PATCH v2 4/5] crypto: caam/qi - avoid allocating memory at crypto request runtime meenakshi.aggarwal
2023-06-09 10:38 ` [PATCH v2 5/5] crypto: caam/qi2 " meenakshi.aggarwal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZHh0DF4meU2ze+g7@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=V.sethi@nxp.com \
--cc=davem@davemloft.net \
--cc=ebiggers@kernel.org \
--cc=gaurav.jain@nxp.com \
--cc=horia.geanta@nxp.com \
--cc=iuliana.prodan@nxp.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=meenakshi.aggarwal@nxp.com \
--cc=pankaj.gupta@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).