From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B437EB64D9 for ; Sat, 17 Jun 2023 10:38:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233975AbjFQKiN (ORCPT ); Sat, 17 Jun 2023 06:38:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58504 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346260AbjFQKiF (ORCPT ); Sat, 17 Jun 2023 06:38:05 -0400 Received: from mail-ej1-x62d.google.com (mail-ej1-x62d.google.com [IPv6:2a00:1450:4864:20::62d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E2A9026B1 for ; Sat, 17 Jun 2023 03:37:18 -0700 (PDT) Received: by mail-ej1-x62d.google.com with SMTP id a640c23a62f3a-987f7045f9aso29180466b.1 for ; Sat, 17 Jun 2023 03:37:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20221208.gappssmtp.com; s=20221208; t=1686998172; x=1689590172; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=/1x1TufhGga+vhofQhW3+rOkuF8WKt/IeOnnrmJtrog=; b=BSLERsDAgGslIeEyq94ScS8bRLgPPRRRwT8Nf8n+6gest5CBJm7weH95XbHUWqLPrs lMqAZ5YohISaainT6DoT5KRo+06ct7IyRAWJITH8QiX+CKXNRf7RTEbj4ehIcYJxYtHJ S+tMFiI9UWNXT2a5hg0KLa/1NxteLO2ap4RvVkp9qGeFfK5FKir/7euwyrkgLckOtKmi Xn2ZIAD96h2+mraRrWLl1sWZ/1oEO7vpCWKa7qJYU0VpWfYwdunjJkr7fjK6tTnVnk6L LIWC6DFNj4ViFnScRoCYtPIpyJ2HWmk9OlLm6i3tklX7Kcc0HpSuhcjnvvvKwhWWp6Pq o8mA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686998172; x=1689590172; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=/1x1TufhGga+vhofQhW3+rOkuF8WKt/IeOnnrmJtrog=; b=VgGWsbwP6HXL+EPHRcnbCz0lAuJddtXhXl7bLRG2bXifwdOyraKkG6/fiRsNw0u2U+ JAP3BysLrU+66ugIsd59DZW7AMlT4/0Y+iUvjl1ykCTKK8ANBXXep+YVLUXfrGUT478a FhJBZLvXq1fGzWa1ubqRpsY2f4pCBkg/l8ISFMf1K/XFtmct9eNcYj4DlSXxEMsyVNBK HlbRlyLjfwf6AeEZWFYQUVmnmP/6OFwRP8Mh2dawplB1CF7UmVS7JtR9GJHaKFjui+kG 39WI9nCoUjAx/bUmHRrqxZA1cRmbm/0IK2ZS9k2MHnHjz9qNp1946yGBbNVhg3BLOhVX xezQ== X-Gm-Message-State: AC+VfDwWp0SgbwNa4mN5rq2yf5IRWxmmIBIIcAYj8ahfveni8V3kOZ6z Q2Oha3krU1wL0peBvvGUj6+o3Q== X-Google-Smtp-Source: ACHHUZ7OhqQdwYiCXLWpW4pNAkdtQLu1xzSJt4dCibpw5uqj3GQ/nixFPiQmcTPdSiQpJVj0JEscIg== X-Received: by 2002:a17:907:7204:b0:94f:5847:8ac with SMTP id dr4-20020a170907720400b0094f584708acmr4832912ejc.51.1686998172291; Sat, 17 Jun 2023 03:36:12 -0700 (PDT) Received: from localhost (host-213-179-129-39.customer.m-online.net. [213.179.129.39]) by smtp.gmail.com with ESMTPSA id s22-20020a1709064d9600b00982881f1e2dsm4053734eju.84.2023.06.17.03.36.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 17 Jun 2023 03:36:11 -0700 (PDT) Date: Sat, 17 Jun 2023 12:36:09 +0200 From: Jiri Pirko To: Jakub Kicinski Cc: "Kubalewski, Arkadiusz" , "vadfed@meta.com" , "jonathan.lemon@gmail.com" , "pabeni@redhat.com" , "corbet@lwn.net" , "davem@davemloft.net" , "edumazet@google.com" , "vadfed@fb.com" , "Brandeburg, Jesse" , "Nguyen, Anthony L" , "M, Saeed" , "leon@kernel.org" , "richardcochran@gmail.com" , "sj@kernel.org" , "javierm@redhat.com" , "ricardo.canuelo@collabora.com" , "mst@redhat.com" , "tzimmermann@suse.de" , "Michalik, Michal" , "gregkh@linuxfoundation.org" , "jacek.lawrynowicz@linux.intel.com" , "airlied@redhat.com" , "ogabbay@kernel.org" , "arnd@arndb.de" , "nipun.gupta@amd.com" , "axboe@kernel.dk" , "linux@zary.sk" , "masahiroy@kernel.org" , "benjamin.tissoires@redhat.com" , "geert+renesas@glider.be" , "Olech, Milena" , "kuniyu@amazon.com" , "liuhangbin@gmail.com" , "hkallweit1@gmail.com" , "andy.ren@getcruise.com" , "razor@blackwall.org" , "idosch@nvidia.com" , "lucien.xin@gmail.com" , "nicolas.dichtel@6wind.com" , "phil@nwl.cc" , "claudiajkang@gmail.com" , "linux-doc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "netdev@vger.kernel.org" , "intel-wired-lan@lists.osuosl.org" , "linux-rdma@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , poros , mschmidt , "linux-clk@vger.kernel.org" , "vadim.fedorenko@linux.dev" Subject: Re: [RFC PATCH v8 01/10] dpll: documentation on DPLL subsystem interface Message-ID: References: <20230609121853.3607724-2-arkadiusz.kubalewski@intel.com> <20230612154329.7bd2d52f@kernel.org> <20230613093801.735cd341@kernel.org> <20230614121514.0d038aa3@kernel.org> <20230614122348.3e9b7e42@kernel.org> <20230615093111.0ee762e4@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230615093111.0ee762e4@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Thu, Jun 15, 2023 at 06:31:11PM CEST, kuba@kernel.org wrote: >On Thu, 15 Jun 2023 12:18:28 +0200 Jiri Pirko wrote: >> Yeah, that is what we had originally. This just pushes out the >> different attr selection from the nest one level up to the actualy >> nesting attribute. > >Oh no, no extra nesting. Let me try to fake up the output: I wasn't implying any extra nesting. > >'pin': [{ > {'clock-id': 282574471561216, > 'module-name': 'ice', > 'pin-dpll-caps': 4, > 'pin-id': 13, > 'parent-device': [{'pin-id': 2, 'pin-state': 'connected'}, > {'pin-id': 3, 'pin-state': 'disconnected'}], > 'parent-pin': [{'id': 0, 'pin-direction': 'input'}, > {'id': 1, 'pin-direction': 'input'}], > 'pin-type': 'synce-eth-port'} You messed up a bit. Should be: parent-device : id parent-pin : pin-id That is basically my point. The fact if the parent is either device or pin is carried inside the nest by either providing "id" or "pin-id". So you add redundant info which could be source of mixups - as you already demonstrated :) >}] > >> One downside of this is you will have 2 arrays of parent objects, >> one per parent type. Current code neatly groups them into a single array. >> >> I guess this is a matter of personal preference, I'm fine either way. > >Yeah, could be.