From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C7EB8C7EE29 for ; Thu, 8 Jun 2023 19:28:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233746AbjFHT2X (ORCPT ); Thu, 8 Jun 2023 15:28:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43968 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230125AbjFHT2W (ORCPT ); Thu, 8 Jun 2023 15:28:22 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3699DA2; Thu, 8 Jun 2023 12:28:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=2OPOPDQNskA4BE/Gx3h1tR4IYFZdWY+xCSOk3HTM7xQ=; b=ndVCovkL3OxQIwE7DQTs8wzCCZ 0+xAnPCsS1Vm90PjXkm3imrmH/DfIi+IZleBJYFlJ+Ga4ibnk0kNfYIcv4oospOfH2gnNKORBJNAd qjJBwkEOTA3Qp4lvVfrkgAuv83Ormd2RlKq6+A7OzcXk2lD5WATXgdvJz3LLaogKmMZFTE6XWGpnS gzJVGprSP3ImLnfpR1yVEbaL08HQbHYqMhH6ljv9VkzvaQZj18KftNwDf5mJoBTP1r5cENJ3Mcera rtCD7guY+rzOzYEd9ztulvyQAnrY9Vf82qotYfMkhcKiBFhfMFB9qvr26Kq5z/yUv2uWztWRG7qLH l0LXi24w==; Received: from mcgrof by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1q7LIg-00AM6g-1o; Thu, 08 Jun 2023 19:28:02 +0000 Date: Thu, 8 Jun 2023 12:28:02 -0700 From: Luis Chamberlain To: Maninder Singh Cc: ast@kernel.org, daniel@iogearbox.net, john.fastabend@gmail.com, andrii@kernel.org, martin.lau@linux.dev, song@kernel.org, yhs@fb.com, kpsingh@kernel.org, sdf@google.com, haoluo@google.com, jolsa@kernel.org, thunder.leizhen@huawei.com, boqun.feng@gmail.com, vincenzopalazzodev@gmail.com, ojeda@kernel.org, jgross@suse.com, brauner@kernel.org, michael.christie@oracle.com, samitolvanen@google.com, glider@google.com, peterz@infradead.org, keescook@chromium.org, stephen.s.brennan@oracle.com, alan.maguire@oracle.com, pmladek@suse.com, linux-kernel@vger.kernel.org, bpf@vger.kernel.org, Onkarnath Subject: Re: [PATCH v5 2/2] kallsyms: make kallsyms_show_value() as generic function Message-ID: References: <20230608033119.1543638-1-maninder1.s@samsung.com> <20230608033119.1543638-2-maninder1.s@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230608033119.1543638-2-maninder1.s@samsung.com> Sender: Luis Chamberlain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 08, 2023 at 09:01:19AM +0530, Maninder Singh wrote: > This change makes function kallsyms_show_value() as > generic function without dependency on CONFIG_KALLSYMS. > > Now module address will be displayed with lsmod and /proc/modules. > > Earlier: > ======= > / # insmod test.ko > / # lsmod > test 12288 0 - Live 0x0000000000000000 (O) // No Module Load address > / # > > With change: > ========== > / # insmod test.ko > / # lsmod > test 12288 0 - Live 0xffff800000fc0000 (O) // Module address > / # cat /proc/modules > test 12288 0 - Live 0xffff800000fc0000 (O) > > Co-developed-by: Onkarnath > Signed-off-by: Onkarnath > Signed-off-by: Maninder Singh > Reviewed-by: Zhen Lei Thanks! Pushed to modules-next. Luis