From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9474EEB64D9 for ; Wed, 14 Jun 2023 09:51:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236053AbjFNJvC (ORCPT ); Wed, 14 Jun 2023 05:51:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49368 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244354AbjFNJuH (ORCPT ); Wed, 14 Jun 2023 05:50:07 -0400 Received: from 167-179-156-38.a7b39c.syd.nbn.aussiebb.net (167-179-156-38.a7b39c.syd.nbn.aussiebb.net [167.179.156.38]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3930D1BF6; Wed, 14 Jun 2023 02:49:59 -0700 (PDT) Received: from loth.rohan.me.apana.org.au ([192.168.167.2]) by formenos.hmeau.com with smtp (Exim 4.94.2 #2 (Debian)) id 1q9N8N-002omh-FI; Wed, 14 Jun 2023 17:49:48 +0800 Received: by loth.rohan.me.apana.org.au (sSMTP sendmail emulation); Wed, 14 Jun 2023 17:49:47 +0800 Date: Wed, 14 Jun 2023 17:49:47 +0800 From: Herbert Xu To: Mahmoud Adam Cc: dhowells@redhat.com, davem@davemloft.net, keyrings@vger.kernel.org, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] KEYS: use kfree_sensitive with key Message-ID: References: <20230613160723.61729-1-mngyadam@amazon.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230613160723.61729-1-mngyadam@amazon.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 13, 2023 at 04:07:23PM +0000, Mahmoud Adam wrote: > key member might contain private part of the key, so better use > kfree_sensitive to free it > > Signed-off-by: Mahmoud Adam > --- > crypto/asymmetric_keys/public_key.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/crypto/asymmetric_keys/public_key.c b/crypto/asymmetric_keys/public_key.c > index eca5671ad3f2..006ae170a16f 100644 > --- a/crypto/asymmetric_keys/public_key.c > +++ b/crypto/asymmetric_keys/public_key.c > @@ -43,7 +43,7 @@ static void public_key_describe(const struct key *asymmetric_key, > void public_key_free(struct public_key *key) > { > if (key) { > - kfree(key->key); > + kfree_sensitive(key->key); The public key should not be freed with kfree_sensitive. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt