From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: baomingtong001@208suo.com
Cc: peterz@infradead.org, mingo@redhat.com, mark.rutland@arm.com,
alexander.shishkin@linux.intel.com, jolsa@kernel.org,
namhyung@kernel.org, irogers@google.com, adrian.hunter@intel.com,
kan.liang@linux.intel.com, zhengjun.xing@linux.intel.com,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] perf parse-events: Remove unneeded semicolon
Date: Wed, 14 Jun 2023 10:55:50 -0300 [thread overview]
Message-ID: <ZInG5t2brWyKzvhy@kernel.org> (raw)
In-Reply-To: <2c733a91717eae93119ba2226420fd8f@208suo.com>
Em Wed, Jun 14, 2023 at 04:13:53PM +0800, baomingtong001@208suo.com escreveu:
> ./tools/perf/util/parse-events.c:1466:2-3: Unneeded semicolon
Was this detected by some tool? Which one?
- Arnaldo
> Signed-off-by: Mingtong Bao <baomingtong001@208suo.com>
> ---
> tools/perf/util/parse-events.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/util/parse-events.c b/tools/perf/util/parse-events.c
> index 629f7bd9fd59..42f84f61fabc 100644
> --- a/tools/perf/util/parse-events.c
> +++ b/tools/perf/util/parse-events.c
> @@ -1463,7 +1463,7 @@ static int __parse_events_add_numeric(struct
> parse_events_state *parse_state,
> if (extended_type && (type == PERF_TYPE_HARDWARE || type ==
> PERF_TYPE_HW_CACHE)) {
> assert(perf_pmus__supports_extended_type());
> attr.config |= (u64)extended_type << PERF_PMU_TYPE_SHIFT;
> - };
> + }
>
> if (head_config) {
> if (config_attr(&attr, head_config, parse_state->error,
--
- Arnaldo
next prev parent reply other threads:[~2023-06-14 13:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230614080937.54937-1-luojianhong@cdjrlc.com>
2023-06-14 8:13 ` [PATCH] perf parse-events: Remove unneeded semicolon baomingtong001
2023-06-14 13:55 ` Arnaldo Carvalho de Melo [this message]
2023-06-20 22:50 ` Namhyung Kim
2023-06-21 17:24 ` Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZInG5t2brWyKzvhy@kernel.org \
--to=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=baomingtong001@208suo.com \
--cc=irogers@google.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=zhengjun.xing@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).