From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16833EB64D8 for ; Wed, 14 Jun 2023 16:24:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233439AbjFNQYS (ORCPT ); Wed, 14 Jun 2023 12:24:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40504 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229569AbjFNQYN (ORCPT ); Wed, 14 Jun 2023 12:24:13 -0400 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8F19D109; Wed, 14 Jun 2023 09:24:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=tL93bI0jCWhGF3WG58T3OaJIDMhjtKg7c9c3OsvljCg=; b=qpvSUqzkIvq2pf6t36jXKr2o0P 1Bb6JiMkPcXkWHbaeticZajm/w8h5A8KKPUZjGIRbHW1DdbuoG5p+MfHoSC4KyGHTCJbyBZ9suO+Y l3/uYhPVsVfLBLNYjylwXFXfZHY644VQ5UpytE3b/DsndFToTAGZr5m2Fao8tNA2x4KTW/eg8XS2m obtH625jiwihlTyS/r+/aJBLQSmUpUfWPSPEAqhgxgEIOMyMO/VjPTTlWxg+8flWGQIVe1ZsawW89 v6JZszuL/Hepl08MvDDCE1E/v81nXvJ0s5ZhpW4WsMhzRvVkRTyADmSpQ/jCS3jUEdnRV7fo6roLT eoZnZJ4g==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:40838) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1q9THx-0001yP-1A; Wed, 14 Jun 2023 17:24:05 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1q9THu-0000Z3-LM; Wed, 14 Jun 2023 17:24:02 +0100 Date: Wed, 14 Jun 2023 17:24:02 +0100 From: "Russell King (Oracle)" To: Wei Chin Tsai Cc: lkp@intel.com, angelogioacchino.delregno@collabora.com, ivan.tseng@mediatek.com, linux-arm-kernel@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, matthias.bgg@gmail.com, mel.lee@mediatek.com, oe-kbuild-all@lists.linux.dev, wsd_upstream@mediatek.com Subject: Re: [PATCH v3 1/1] memory: Fix export symbol twice compiler error for "export symbols for memory related functions" patch Message-ID: References: <202306142030.GjGWnIkY-lkp@intel.com> <20230614153902.26206-1-Wei-chin.Tsai@mediatek.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230614153902.26206-1-Wei-chin.Tsai@mediatek.com> Sender: Russell King (Oracle) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 14, 2023 at 11:39:02PM +0800, Wei Chin Tsai wrote: > User could not add the export symbol "arch_vma_name" > in arch/arm/kernel/process.c and kernel/signal.c both. > It would cause the export symbol twice compiler error > Reported-by: kernel test robot > > Signed-off-by: Wei Chin Tsai I'm sorry, but this patch is silly. > diff --git a/arch/arm/kernel/process.c b/arch/arm/kernel/process.c > index df91412a1069..d71a9bafb584 100644 > --- a/arch/arm/kernel/process.c > +++ b/arch/arm/kernel/process.c > @@ -343,7 +343,10 @@ const char *arch_vma_name(struct vm_area_struct *vma) > { > return is_gate_vma(vma) ? "[vectors]" : NULL; > } > + > +#ifdef CONFIG_ARM > EXPORT_SYMBOL_GPL(arch_vma_name); > +#endif CONFIG_ARM will always be set here, so adding this ifdef is useless. > diff --git a/kernel/signal.c b/kernel/signal.c > index a1abe77fcdc3..f7d03450781e 100644 > --- a/kernel/signal.c > +++ b/kernel/signal.c > @@ -4700,7 +4700,10 @@ __weak const char *arch_vma_name(struct vm_area_struct *vma) > { > return NULL; > } > + > +#ifdef CONFIG_ARM64 > EXPORT_SYMBOL_GPL(arch_vma_name); > +#endif Sorry, but no. Please do the research I've now twice asked for. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!