linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Herbert Xu <herbert@gondor.apana.org.au>
To: Tom Zanussi <tom.zanussi@linux.intel.com>
Cc: davem@davemloft.net, fenghua.yu@intel.com, vkoul@kernel.org,
	dave.jiang@intel.com, tony.luck@intel.com,
	wajdi.k.feghali@intel.com, james.guilford@intel.com,
	kanchana.p.sridhar@intel.com, vinodh.gopal@intel.com,
	giovanni.cabiddu@intel.com, linux-kernel@vger.kernel.org,
	linux-crypto@vger.kernel.org, dmaengine@vger.kernel.org
Subject: Re: [PATCH v6 13/15] crypto: iaa - Add support for deflate-iaa-canned compression algorithm
Date: Fri, 16 Jun 2023 18:55:10 +0800	[thread overview]
Message-ID: <ZIw/jtxdg6O1O0j3@gondor.apana.org.au> (raw)
In-Reply-To: <20230605201536.738396-14-tom.zanussi@linux.intel.com>

On Mon, Jun 05, 2023 at 03:15:34PM -0500, Tom Zanussi wrote:
> Add support for a 'canned' compression mode using the IAA compression
> mode in-kernel API.
> 
> The IAA 'canned' compression mode is added alongside the existing
> 'fixed' compression mode and a crypto algorithm named
> 'deflate-iaa-canned' is registered using it.

So you said that canned is not compatible with the generic deflate
algorithm.  Does that mean that there is no way for it to decompress
something compressed by the generic deflate algorithm, and vice versa
its compressed output cannot be decompressed by generic deflate?

We don't add an algorithm to the Crypto API if the only implementation
is by hardware.  IOW if you are adding a new algorithm, then a
software version must be the first patch.

Thanks,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

  reply	other threads:[~2023-06-16 11:02 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-05 20:15 [PATCH v6 00/15] crypto: Add Intel Analytics Accelerator (IAA) crypto compression driver Tom Zanussi
2023-06-05 20:15 ` [PATCH v6 01/15] dmaengine: idxd: add wq driver name support for accel-config user tool Tom Zanussi
2023-06-05 20:15 ` [PATCH v6 02/15] dmaengine: idxd: add external module driver support for dsa_bus_type Tom Zanussi
2023-06-05 20:15 ` [PATCH v6 03/15] dmaengine: idxd: Export drv_enable/disable and related functions Tom Zanussi
2023-06-05 20:15 ` [PATCH v6 04/15] dmaengine: idxd: Export descriptor management functions Tom Zanussi
2023-06-05 20:15 ` [PATCH v6 05/15] dmaengine: idxd: Export wq resource " Tom Zanussi
2023-06-05 20:15 ` [PATCH v6 06/15] dmaengine: idxd: Add wq private data accessors Tom Zanussi
2023-06-05 20:15 ` [PATCH v6 07/15] dmaengine: idxd: add callback support for iaa crypto Tom Zanussi
2023-06-05 20:15 ` [PATCH v6 08/15] crypto: iaa - Add IAA Compression Accelerator Documentation Tom Zanussi
2023-06-05 20:15 ` [PATCH v6 09/15] crypto: iaa - Add Intel IAA Compression Accelerator crypto driver core Tom Zanussi
2023-06-05 20:15 ` [PATCH v6 10/15] crypto: iaa - Add per-cpu workqueue table with rebalancing Tom Zanussi
2023-06-05 20:15 ` [PATCH v6 11/15] crypto: iaa - Add compression mode management along with fixed mode Tom Zanussi
2023-06-05 20:15 ` [PATCH v6 12/15] crypto: iaa - Add support for deflate-iaa compression algorithm Tom Zanussi
2023-06-05 20:15 ` [PATCH v6 13/15] crypto: iaa - Add support for deflate-iaa-canned " Tom Zanussi
2023-06-16 10:55   ` Herbert Xu [this message]
2023-06-28 18:57     ` Tom Zanussi
2023-06-05 20:15 ` [PATCH v6 14/15] crypto: iaa - Add irq support for the crypto async interface Tom Zanussi
2023-06-05 20:15 ` [PATCH v6 15/15] crypto: iaa - Add IAA Compression Accelerator stats Tom Zanussi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZIw/jtxdg6O1O0j3@gondor.apana.org.au \
    --to=herbert@gondor.apana.org.au \
    --cc=dave.jiang@intel.com \
    --cc=davem@davemloft.net \
    --cc=dmaengine@vger.kernel.org \
    --cc=fenghua.yu@intel.com \
    --cc=giovanni.cabiddu@intel.com \
    --cc=james.guilford@intel.com \
    --cc=kanchana.p.sridhar@intel.com \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tom.zanussi@linux.intel.com \
    --cc=tony.luck@intel.com \
    --cc=vinodh.gopal@intel.com \
    --cc=vkoul@kernel.org \
    --cc=wajdi.k.feghali@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).