From: Matthew Wilcox <willy@infradead.org>
To: stsp <stsp2@yandex.ru>
Cc: Jeff Layton <jlayton@kernel.org>,
linux-kernel@vger.kernel.org,
Chuck Lever <chuck.lever@oracle.com>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Christian Brauner <brauner@kernel.org>,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 2/3] fd/locks: allow get the lock owner by F_OFD_GETLK
Date: Tue, 20 Jun 2023 18:05:19 +0100 [thread overview]
Message-ID: <ZJHcT9DPGWVlTsHg@casper.infradead.org> (raw)
In-Reply-To: <08612562-d2d7-a931-0c40-c401fff772c7@yandex.ru>
On Tue, Jun 20, 2023 at 08:45:21PM +0500, stsp wrote:
>
> 20.06.2023 19:36, Matthew Wilcox пишет:
> > On Tue, Jun 20, 2023 at 06:47:31PM +0500, stsp wrote:
> > > 20.06.2023 18:46, Matthew Wilcox пишет:
> > > > On Tue, Jun 20, 2023 at 06:39:07PM +0500, stsp wrote:
> > > > > Though it will, for sure, represent the
> > > > > task that _owns_ the lock.
> > > > No, it *DOESN'T*. I can open a file, SCM_RIGHTS pass it to another task
> > > > and then exit. Now the only owner of that lock is the recipient ...
> > > Won't I get the recipient's pid in an
> > > l_pid then?
> > You snipped the part where I pointed out that at times there can be
> > _no_ task that owns it. open a fd, set the lock, pass the fd to another
> > task, exit. until that task calls recvmsg(), no task owns it.
> Hmm, interesting case.
> So at least it seems if recipient also exits,
> then the untransferred fd gets closed.
yes, pretty sure this is done by garbage collection in the unix socket
handling code, though i've never looked at it. it's done that way
because annoying people can do things like open two sockets and send the
fd of each to the other, then exit.
> Does this mean, by any chance, that the
> recipient actually owns an fd before
> recvmsg() is done?
no, it's not in their fd table. they don't own it.
next prev parent reply other threads:[~2023-06-20 17:05 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-20 9:55 [PATCH 0/3] RFC: F_OFD_GETLK should provide more info Stas Sergeev
2023-06-20 9:55 ` [PATCH 1/3] fs/locks: F_UNLCK extension for F_OFD_GETLK Stas Sergeev
2023-06-20 10:46 ` Jeff Layton
2023-06-20 11:00 ` stsp
2023-06-20 11:15 ` Jeff Layton
2023-06-21 15:24 ` stsp
2023-06-20 9:55 ` [PATCH 2/3] fd/locks: allow get the lock owner by F_OFD_GETLK Stas Sergeev
2023-06-20 10:51 ` Jeff Layton
2023-06-20 10:57 ` stsp
2023-06-20 11:12 ` Jeff Layton
2023-06-20 11:45 ` stsp
2023-06-20 12:02 ` Jeff Layton
2023-06-20 12:34 ` stsp
2023-06-20 13:19 ` Jeff Layton
2023-06-20 13:39 ` stsp
2023-06-20 13:46 ` Matthew Wilcox
2023-06-20 13:47 ` stsp
2023-06-20 14:36 ` Matthew Wilcox
2023-06-20 15:45 ` stsp
2023-06-20 17:05 ` Matthew Wilcox [this message]
2023-06-21 2:54 ` stsp
2023-06-23 13:10 ` David Laight
2023-06-20 13:58 ` Jeff Layton
2023-06-21 6:57 ` stsp
2023-06-21 10:35 ` Jeff Layton
2023-06-21 10:42 ` stsp
2023-06-21 11:05 ` Jeff Layton
2023-06-21 11:22 ` stsp
2023-06-21 11:26 ` stsp
2023-06-23 15:25 ` Christian Brauner
2023-06-23 17:18 ` stsp
2023-06-27 16:00 ` Jeff Layton
2023-06-27 16:20 ` stsp
2023-06-20 9:55 ` [PATCH 3/3] selftests: add OFD lock tests Stas Sergeev
2023-06-20 11:06 ` Jeff Layton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZJHcT9DPGWVlTsHg@casper.infradead.org \
--to=willy@infradead.org \
--cc=brauner@kernel.org \
--cc=chuck.lever@oracle.com \
--cc=jlayton@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stsp2@yandex.ru \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).