From: Eduardo Valentin <evalenti@kernel.org>
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: Eduardo Valentin <evalenti@kernel.org>,
eduval@amazon.com, linux-pm@vger.kernel.org,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Amit Kucheria <amitk@kernel.org>, Zhang Rui <rui.zhang@intel.com>,
Jonathan Corbet <corbet@lwn.net>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 5/7] thermal: stats: introduce tz time in trip
Date: Tue, 20 Jun 2023 21:45:20 -0700 [thread overview]
Message-ID: <ZJKAYAx5768atJa8@uf8f119305bce5e.ant.amazon.com> (raw)
In-Reply-To: <CAJZ5v0hho1B6TiwshT4kYhs+Z4Q6xvnbgf8aoEZop=owkJHqxg@mail.gmail.com>
On Tue, Jun 20, 2023 at 07:27:57PM +0200, Rafael J. Wysocki wrote:
>
>
>
> On Fri, May 19, 2023 at 5:27 AM Eduardo Valentin <evalenti@kernel.org> wrote:
> >
> > From: Eduardo Valentin <eduval@amazon.com>
> >
> > This patch adds a statistic to report how long
> > the thermal zone spent on temperature intervals
> > created by each trip point. The first interval
> > is the range below the first trip point. All
> > subsequent intervals are accounted when temperature
> > is above the trip point temperature value.
> >
> > Samples:
> > $ cat /sys//class/thermal/thermal_zone0/stats/time_in_trip_ms
> > trip-1 0 0
>
> The above line is confusing.
>
> > trip0 -10000 35188
> > trip1 25000 0
>
> And the format violates the "one value per attribute" sysfs rule.
>
> > $ cat /sys//class/thermal/thermal_zone0/stats/time_in_trip_ms
> > trip-1 0 0
> > trip0 -10000 36901
> > trip1 25000 0
> > $ echo 25001 > /sys//class/thermal/thermal_zone0/emul_temp
> > $ cat /sys//class/thermal/thermal_zone0/stats/time_in_trip_ms
> > trip-1 0 0
> > trip0 -10000 47810
> > trip1 25000 2259
> > $ cat /sys//class/thermal/thermal_zone0/stats/time_in_trip_ms
> > trip-1 0 0
> > trip0 -10000 47810
> > trip1 25000 3224
> > $ echo 24001 > /sys//class/thermal/thermal_zone0/emul_temp
> > $ cat /sys//class/thermal/thermal_zone0/stats/time_in_trip_ms
> > trip-1 0 0
> > trip0 -10000 48960
> > trip1 25000 10080
> > $ cat /sys//class/thermal/thermal_zone0/stats/time_in_trip_ms
> > trip-1 0 0
> > trip0 -10000 49844
> > trip1 25000 10080
> >
> > Cc: "Rafael J. Wysocki" <rafael@kernel.org> (supporter:THERMAL)
> > Cc: Daniel Lezcano <daniel.lezcano@linaro.org> (supporter:THERMAL)
> > Cc: Amit Kucheria <amitk@kernel.org> (reviewer:THERMAL)
> > Cc: Zhang Rui <rui.zhang@intel.com> (reviewer:THERMAL)
> > Cc: Jonathan Corbet <corbet@lwn.net> (maintainer:DOCUMENTATION)
> > Cc: linux-pm@vger.kernel.org (open list:THERMAL)
> > Cc: linux-doc@vger.kernel.org (open list:DOCUMENTATION)
> > Cc: linux-kernel@vger.kernel.org (open list)
> >
> > Signed-off-by: Eduardo Valentin <eduval@amazon.com>
> > ---
> > .../driver-api/thermal/sysfs-api.rst | 2 +
> > drivers/thermal/thermal_sysfs.c | 86 +++++++++++++++++++
> > 2 files changed, 88 insertions(+)
> >
> > diff --git a/Documentation/driver-api/thermal/sysfs-api.rst b/Documentation/driver-api/thermal/sysfs-api.rst
> > index ed5e6ba4e0d7..4a2b92a7488c 100644
> > --- a/Documentation/driver-api/thermal/sysfs-api.rst
> > +++ b/Documentation/driver-api/thermal/sysfs-api.rst
> > @@ -359,6 +359,8 @@ Thermal zone device sys I/F, created once it's registered::
> > |---stats/reset_tz_stats: Writes to this file resets the statistics.
> > |---stats/max_gradient: The maximum recorded dT/dt in uC/ms.
> > |---stats/min_gradient: The minimum recorded dT/dt in uC/ms.
> > + |---stats/time_in_trip_ms: Time spent on each temperature interval of
> > + trip points.
>
> I would write "in each temperature interval between consecutive trip points".
Ok
>
> Doesn't this assume a specific temperature ordering of trip points?
> And so what if they are not ordered?
It does. I believe other things will break if they are not ordered. Like the temperature update
against the governor throttle callback invocation in the thermal core.
--
All the best,
Eduardo Valentin
next prev parent reply other threads:[~2023-06-21 4:45 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-19 3:27 [PATCH 0/7] thermal: enhancements on thermal stats Eduardo Valentin
2023-05-19 3:27 ` [PATCH 1/7] thermal: stats: track time each dev changes due to tz Eduardo Valentin
2023-06-20 13:43 ` Rafael J. Wysocki
2023-06-21 4:37 ` Eduardo Valentin
2023-05-19 3:27 ` [PATCH 2/7] thermal: stats: track number of change requests " Eduardo Valentin
2023-06-20 17:12 ` Rafael J. Wysocki
2023-06-21 4:40 ` Eduardo Valentin
2023-05-19 3:27 ` [PATCH 3/7] thermal: stats: introduce thermal zone stats/ directory Eduardo Valentin
2023-05-19 3:27 ` [PATCH 4/7] thermal: stats: introduce thermal zone stats/min_gradient Eduardo Valentin
2023-06-20 17:17 ` Rafael J. Wysocki
2023-05-19 3:27 ` [PATCH 5/7] thermal: stats: introduce tz time in trip Eduardo Valentin
2023-06-20 17:27 ` Rafael J. Wysocki
2023-06-21 4:45 ` Eduardo Valentin [this message]
2023-06-23 16:40 ` Rafael J. Wysocki
2023-06-28 20:00 ` Eduardo Valentin
2023-05-19 3:27 ` [PATCH 6/7] ythermal: core: report errors to governors Eduardo Valentin
2023-06-20 17:29 ` Rafael J. Wysocki
2023-06-21 4:49 ` Eduardo Valentin
2023-05-19 3:27 ` [PATCH 7/7] thermal: stats: add error accounting to thermal zone Eduardo Valentin
2023-06-20 17:32 ` Rafael J. Wysocki
2023-06-21 4:50 ` Eduardo Valentin
2023-05-24 18:22 ` [PATCH 0/7] thermal: enhancements on thermal stats Rafael J. Wysocki
2023-06-05 23:28 ` Eduardo Valentin
2023-06-20 19:05 ` Daniel Lezcano
2023-06-21 4:24 ` Eduardo Valentin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZJKAYAx5768atJa8@uf8f119305bce5e.ant.amazon.com \
--to=evalenti@kernel.org \
--cc=amitk@kernel.org \
--cc=corbet@lwn.net \
--cc=daniel.lezcano@linaro.org \
--cc=eduval@amazon.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).