From: Herbert Xu <herbert@gondor.apana.org.au>
To: Mario Limonciello <mario.limonciello@amd.com>
Cc: Tom Lendacky <thomas.lendacky@amd.com>,
John Allen <john.allen@amd.com>,
"David S . Miller" <davem@davemloft.net>,
linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org
Subject: Re: [PATCH v4 05/11] crypto: ccp: Add support for fetching a nonce for dynamic boost control
Date: Fri, 23 Jun 2023 16:14:03 +0800 [thread overview]
Message-ID: <ZJVUS4cWOSDif2Rp@gondor.apana.org.au> (raw)
In-Reply-To: <20230608111757.32054-6-mario.limonciello@amd.com>
On Thu, Jun 08, 2023 at 06:17:51AM -0500, Mario Limonciello wrote:
>
> +const struct file_operations dbc_fops = {
> + .owner = THIS_MODULE,
> + .unlocked_ioctl = dbc_ioctl,
> +};
This needs to be static.
Thanks,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2023-06-23 8:14 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-08 11:17 [PATCH v4 00/11] Add dynamic boost control support Mario Limonciello
2023-06-08 11:17 ` [PATCH v4 01/11] crypto: ccp: Rename macro for security attributes Mario Limonciello
2023-06-08 11:17 ` [PATCH v4 02/11] crypto: ccp: Add support for displaying PSP firmware versions Mario Limonciello
2023-06-08 11:17 ` [PATCH v4 03/11] crypto: ccp: Add bootloader and TEE version offsets Mario Limonciello
2023-06-08 11:17 ` [PATCH v4 04/11] crypto: ccp: move setting PSP master to earlier in the init Mario Limonciello
2023-06-08 11:17 ` [PATCH v4 05/11] crypto: ccp: Add support for fetching a nonce for dynamic boost control Mario Limonciello
2023-06-23 8:14 ` Herbert Xu [this message]
2023-06-08 11:17 ` [PATCH v4 06/11] crypto: ccp: Add support for setting user ID " Mario Limonciello
2023-06-08 11:17 ` [PATCH v4 07/11] crypto: ccp: Add support for getting and setting DBC parameters Mario Limonciello
2023-06-08 11:17 ` [PATCH v4 08/11] crypto: ccp: Add a sample library for ioctl use Mario Limonciello
2023-06-08 11:17 ` [PATCH v4 09/11] crypto: ccp: Add a sample python script for Dynamic Boost Control Mario Limonciello
2023-06-08 11:17 ` [PATCH v4 10/11] crypto: ccp: Add unit tests for dynamic boost control Mario Limonciello
2023-06-08 11:17 ` [PATCH v4 11/11] crypto: ccp: Add Mario to MAINTAINERS Mario Limonciello
2023-06-21 20:59 ` [PATCH v4 00/11] Add dynamic boost control support Tom Lendacky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZJVUS4cWOSDif2Rp@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=davem@davemloft.net \
--cc=john.allen@amd.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mario.limonciello@amd.com \
--cc=thomas.lendacky@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).