From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75C81C00528 for ; Mon, 24 Jul 2023 15:41:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229566AbjGXPln (ORCPT ); Mon, 24 Jul 2023 11:41:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56312 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229461AbjGXPlk (ORCPT ); Mon, 24 Jul 2023 11:41:40 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4C7DAB7; Mon, 24 Jul 2023 08:41:39 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id D571560C49; Mon, 24 Jul 2023 15:41:38 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3FBE2C433C8; Mon, 24 Jul 2023 15:41:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1690213298; bh=FwmJyUFEwRmW6GyLKrRzaoOIFKD1ZixYyekFLFBjYm8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=KxZNmLvGWF0DcvPN5zy994G1T8upsOy4oNv0aa5nIm9dPf/QVVpQZn848TRZ1rklg 3W1Bdkz6crdOaUKTZJTf63y+9/GThMSsqtya4Gl9U9YgsTgm0RLlGuHo6H6C5/1VaI 9zWORpzVrZesTnVYEsypK7vADRQiw93qJVtLfSG/JjoSJ1ZfB0015D7Sf5a4wKrXe/ kGnkkRJY/FoAVIib6/IqSS/08ZYLBSqS8CQiwQ60ySUCkGDBDg5Xc9nf4w7qQK40yc siMJJO9hrCcKMdsVuPTxhP/ROnUDZe+VLzRnAYTnPhxlJIsHxIQqHdOGfX/Oe4wP9Y 91yoKaZiERL/Q== Received: from johan by xi.lan with local (Exim 4.96) (envelope-from ) id 1qNxgz-0005Ey-0h; Mon, 24 Jul 2023 17:41:49 +0200 Date: Mon, 24 Jul 2023 17:41:49 +0200 From: Johan Hovold To: Krishna Kurapati PSSNV Cc: Thinh Nguyen , Greg Kroah-Hartman , Philipp Zabel , Andy Gross , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Felipe Balbi , Wesley Cheng , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, quic_pkondeti@quicinc.com, quic_ppratap@quicinc.com, quic_jackp@quicinc.com, quic_harshq@quicinc.com, ahalaney@redhat.com, quic_shazhuss@quicinc.com Subject: Re: [PATCH v9 03/10] usb: dwc3: core: Access XHCI address space temporarily to read port info Message-ID: References: <20230621043628.21485-1-quic_kriskura@quicinc.com> <20230621043628.21485-4-quic_kriskura@quicinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [ Please remember to trim your replies. ] On Sun, Jul 23, 2023 at 08:29:47PM +0530, Krishna Kurapati PSSNV wrote: > On 6/27/2023 5:15 PM, Johan Hovold wrote: > > On Wed, Jun 21, 2023 at 10:06:21AM +0530, Krishna Kurapati wrote: > >> +#define XHCI_EXT_PORT_MAJOR(x) (((x) >> 24) & 0xff) > >> +#define XHCI_EXT_PORT_MINOR(x) (((x) >> 16) & 0xff) > >> +#define XHCI_EXT_PORT_COUNT(x) (((x) >> 8) & 0xff) > > > > Again, don't copy defines from xhci. > > > > Looks like these should be moved to the xhci-ext-caps.h header along > > with struct xhci_protocol_caps. > > Moving the defines would be sufficient right ? Just wanted to know if > there is any reason you are suggesting to move the structure as well so > that I can update commit text accordingly. The defines are used for parsing the members of struct xhci_protocol_caps and they belong together even if no driver has apparently ever used the structure. Johan