From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC7E6EB64DA for ; Fri, 14 Jul 2023 08:09:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235294AbjGNIJ0 (ORCPT ); Fri, 14 Jul 2023 04:09:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59468 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234939AbjGNIIw (ORCPT ); Fri, 14 Jul 2023 04:08:52 -0400 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4864D46B6; Fri, 14 Jul 2023 01:06:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1689321990; x=1720857990; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=fkEz5ngu5Jx0yxp4LTMvoYpwTKcv6182sEOb+9SRMDc=; b=oJ5rrXQeMX7aUpi15rx0ixnvmLEjJoIk6kCwYR60N7KRnPFZkCYM6Ja8 RvH/9N5yRb55b3IqJ1bGCBuOvS8ohxqlrpvVelzd/U6Nk+KLbR10ThMWj ETvRpCz6093gquQI0cBhlm1jUvXkzsCaughntPJuKvD3bc0upqEf7szSM If1MuViNl9wmv6UjEW4h1T/NeD6kmAnfPCiTMbzAon5PsfypWtdbHgTLw rEZG/c3+dHa9x3zzYXt8iTe0Ddo24pUs+nH+YWYrMdBPtfCFMfkZHQSa2 8ZHeQHWV4G9pcWwzZF9DDrvl/F39f6zm8J7XknHIlTJS1Wkr4z7Bs7jQh g==; X-IronPort-AV: E=McAfee;i="6600,9927,10770"; a="345014317" X-IronPort-AV: E=Sophos;i="6.01,204,1684825200"; d="scan'208";a="345014317" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Jul 2023 01:06:03 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10770"; a="812338488" X-IronPort-AV: E=Sophos;i="6.01,204,1684825200"; d="scan'208";a="812338488" Received: from smile.fi.intel.com ([10.237.72.54]) by FMSMGA003.fm.intel.com with ESMTP; 14 Jul 2023 01:05:58 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1qKDoL-002bC8-1D; Fri, 14 Jul 2023 11:05:57 +0300 Date: Fri, 14 Jul 2023 11:05:57 +0300 From: Andy Shevchenko To: luoruihong Cc: ilpo.jarvinen@linux.intel.com, gregkh@linuxfoundation.org, jirislaby@kernel.org, linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, luoruihong@xiaomi.com, weipengliang@xiaomi.com, wengjinfei@xiaomi.com Subject: Re: Message-ID: References: <64b09dbb.630a0220.e80b9.e2ed@mx.google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <64b09dbb.630a0220.e80b9.e2ed@mx.google.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 14, 2023 at 08:58:29AM +0800, luoruihong wrote: > On Thu, Jul 13, 2023 at 07:51:14PM +0300, Andy Shevchenko wrote: > > On Thu, Jul 13, 2023 at 08:42:36AM +0800, Ruihong Luo wrote: > > > Preserve the original value of the Divisor Latch Fraction (DLF) register. > > > When the DLF register is modified without preservation, it can disrupt > > > the baudrate settings established by firmware or bootloader, leading to > > > data corruption and the generation of unreadable or distorted characters. > > > > You forgot to add my tag. Why? Do you think the name of variable warrants this? > > Whatever, > > Reviewed-by: Andy Shevchenko > > > > Next time if you don't pick up somebody's tag, care to explain in the changelog > > why. > > > > > Fixes: 701c5e73b296 ("serial: 8250_dw: add fractional divisor support") > > > Signed-off-by: Ruihong Luo > > I'm sorry, I didn't know about this rule. Thank you for helping me add > the missing tags back and for all your previous kind assistance. For now no need to do anything, just wait for Ilpo's and/or Greg's answer(s), -- With Best Regards, Andy Shevchenko