From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7306EEB64DC for ; Mon, 17 Jul 2023 08:03:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231219AbjGQIDl (ORCPT ); Mon, 17 Jul 2023 04:03:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59706 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230070AbjGQIDj (ORCPT ); Mon, 17 Jul 2023 04:03:39 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F1ABD10F for ; Mon, 17 Jul 2023 01:03:38 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 891C260FB4 for ; Mon, 17 Jul 2023 08:03:38 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EBF2CC433C7; Mon, 17 Jul 2023 08:03:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1689581017; bh=fxCzi9cqQ/6Te9Id+fLIHCQJFVg7LEXG2cA0E+qADbg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=FISKc+7gCFhCRRl0wkH4LKhJ2TtLo1Zcbd5H+B09PDWFKUUyJcBeJg8VL+QClvgea y4E77RexFfMjBLyDjcaeMg4lWfeICFn4Oveq5XGMC+aUifC1cYMA3yCcRwnIisZhxr Jmpm2nph7AAyTLi77S1ghli1vuBZpaVXqYg9dV3rWYMOUiVBlrmTDD1YOw7pTILx02 YQloLQwMXxGqmcyRSvTbK3zNyJJMG3uNkc4gP8mT5NWVi7UDBhl1QN06YpwygQOI9l o8qBEmIhDKjm3J9+L4ZVo00gG+Egb/vpHbwsCXAsatTAhdqhfCrUtZvhHwUBPryh7h 4UURKLSAGBsLQ== Date: Mon, 17 Jul 2023 10:03:32 +0200 From: Keith Busch To: Sean Wang Cc: "highenthalpyh@gmail.com" , "axboe@kernel.dk" , "hch@lst.de" , "linux-kernel@vger.kernel.org" , "linux-nvme@lists.infradead.org" , "sagi@grimberg.me" , "xuwd1@hotmail.com" Subject: Re: [PATCH] nvme-pci: add NVME_QUIRK_DELAY_BEFORE_CHK_RDY for MAXIO MAP1602 Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 17, 2023 at 07:41:26AM +0000, Sean Wang wrote: > My two SSDs are from different companies, but they all use MaxIO 1602 nvme controllers. > > After applying this patch, they could work. > > Otherwise, here is a workaround to make live cd to recognize these SSDs: > > > echo “1” > /sys/bus/pci/devices/0000:02:00.0/remove > sleep 1 > echo “1” > /sys/bus/pci/rescan > > Where device id (02:00.0) could be found via > > lspci -nn -d ::0108 We have a generic solution for such devices as of 6.5-rc2 so it should work now; however, it's still recommended to get devices with this behavior in the quirk list in order to ensure that the we get udev to generate deterministic symlinks. Since this controller is used by multiple vendors, though, it's unclear if this quirk applies to all variations.