Re: [PATCH v2 4/4] rtc: jz4740: Support for fine-tuning the RTC clock

[Paul Cercueil <paul@crapouillou.net>]

Hi Bot,

Well this report is on my RFC patch so I consider the patchset to still 
be valid.

If I can actually test my RFC patch I'll send it again with this bug 
fixed.

Cheers,
-Paul


Le sam. 29 oct. 2022 à 16:51:53 +0800, kernel test robot 
<lkp@intel.com> a écrit :
> Hi Paul,
> 
> I love your patch! Yet something to improve:
> 
> [auto build test ERROR on abelloni/rtc-next]
> [also build test ERROR on robh/for-next linus/master v6.1-rc2 
> next-20221028]
> [If your patch is applied to the wrong git tree, kindly drop us a 
> note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch#_base_tree_information]
> 
> url:    
> https://github.com/intel-lab-lkp/linux/commits/Paul-Cercueil/rtc-ingenic-various-updates/20221029-065805
> base:   
> https://git.kernel.org/pub/scm/linux/kernel/git/abelloni/linux.git 
> rtc-next
> patch link:    
> https://lore.kernel.org/r/20221028225519.89210-5-paul%40crapouillou.net
> patch subject: [PATCH v2 4/4] rtc: jz4740: Support for fine-tuning 
> the RTC clock
> config: sparc64-randconfig-c043-20221028
> compiler: sparc64-linux-gcc (GCC) 12.1.0
> reproduce (this is a W=1 build):
>         wget 
> https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross 
> -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         # 
> https://github.com/intel-lab-lkp/linux/commit/b73614c39710acaff7977b8d3ec935105cf59757
>         git remote add linux-review 
> https://github.com/intel-lab-lkp/linux
>         git fetch --no-tags linux-review 
> Paul-Cercueil/rtc-ingenic-various-updates/20221029-065805
>         git checkout b73614c39710acaff7977b8d3ec935105cf59757
>         # save the config file
>         mkdir build_dir && cp config build_dir/.config
>         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 
> make.cross W=1 O=build_dir ARCH=sparc64 SHELL=/bin/bash drivers/rtc/
> 
> If you fix the issue, kindly add following tag where applicable
> | Reported-by: kernel test robot <lkp@intel.com>
> 
> All errors (new ones prefixed by >>):
> 
>    In file included from <command-line>:
>    drivers/rtc/rtc-jz4740.c: In function 'jz4740_rtc_set_offset':
>>>  include/linux/compiler_types.h:357:45: error: call to 
>>> '__compiletime_assert_248' declared with attribute error: 
>>> FIELD_PREP: value too large for the field
>      357 |         _compiletime_assert(condition, msg, 
> __compiletime_assert_, __COUNTER__)
>          |                                             ^
>    include/linux/compiler_types.h:338:25: note: in definition of 
> macro '__compiletime_assert'
>      338 |                         prefix ## suffix();                
>              \
>          |                         ^~~~~~
>    include/linux/compiler_types.h:357:9: note: in expansion of macro 
> '_compiletime_assert'
>      357 |         _compiletime_assert(condition, msg, 
> __compiletime_assert_, __COUNTER__)
>          |         ^~~~~~~~~~~~~~~~~~~
>    include/linux/build_bug.h:39:37: note: in expansion of macro 
> 'compiletime_assert'
>       39 | #define BUILD_BUG_ON_MSG(cond, msg) 
> compiletime_assert(!(cond), msg)
>          |                                     ^~~~~~~~~~~~~~~~~~
>    include/linux/bitfield.h:68:17: note: in expansion of macro 
> 'BUILD_BUG_ON_MSG'
>       68 |                 
> BUILD_BUG_ON_MSG(__builtin_constant_p(_val) ?           \
>          |                 ^~~~~~~~~~~~~~~~
>    include/linux/bitfield.h:114:17: note: in expansion of macro 
> '__BF_FIELD_CHECK'
>      114 |                 __BF_FIELD_CHECK(_mask, 0ULL, _val, 
> "FIELD_PREP: ");    \
>          |                 ^~~~~~~~~~~~~~~~
>    drivers/rtc/rtc-jz4740.c:256:17: note: in expansion of macro 
> 'FIELD_PREP'
>      256 |         nc1hz = FIELD_PREP(JZ_RTC_REGULATOR_NC1HZ_MASK, 
> nc1hz);
>          |                 ^~~~~~~~~~
> 
> 
> vim +/__compiletime_assert_248 +357 include/linux/compiler_types.h
> 
> eb5c2d4b45e3d2 Will Deacon 2020-07-21  343
> eb5c2d4b45e3d2 Will Deacon 2020-07-21  344  #define 
> _compiletime_assert(condition, msg, prefix, suffix) \
> eb5c2d4b45e3d2 Will Deacon 2020-07-21  345  
> 	__compiletime_assert(condition, msg, prefix, suffix)
> eb5c2d4b45e3d2 Will Deacon 2020-07-21  346
> eb5c2d4b45e3d2 Will Deacon 2020-07-21  347  /**
> eb5c2d4b45e3d2 Will Deacon 2020-07-21  348   * compiletime_assert - 
> break build and emit msg if condition is false
> eb5c2d4b45e3d2 Will Deacon 2020-07-21  349   * @condition: a 
> compile-time constant condition to check
> eb5c2d4b45e3d2 Will Deacon 2020-07-21  350   * @msg:       a message 
> to emit if condition is false
> eb5c2d4b45e3d2 Will Deacon 2020-07-21  351   *
> eb5c2d4b45e3d2 Will Deacon 2020-07-21  352   * In tradition of POSIX 
> assert, this macro will break the build if the
> eb5c2d4b45e3d2 Will Deacon 2020-07-21  353   * supplied condition is 
> *false*, emitting the supplied error message if the
> eb5c2d4b45e3d2 Will Deacon 2020-07-21  354   * compiler has support 
> to do so.
> eb5c2d4b45e3d2 Will Deacon 2020-07-21  355   */
> eb5c2d4b45e3d2 Will Deacon 2020-07-21  356  #define 
> compiletime_assert(condition, msg) \
> eb5c2d4b45e3d2 Will Deacon 2020-07-21 @357  
> 	_compiletime_assert(condition, msg, __compiletime_assert_, 
> __COUNTER__)
> eb5c2d4b45e3d2 Will Deacon 2020-07-21  358
> 
> --
> 0-DAY CI Kernel Test Service
> https://01.org/lkp