From: Brian Masney <bmasney@redhat.com>
To: Hugo Villeneuve <hugo@hugovil.com>
Cc: jejb@linux.ibm.com, martin.petersen@oracle.com,
alim.akhtar@samsung.com, avri.altman@wdc.com, bvanassche@acm.org,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] scsi: ufs: core: convert to dev_err_probe() in hba_init
Date: Wed, 9 Aug 2023 14:56:33 -0400 [thread overview]
Message-ID: <ZNPhYRslrcwAHo3Y@brian-x1> (raw)
In-Reply-To: <20230808162929.a1b784ad42bd346cd87747b9@hugovil.com>
On Tue, Aug 08, 2023 at 04:29:29PM -0400, Hugo Villeneuve wrote:
> On Tue, 8 Aug 2023 10:26:49 -0400
> Brian Masney <bmasney@redhat.com> wrote:
>
> > Convert ufshcd_variant_hba_init() over to use dev_err_probe() to avoid
> > log messages like the following on bootup:
> >
> > ufshcd-qcom 1d84000.ufs: ufshcd_variant_hba_init: variant qcom init
> > failed err -517
> >
> > While changes are being made here, let's go ahead and clean up the rest
> > of that function.
>
> Hi,
> you should not combine code cleanup and fixes/improvements in the same
> patch, split them.
This is a pretty simple patch as is, and split up the code clean up is
not very useful on its own. I'll just skip doing the code cleanup and
only post the dev_err_probe() change in v2.
Brian
next prev parent reply other threads:[~2023-08-09 18:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-08 14:26 [PATCH 0/2] scsi: ufs: convert probe to use dev_err_probe() Brian Masney
2023-08-08 14:26 ` [PATCH 1/2] scsi: ufs: core: convert to dev_err_probe() in hba_init Brian Masney
2023-08-08 20:29 ` Hugo Villeneuve
2023-08-09 18:56 ` Brian Masney [this message]
2023-08-08 14:26 ` [PATCH 2/2] scsi: ufs: host: convert to dev_err_probe() in pltfrm_init Brian Masney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZNPhYRslrcwAHo3Y@brian-x1 \
--to=bmasney@redhat.com \
--cc=alim.akhtar@samsung.com \
--cc=avri.altman@wdc.com \
--cc=bvanassche@acm.org \
--cc=hugo@hugovil.com \
--cc=jejb@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).