linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Patrick Steinhardt <ps@pks.im>
To: "Limonciello, Mario" <mario.limonciello@amd.com>
Cc: Jarkko Sakkinen <jarkko@kernel.org>,
	linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org,
	Thorsten Leemhuis <regressions@leemhuis.info>,
	charles.d.prestopine@intel.com, rafael.j.wysocki@intel.com,
	len.brown@intel.com, stable@vger.kernel.org,
	Todd Brandt <todd.e.brandt@intel.com>
Subject: Re: [PATCH] tpm: Don't make vendor check required for probe
Date: Sat, 19 Aug 2023 15:35:15 +0200	[thread overview]
Message-ID: <ZODFE7ngbLAo2vCx@ncase> (raw)
In-Reply-To: <719602ec-c9fc-4a72-9585-d50595cb6dca@amd.com>

[-- Attachment #1: Type: text/plain, Size: 1425 bytes --]

On Fri, Aug 18, 2023 at 06:57:57PM -0500, Limonciello, Mario wrote:
> 
> 
> On 8/18/2023 6:44 PM, Jarkko Sakkinen wrote:
> > On Fri Aug 18, 2023 at 10:38 PM UTC, Limonciello, Mario wrote:
> >>
> >>
> >> On 8/18/2023 5:07 PM, Jarkko Sakkinen wrote:
> >>> On Fri Aug 18, 2023 at 6:15 PM UTC, Mario Limonciello wrote:
> >>>> The vendor check introduced by commit 554b841d4703 ("tpm: Disable RNG for
> >>>> all AMD fTPMs") doesn't work properly on Intel fTPM.  The TPM doesn't reply
> >>>> at bootup and returns back the command code.
> >>>
> >>> Is this reproducible with any production hardware? You are stating it
> >>> as it was reproducible categorically with any Intel fTPM.
> >>>
> >>
> >> Yes, it's affecting production hardware too.
> >> Someone came to the kernel bugzilla and reported a regression on 6.4.11
> >> on a Lenovo Intel laptop as well.
> > 
> > Now the description says that cateogrically all Intel fTPM's fail.
> 
> According to Todd this change caused 5 *different* reference Intel 
> systems all to fail.  I know they're not production hardware, but still..

For what it's worth, I can confirm that this issue also occurs on an
ASUS Z170I motherboard with Intel i3 7100U and an integrated fTPM. If it
helps I'm happy to try out the proposed patch -- for now I simply
reverted 554b841d4703 ("tpm: Disable RNG for all AMD fTPMs"), which
resolved the issue for me.

Patrick

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2023-08-19 13:38 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-18 18:15 [PATCH] tpm: Don't make vendor check required for probe Mario Limonciello
2023-08-18 22:07 ` Jarkko Sakkinen
2023-08-18 22:38   ` Limonciello, Mario
2023-08-18 23:44     ` Jarkko Sakkinen
2023-08-18 23:57       ` Limonciello, Mario
2023-08-19 13:35         ` Patrick Steinhardt [this message]
2023-08-22 11:25         ` Jarkko Sakkinen
2023-08-28 15:47 ` Dusty Mabe
2023-09-04 18:15   ` Jarkko Sakkinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZODFE7ngbLAo2vCx@ncase \
    --to=ps@pks.im \
    --cc=charles.d.prestopine@intel.com \
    --cc=jarkko@kernel.org \
    --cc=len.brown@intel.com \
    --cc=linux-integrity@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mario.limonciello@amd.com \
    --cc=rafael.j.wysocki@intel.com \
    --cc=regressions@leemhuis.info \
    --cc=stable@vger.kernel.org \
    --cc=todd.e.brandt@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).