From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 63996C004C0 for ; Fri, 20 Oct 2023 18:52:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229787AbjJTSwt (ORCPT ); Fri, 20 Oct 2023 14:52:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48766 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229660AbjJTSwr (ORCPT ); Fri, 20 Oct 2023 14:52:47 -0400 Received: from mail-pf1-x431.google.com (mail-pf1-x431.google.com [IPv6:2607:f8b0:4864:20::431]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5662C124 for ; Fri, 20 Oct 2023 11:52:42 -0700 (PDT) Received: by mail-pf1-x431.google.com with SMTP id d2e1a72fcca58-6b2018a11efso1098182b3a.0 for ; Fri, 20 Oct 2023 11:52:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1697827961; x=1698432761; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=DTSJspe6v544wqJ5pbefnUtP+UIVc6mp9wCNcSSACRk=; b=RoCP1pG0OtI7hvdVowuM0qQ6phFQYo3OugHx+x7/7oVjs9w7qE0jEkWtH8pt68apDM oGOdL5H3y0eizlDhq2TPQ8JKwJAhXNL5y8vgv/O0HRWG+zG4N60iwipCQbHBCMW0i3Lm /eOC+OcO5CNaV3sPRo415/1ej5IbUiEq4NNxCPVSboUKAFRL992eNDNx1nY5XB8HWxV+ yfMCOcVNzMuvJfg5PLTnVwAIF14xk7Oj9wllDIRhYMOQXKLBCYqUHR2FpZ6LTRj+m+Pb tnf/zF4SOIYE9npCXIc88mkpT+Mqs4ua4J2hgKXCh4GG2uQ3ktAz53Huo0q61lel2MDh 8qvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697827961; x=1698432761; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=DTSJspe6v544wqJ5pbefnUtP+UIVc6mp9wCNcSSACRk=; b=VJ3BtvjCvjYYZclk1uQTzAOc8z6jcexCSYlt1jDGWhnEBzrfLD5MfJbbc0KlyQq244 1jWLgp6+YtyAu23CO3RhxlXp70tP7S7EhPrmzwxRMdiTbH2DOjRHIQITIYHxlsWPCHS8 yl6D39qL/onLjrRRbRqHO3BjtDVDhfvyHF99bxzIPio5lS0CZAmbNKUxeFIOO9ApL9ou q79MZOzfRnnPPN108ACdSVcYdsN59Ir1/eVoyaoZLET3ivf9TSfyVJZNpiZQnCAygtZY qf1jjeoWz7ZYgKFhwqg0/XO9HhKCeKXnzTAP/ZPl7eQNtlnc6K8p5kXRRrdxygPfwOEv Us0w== X-Gm-Message-State: AOJu0Yxf9fj0fbV+9/gPGReHdbR4JN9M/LR61KShKf2c6ullWApSwd/K l6kGDBOQFKQtEAH9ERQm9HERJrPaTIux+ADJTRacIg== X-Google-Smtp-Source: AGHT+IGtSG0CdpLv7VLLWwthXlAkWWoVEYHlOSNc8IsWEjTOOD4D2zAepXWaocbQwjctb1/FcypFIQ== X-Received: by 2002:a05:6a00:24d1:b0:6be:2720:16a5 with SMTP id d17-20020a056a0024d100b006be272016a5mr3028317pfv.33.1697827961208; Fri, 20 Oct 2023 11:52:41 -0700 (PDT) Received: from google.com (175.199.125.34.bc.googleusercontent.com. [34.125.199.175]) by smtp.gmail.com with ESMTPSA id z123-20020a626581000000b006b341144ad0sm1950069pfb.102.2023.10.20.11.52.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Oct 2023 11:52:40 -0700 (PDT) Date: Fri, 20 Oct 2023 11:52:34 -0700 From: David Matlack To: Sean Christopherson Cc: stable@vger.kernel.org, Greg Kroah-Hartman , kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Pattara Teerapong , David Stevens , Yiwei Zhang , Paul Hsia , Paolo Bonzini Subject: Re: [PATCH] KVM: x86/mmu: Stop zapping invalidated TDP MMU roots asynchronously Message-ID: References: <20231019201138.2076865-1-seanjc@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231019201138.2076865-1-seanjc@google.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2023-10-19 01:11 PM, Sean Christopherson wrote: > [ Upstream commit 0df9dab891ff0d9b646d82e4fe038229e4c02451 ] > > Stop zapping invalidate TDP MMU roots via work queue now that KVM > preserves TDP MMU roots until they are explicitly invalidated. Zapping > roots asynchronously was effectively a workaround to avoid stalling a vCPU > for an extended during if a vCPU unloaded a root, which at the time > happened whenever the guest toggled CR0.WP (a frequent operation for some > guest kernels). > [...] > > Reported-by: Pattara Teerapong > Cc: David Stevens > Cc: Yiwei Zhang > Cc: Paul Hsia > Cc: stable@vger.kernel.org > Signed-off-by: Sean Christopherson > Message-Id: <20230916003916.2545000-4-seanjc@google.com> > Signed-off-by: Paolo Bonzini > Cc: David Matlack > Signed-off-by: Sean Christopherson > --- Reviewed-by: David Matlack Tested-by: David Matlack (Ran all KVM selftests and kvm-unit-tests with lockdep enabled.)