From: Wyes Karny <wyes.karny@amd.com>
To: Doug Smythies <dsmythies@telus.net>
Cc: 'Peng Liu' <pngliu@hotmail.com>,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
liupeng17@lenovo.com, lenb@kernel.org
Subject: Re: [PATCH] tools/power turbostat: Fix Bzy_MHz calculation equation
Date: Fri, 3 Nov 2023 10:18:34 +0530 [thread overview]
Message-ID: <ZUR7oh8oWyn7/mz2@BLR-5CG13462PL.amd.com> (raw)
In-Reply-To: <002801da0da1$adb83fc0$0928bf40$@telus.net>
On 02 Nov 08:31, Doug Smythies wrote:
> Hi Peng and Wyes,
>
> Just for your information about your recent "ping"s about your turbostat patches:
>
> Please be aware that there is rarely any reply. There tends to be about 2 turbostat updates released per year. Your patches are in patchworks [1], as are some others, including an old one of mine from 2023.04.03
> Eventually there will be an update, and hopefully it will include all our patches.
Thanks Doug for the information.
Regards,
Wyes
>
> [1] https://patchwork.kernel.org/project/linux-pm/list/?series=&submitter=&state=&q=&archive=&delegate=107
>
> ... Doug
>
> On 2023.10.29 08:12 Peng Liu wrote:
>
> > Ping
> >
> > On 2023/10/7 13:46, Peng Liu wrote:
> >> From: Peng Liu <liupeng17@lenovo.com>
> >>
> >> To calculate Bzy_MHz, TSC_delta should multiply APERF_delta instead
> >> of dividing it.
> >>
> >> Signed-off-by: Peng Liu <liupeng17@lenovo.com>
> >> ---
> >> tools/power/x86/turbostat/turbostat.8 | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/tools/power/x86/turbostat/turbostat.8 b/tools/power/x86/turbostat/turbostat.8
> >> index 8f08c3fd498d..1ba6340d3b3d 100644
> >> --- a/tools/power/x86/turbostat/turbostat.8
> >> +++ b/tools/power/x86/turbostat/turbostat.8
> >> @@ -370,7 +370,7 @@ below the processor's base frequency.
> >>
> >> Busy% = MPERF_delta/TSC_delta
> >>
> >> -Bzy_MHz = TSC_delta/APERF_delta/MPERF_delta/measurement_interval
> >> +Bzy_MHz = TSC_delta*APERF_delta/MPERF_delta/measurement_interval
> >>
> >> Note that these calculations depend on TSC_delta, so they
> >> are not reliable during intervals when TSC_MHz is not running at the base frequency.
>
next prev parent reply other threads:[~2023-11-03 4:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-07 5:46 [PATCH] tools/power turbostat: Fix Bzy_MHz calculation equation Peng Liu
2023-10-30 3:11 ` Peng Liu
2023-11-02 15:31 ` Doug Smythies
2023-11-03 1:55 ` Peng Liu
2023-11-03 4:48 ` Wyes Karny [this message]
2023-11-28 1:39 ` Len Brown
2023-11-29 1:57 ` 回复: [External] " Peng Peng17 Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZUR7oh8oWyn7/mz2@BLR-5CG13462PL.amd.com \
--to=wyes.karny@amd.com \
--cc=dsmythies@telus.net \
--cc=lenb@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=liupeng17@lenovo.com \
--cc=pngliu@hotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).